Owen LinandGitHub a3be74143a fix(guardian, app-server): introduce guardian review ids (#17298) ...

## Description

This PR introduces `review_id` as the stable identifier for guardian
reviews and exposes it in app-server `item/autoApprovalReview/started`
and `item/autoApprovalReview/completed` events.

Internally, guardian rejection state is now keyed by `review_id` instead
of the reviewed tool item ID. `target_item_id` is still included when a
review maps to a concrete thread item, but it is no longer overloaded as
the review lifecycle identifier.

## Motivation

We'd like to give users the ability to preempt a guardian review while
it's running (approve or decline).

However, we can't implement the API that allows the user to override a
running guardian review because we didn't have a unique `review_id` per
guardian review. Using `target_item_id` is not correct since:
- with execve reviews, there can be multiple execve calls (and therefore
guardian reviews) per shell command
- with network policy reviews, there is no target item ID

The PR that actually implements user overrides will use `review_id` as
the stable identifier.

2026-04-10 16:21:02 -07:00

..

AccountLoginCompletedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

AccountRateLimitsUpdatedNotification.json

Option to Notify Workspace Owner When Usage Limit is Reached (#16969)

2026-04-09 21:15:17 -07:00

AccountUpdatedNotification.json

Option to Notify Workspace Owner When Usage Limit is Reached (#16969)

2026-04-09 21:15:17 -07:00

AddCreditsNudgeEmailNotification.json

Option to Notify Workspace Owner When Usage Limit is Reached (#16969)

2026-04-09 21:15:17 -07:00

AgentMessageDeltaNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

AppListUpdatedNotification.json

add @plugin mentions (#13510)

2026-03-06 00:03:39 +00:00

AppsListParams.json

[apps] Add thread_id param to optionally load thread config for apps feature check. (#11279)

2026-02-09 23:10:26 -08:00

AppsListResponse.json

add @plugin mentions (#13510)

2026-03-06 00:03:39 +00:00

CancelLoginAccountParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

CancelLoginAccountResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

CommandExecOutputDeltaNotification.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecParams.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecResizeParams.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecResizeResponse.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecResponse.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecTerminateParams.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecTerminateResponse.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecutionOutputDeltaNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

CommandExecWriteParams.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

CommandExecWriteResponse.json

app-server: Add streaming and tty/pty capabilities to command/exec (#13640)

2026-03-06 17:30:17 -08:00

ConfigBatchWriteParams.json

[app-server] Support hot-reload user config when batch writing config. (#13839)

2026-03-08 17:38:01 -07:00

ConfigReadParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ConfigReadResponse.json

Add Smart Approvals guardian review across core, app-server, and TUI (#13860)

2026-03-13 15:27:00 -07:00

ConfigRequirementsReadResponse.json

[codex] Add danger-full-access denylist-only network mode (#16946)

2026-04-06 19:38:51 -07:00

ConfigValueWriteParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ConfigWarningNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ConfigWriteResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ContextCompactedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

DeprecationNoticeNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ErrorNotification.json

tui: queue follow-ups during manual /compact (#15259)

2026-03-23 10:19:44 -07:00

ExperimentalFeatureEnablementSetParams.json

[app-server] Add a method to override feature flags. (#15601)

2026-03-25 02:27:00 +00:00

ExperimentalFeatureEnablementSetResponse.json

[app-server] Add a method to override feature flags. (#15601)

2026-03-25 02:27:00 +00:00

ExperimentalFeatureListParams.json

[app-server] Add a method to list experimental features. (#10721)

2026-02-05 20:04:01 +00:00

ExperimentalFeatureListResponse.json

Add stage field for experimental flags. (#10793)

2026-02-05 23:31:04 +00:00

ExternalAgentConfigDetectParams.json

Support external agent config detect and import (#12660)

2026-02-25 02:11:51 -08:00

ExternalAgentConfigDetectResponse.json

Support external agent config detect and import (#12660)

2026-02-25 02:11:51 -08:00

ExternalAgentConfigImportParams.json

Support external agent config detect and import (#12660)

2026-02-25 02:11:51 -08:00

ExternalAgentConfigImportResponse.json

Support external agent config detect and import (#12660)

2026-02-25 02:11:51 -08:00

FeedbackUploadParams.json

Add ability to attach extra files to feedback (#12370)

2026-02-20 22:26:14 +00:00

FeedbackUploadResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

FileChangeOutputDeltaNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

FsChangedNotification.json

app-server: Move watch_id to request of fs/watch (#17026)

2026-04-07 11:22:28 -07:00

FsCopyParams.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsCopyResponse.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsCreateDirectoryParams.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsCreateDirectoryResponse.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsGetMetadataParams.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsGetMetadataResponse.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsReadDirectoryParams.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsReadDirectoryResponse.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsReadFileParams.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsReadFileResponse.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsRemoveParams.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsRemoveResponse.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsUnwatchParams.json

app-server: Move watch_id to request of fs/watch (#17026)

2026-04-07 11:22:28 -07:00

FsUnwatchResponse.json

app-server: add filesystem watch support (#14533)

2026-03-24 15:52:13 -07:00

FsWatchParams.json

app-server: Move watch_id to request of fs/watch (#17026)

2026-04-07 11:22:28 -07:00

FsWatchResponse.json

app-server: Move watch_id to request of fs/watch (#17026)

2026-04-07 11:22:28 -07:00

FsWriteFileParams.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

FsWriteFileResponse.json

app-server: add v2 filesystem APIs (#14245)

2026-03-13 14:42:20 -07:00

GetAccountParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

GetAccountRateLimitsResponse.json

Option to Notify Workspace Owner When Usage Limit is Reached (#16969)

2026-04-09 21:15:17 -07:00

GetAccountResponse.json

Option to Notify Workspace Owner When Usage Limit is Reached (#16969)

2026-04-09 21:15:17 -07:00

HookCompletedNotification.json

[hooks] add non-streaming (non-stdin style) shell-only PostToolUse support (#15531)

2026-03-25 19:18:03 -07:00

HookStartedNotification.json

[hooks] add non-streaming (non-stdin style) shell-only PostToolUse support (#15531)

2026-03-25 19:18:03 -07:00

ItemCompletedNotification.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ItemGuardianApprovalReviewCompletedNotification.json

fix(guardian, app-server): introduce guardian review ids (#17298)

2026-04-10 16:21:02 -07:00

ItemGuardianApprovalReviewStartedNotification.json

fix(guardian, app-server): introduce guardian review ids (#17298)

2026-04-10 16:21:02 -07:00

ItemStartedNotification.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ListMcpServerStatusParams.json

Speed up /mcp inventory listing (#16831)

2026-04-06 16:27:02 -07:00

ListMcpServerStatusResponse.json

feat: replace custom mcp-types crate with equivalents from rmcp (#10349)

2026-02-02 17:41:55 -08:00

LoginAccountParams.json

Add ChatGPT device-code login to app server (#15525)

2026-03-27 00:27:15 -07:00

LoginAccountResponse.json

Add ChatGPT device-code login to app server (#15525)

2026-03-27 00:27:15 -07:00

LogoutAccountResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

McpResourceReadParams.json

[mcp] Support MCP Apps part 1. (#16082)

2026-04-06 19:17:14 -07:00

McpResourceReadResponse.json

[mcp] Support MCP Apps part 1. (#16082)

2026-04-06 19:17:14 -07:00

McpServerOauthLoginCompletedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

McpServerOauthLoginParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

McpServerOauthLoginResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

McpServerRefreshResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

McpServerStatusUpdatedNotification.json

feat(app-server): add mcpServer/startupStatus/updated notification (#15220)

2026-03-19 15:09:59 -07:00

McpToolCallProgressNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ModelListParams.json

fix: send unfiltered models over model/list (#11793)

2026-02-13 16:26:32 -08:00

ModelListResponse.json

Use model metadata for Fast Mode status (#16949)

2026-04-07 17:55:40 -07:00

ModelReroutedNotification.json

Feat: add model reroute notification (#12001)

2026-02-17 11:02:23 -08:00

PlanDeltaNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

PluginInstallParams.json

feat: support remote_sync for plugin install/uninstall. (#14878)

2026-03-16 21:37:27 -07:00

PluginInstallResponse.json

feat: expose needs_auth for plugin/read. (#15217)

2026-03-19 15:02:45 -07:00

PluginListParams.json

feat: Allow sync with remote plugin status. (#14176)

2026-03-11 12:33:08 -07:00

PluginListResponse.json

feat: include marketplace loading error in plugin/list (#15438)

2026-03-24 11:47:23 -07:00

PluginReadParams.json

feat: add plugin/read. (#14445)

2026-03-12 16:52:21 -07:00

PluginReadResponse.json

feat: support disable skills by name. (#15378)

2026-03-23 12:57:40 -07:00

PluginUninstallParams.json

feat: support remote_sync for plugin install/uninstall. (#14878)

2026-03-16 21:37:27 -07:00

PluginUninstallResponse.json

chore: plugin/uninstall endpoint (#14111)

2026-03-09 12:40:25 -07:00

RawResponseItemCompletedNotification.json

Add notify to code-mode (#14842)

2026-03-18 09:37:13 -07:00

ReasoningSummaryPartAddedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ReasoningSummaryTextDeltaNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ReasoningTextDeltaNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ReviewStartParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ReviewStartResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ServerRequestResolvedNotification.json

app-server: Replay pending item requests on thread/resume (#12560)

2026-02-27 12:45:59 -08:00

SkillsChangedNotification.json

feat(app-server): add a skills/changed v2 notification (#13414)

2026-03-03 17:01:00 -08:00

SkillsConfigWriteParams.json

feat: support disable skills by name. (#15378)

2026-03-23 12:57:40 -07:00

SkillsConfigWriteResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

SkillsListParams.json

feat: extend skills/list to support additional roots. (#10835)

2026-02-09 13:30:38 -08:00

SkillsListResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

TerminalInteractionNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadAddCreditsNudgeEmailParams.json

Option to Notify Workspace Owner When Usage Limit is Reached (#16969)

2026-04-09 21:15:17 -07:00

ThreadAddCreditsNudgeEmailResponse.json

Option to Notify Workspace Owner When Usage Limit is Reached (#16969)

2026-04-09 21:15:17 -07:00

ThreadArchivedNotification.json

app-server: Emit thread archive/unarchive notifications (#12030)

2026-02-17 14:53:58 -08:00

ThreadArchiveParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadArchiveResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadClosedNotification.json

feat(app-server): thread/unsubscribe API (#10954)

2026-02-25 13:14:30 -08:00

ThreadCompactStartParams.json

Add thread/compact v2 (#10445)

2026-02-03 18:15:55 -08:00

ThreadCompactStartResponse.json

Add thread/compact v2 (#10445)

2026-02-03 18:15:55 -08:00

ThreadForkParams.json

Add Smart Approvals guardian review across core, app-server, and TUI (#13860)

2026-03-13 15:27:00 -07:00

ThreadForkResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadListParams.json

Revert "fix: harden plugin feature gating" (#15102)

2026-03-18 15:19:29 -07:00

ThreadListResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadLoadedListParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadLoadedListResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadMetadataUpdateParams.json

Add thread metadata update endpoint to app server (#13280)

2026-03-03 15:56:11 -08:00

ThreadMetadataUpdateResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadNameUpdatedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadReadParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadReadResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadRealtimeClosedNotification.json

Add app-server v2 thread realtime API (#12715)

2026-02-25 09:59:10 -08:00

ThreadRealtimeErrorNotification.json

Add app-server v2 thread realtime API (#12715)

2026-02-25 09:59:10 -08:00

ThreadRealtimeItemAddedNotification.json

Add app-server v2 thread realtime API (#12715)

2026-02-25 09:59:10 -08:00

ThreadRealtimeOutputAudioDeltaNotification.json

[stack 2/4] Align main realtime v2 wire and runtime flow (#14830)

2026-03-16 21:38:07 -07:00

ThreadRealtimeSdpNotification.json

Add WebRTC transport to realtime start (#16960)

2026-04-07 15:43:38 -07:00

ThreadRealtimeStartedNotification.json

Gate realtime audio interruption logic to v2 (#14984)

2026-03-17 15:24:37 -07:00

ThreadRealtimeTranscriptUpdatedNotification.json

Add realtime transcript notification in v2 (#15344)

2026-03-20 15:30:48 -07:00

ThreadResumeParams.json

Add notify to code-mode (#14842)

2026-03-18 09:37:13 -07:00

ThreadResumeResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadRollbackParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadRollbackResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadSetNameParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadSetNameResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadShellCommandParams.json

Add thread/shellCommand to app server API surface (#14988)

2026-03-18 23:42:40 -06:00

ThreadShellCommandResponse.json

Add thread/shellCommand to app server API surface (#14988)

2026-03-18 23:42:40 -06:00

ThreadStartedNotification.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadStartParams.json

Support clear SessionStart source (#17073)

2026-04-10 16:05:21 -07:00

ThreadStartResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadStatusChangedNotification.json

app-server: expose loaded thread status via read/list and notifications (#11786)

2026-02-18 15:20:03 -08:00

ThreadTokenUsageUpdatedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadUnarchivedNotification.json

app-server: Emit thread archive/unarchive notifications (#12030)

2026-02-17 14:53:58 -08:00

ThreadUnarchiveParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

ThreadUnarchiveResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

ThreadUnsubscribeParams.json

feat(app-server): thread/unsubscribe API (#10954)

2026-02-25 13:14:30 -08:00

ThreadUnsubscribeResponse.json

feat(app-server): thread/unsubscribe API (#10954)

2026-02-25 13:14:30 -08:00

TurnCompletedNotification.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

TurnDiffUpdatedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

TurnInterruptParams.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

TurnInterruptResponse.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

TurnPlanUpdatedNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00

TurnStartedNotification.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

TurnStartParams.json

Add Smart Approvals guardian review across core, app-server, and TUI (#13860)

2026-03-13 15:27:00 -07:00

TurnStartResponse.json

[mcp] Support MCP Apps part 2 - Add meta to mcp tool call result. (#16465)

2026-04-07 11:10:21 -07:00

TurnSteerParams.json

feat(app-server): turn/steer API (#10821)

2026-02-06 00:35:04 +00:00

TurnSteerResponse.json

feat(app-server): turn/steer API (#10821)

2026-02-06 00:35:04 +00:00

WindowsSandboxSetupCompletedNotification.json

app-server support for Windows sandbox setup. (#12025)

2026-02-18 13:03:16 -08:00

WindowsSandboxSetupStartParams.json

app-server: include experimental skill metadata in exec approval requests (#13929)

2026-03-08 18:07:46 -07:00

WindowsSandboxSetupStartResponse.json

app-server support for Windows sandbox setup. (#12025)

2026-02-18 13:03:16 -08:00

WindowsWorldWritableWarningNotification.json

feat: vendor app-server protocol schema fixtures (#10371)

2026-02-01 23:38:43 -08:00