Michael Bolin cfe50c7107 fix: creating an instance of Codex requires a Config (#859) ...

I discovered that I accidentally introduced a change in
https://github.com/openai/codex/pull/829 where we load a fresh `Config`
in the middle of `codex.rs`:


https://github.com/openai/codex/blob/c3e10e180a341e719f61014ea508f6d9dbffe05b/codex-rs/core/src/codex.rs#L515-L522

This is not good because the `Config` could differ from the one that has
the user's overrides specified from the CLI. Also, in unit tests, it
means the `Config` was picking up my personal settings as opposed to
using a vanilla config, which was problematic.

This PR cleans things up by moving the common case where
`Op::ConfigureSession` is derived from `Config` (originally done in
`codex_wrapper.rs`) and making it the standard way to initialize `Codex`
by putting it in `Codex::spawn()`. Note this also eliminates quite a bit
of boilerplate from the tests and relieves the caller of the
responsibility of minting out unique IDs when invoking `submit()`.

cfe50c7107 · 2025-05-07 16:33:28 -07:00

History

..

src

fix: creating an instance of Codex requires a Config (#859)

2025-05-07 16:33:28 -07:00

Cargo.toml

Update cargo to 2024 edition (#842)

2025-05-07 08:37:48 -07:00