codex

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Michael Bolin 9955eacd22 tui: fix approvals popup disabled shortcut test (#19072 )

## Why

This regressed in #19063, which made `GuardianApproval` stable and
enabled by default. That adds an enabled `Auto-review` row to the
permissions popup, but `approvals_popup_navigation_skips_disabled` still
assumed the disabled `Full Access` row lived behind a hard-coded numeric
shortcut, so the test started selecting a different row and closing the
popup instead of verifying disabled-row behavior.

## What

- disable `GuardianApproval` in
`approvals_popup_navigation_skips_disabled` so the popup layout matches
the scenario the test is exercising
- choose the hidden numeric shortcut for the disabled `Full Access` row
by platform (`2` on non-Windows, `3` on Windows where `Read Only` is
shown) before asserting that selecting the disabled row leaves the popup
open

## Testing

- `cargo test -p codex-tui --lib
chatwidget::tests::permissions::approvals_popup_navigation_skips_disabled
-- --exact --nocapture`
- `cargo test -p codex-tui --lib chatwidget::tests::permissions --
--nocapture`
- `cargo test -p codex-tui`

9955eacd22 · 2026-04-22 21:01:26 -07:00

History

frames

Rename tui_app_server to tui (#16104 )

2026-03-28 11:23:07 -06:00

src

tui: fix approvals popup disabled shortcut test (#19072 )

2026-04-22 21:01:26 -07:00

tests

Stabilize Bazel tests (timeout tweaks and flake fixes) (#17791 )

2026-04-16 07:57:51 -07:00

BUILD.bazel