pakrym-oai 9289b7cea8 [codex] Move hook request plumbing into hook runtime (#23388) ...

## Why

`run_turn` was still hand-building hook payloads and lifecycle events
for a couple of hook paths. Most hook call sites already delegate
request construction and event emission to `hook_runtime`, which keeps
turn orchestration focused on model-flow decisions rather than hook
plumbing.

This also keeps the legacy `after_agent` message extraction next to the
legacy hook dispatch instead of leaving response-item walking in
`run_turn`.

## What changed

- Added `run_stop_hooks` in `hook_runtime` to build `StopRequest`, emit
preview start events, run the hook, and emit completion events.
- Added `run_legacy_after_agent_hook` in `hook_runtime` to build and
dispatch the legacy `AfterAgent` hook payload, including extracting
input messages from response items.
- Updated `run_turn` to call the hook runtime helpers and keep only the
resulting continuation/block/stop decisions inline.
- Removed the repeated pending session-start hook check from the run
loop.

## Validation

- `cargo test -p codex-core hook_runtime`

9289b7cea8 · 2026-05-19 08:41:26 -07:00

History

..

agent

Preserve context baselines for full-history agent forks (#23352)

2026-05-19 10:34:24 +02:00

apps

Split DeveloperInstructions into individual fragments. (#18813)

2026-04-21 10:22:36 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

config

Add body_after_prefix auto-compact token limit scope (#22870)

2026-05-19 10:19:46 +00:00

context

context: remove legacy permissions instructions helper (#22790)

2026-05-15 10:11:16 -07:00

context_manager

[codex] Trim unused TurnContextItem fields (#22709)

2026-05-18 21:54:36 +00:00

guardian

Add body_after_prefix auto-compact token limit scope (#22870)

2026-05-19 10:19:46 +00:00

plugins

[codex] Remove string-keyed MCP tool maps (#21454)

2026-05-07 10:16:10 -07:00

sandboxing

permissions: derive legacy exec policies at boundaries (#19737)

2026-04-26 22:11:49 -07:00

session

[codex] Move hook request plumbing into hook runtime (#23388)

2026-05-19 08:41:26 -07:00

state

Add body_after_prefix auto-compact token limit scope (#22870)

2026-05-19 10:19:46 +00:00

tasks

[codex] Move pending input into input queue (#22728)

2026-05-18 15:43:01 -07:00

tools

Defer v1 multi-agent tools behind tool search (#23144)

2026-05-19 15:04:35 +02:00

unified_exec

Remove ToolsConfig from tool planning (#22835)

2026-05-19 11:24:09 +02:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

agents_md_tests.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

agents_md.rs

codex: route global AGENTS reads through LOCAL_FS (#23343)

2026-05-18 19:26:10 +00:00

apply_patch_tests.rs

[codex] Migrate apply_patch to executor filesystem (#17027)

2026-04-07 21:20:22 +00:00

apply_patch.rs

Support multi-environment apply_patch selection (#21617)

2026-05-11 16:33:44 -07:00

arc_monitor_tests.rs

Surface multi-environment choices in environment context (#20646)

2026-05-01 22:11:06 +00:00

arc_monitor.rs

[codex] Use compaction_trigger item for remote compaction v2 (#22809)

2026-05-15 11:40:35 +02:00

attestation.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client_common_tests.rs

[codex] Remove legacy shell output formatting paths (#22706)

2026-05-18 09:57:54 -07:00

client_common.rs

[codex] Remove legacy shell output formatting paths (#22706)

2026-05-18 09:57:54 -07:00

client_tests.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client.rs

Add body_after_prefix auto-compact token limit scope (#22870)

2026-05-19 10:19:46 +00:00

codex_delegate_tests.rs

Deprecate TurnContext cwd and resolve_path (#22519)

2026-05-13 11:15:25 -07:00

codex_delegate.rs

[1 of 7] Add thread settings to UserInput (#23080)

2026-05-18 18:48:35 -07:00

codex_thread.rs

[5 of 7] Replace OverrideTurnContext with ThreadSettings (#22508)

2026-05-18 21:03:51 -07:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

compact_remote_v2.rs

Remove explicit connector tool undeferral (#23390)

2026-05-18 21:33:46 -07:00

compact_remote.rs

Remove explicit connector tool undeferral (#23390)

2026-05-18 21:33:46 -07:00

compact_tests.rs

[codex] Filter legacy warning messages during compaction (#22243)

2026-05-11 19:51:51 -07:00

compact.rs

[codex] Remove external websocket session resets (#23384)

2026-05-19 01:13:38 +00:00

config_lock.rs

feat: add layered --profile-v2 config files (#17141)

2026-05-14 15:16:15 +02:00

connectors_tests.rs

Remove connector_openai prefix filtering (#22555)

2026-05-13 16:59:22 -07:00

connectors.rs

[elicitation] Advertise new url elicitation capability when auth_elicitation is enabled. (#22188)

2026-05-11 12:23:55 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

environment_selection.rs

Make environment provider snapshots path-free (#21794)

2026-05-08 15:30:00 -07:00

event_mapping_tests.rs

Preserve image detail in app-server inputs (#20693)

2026-05-15 15:04:04 -07:00

event_mapping.rs

Preserve image detail in app-server inputs (#20693)

2026-05-15 15:04:04 -07:00

exec_env_tests.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_env.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_policy_tests.rs

test: construct permission profiles directly (#23030)

2026-05-16 12:12:37 -07:00

exec_policy_windows_tests.rs

test: construct permission profiles directly (#23030)

2026-05-16 12:12:37 -07:00

exec_policy.rs

fix(exec-policy) use is_known_safe_command less (#20305)

2026-05-11 11:37:53 -07:00

exec_tests.rs

test: construct permission profiles directly (#23030)

2026-05-16 12:12:37 -07:00

exec.rs

feat(sandbox): add Windows deny-read parity (#18202)

2026-05-11 23:04:28 -07:00

function_tool.rs

feat: extract shared tool executor interface (#22359)

2026-05-13 11:31:27 +02:00

git_info_tests.rs

Fix remote turn diff display roots (#23261)

2026-05-18 10:53:49 -07:00

goals.rs

feat: dedicated goal DB (#23300)

2026-05-19 11:11:41 +02:00

hook_runtime.rs

[codex] Move hook request plumbing into hook runtime (#23388)

2026-05-19 08:41:26 -07:00

installation_id.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

landlock.rs

linux-sandbox: switch helper plumbing to PermissionProfile (#20106)

2026-04-28 19:43:44 -07:00

lib.rs

[1 of 7] Add thread settings to UserInput (#23080)

2026-05-18 18:48:35 -07:00

mcp_openai_file.rs

Deprecate TurnContext cwd and resolve_path (#22519)

2026-05-13 11:15:25 -07:00

mcp_skill_dependencies.rs

Support explicit MCP OAuth client IDs (#22575)

2026-05-14 11:52:43 -07:00

mcp_tool_approval_templates.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

mcp_tool_call_tests.rs

Include plugin id in plugin MCP tool metadata (#23353)

2026-05-18 15:33:33 -07:00

mcp_tool_call.rs

Include plugin id in plugin MCP tool metadata (#23353)

2026-05-18 15:33:33 -07:00

mcp_tool_exposure_test.rs

Remove ToolsConfig from tool planning (#22835)

2026-05-19 11:24:09 +02:00

mcp_tool_exposure.rs

Remove ToolsConfig from tool planning (#22835)

2026-05-19 11:24:09 +02:00

mcp.rs

feat: make built-in MCPs first-class runtime servers (#21356)

2026-05-07 10:36:32 +02:00

memory_usage.rs

Remove ToolsConfig from tool planning (#22835)

2026-05-19 11:24:09 +02:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

network_policy_decision_tests.rs

extract models manager and related ownership from core (#16508)

2026-04-02 23:00:02 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

network_proxy_loader_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

network_proxy_loader.rs

feat: add layered --profile-v2 config files (#17141)

2026-05-14 15:16:15 +02:00

original_image_detail.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

otel_init.rs

Add process-scoped SQLite telemetry (#22154)

2026-05-11 11:32:40 -07:00

personality_migration_tests.rs

Preserve image detail in app-server inputs (#20693)

2026-05-15 15:04:04 -07:00

personality_migration.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

prompt_debug.rs

Remove explicit connector tool undeferral (#23390)

2026-05-18 21:33:46 -07:00

realtime_context_tests.rs

[codex-analytics] rework thread_source for thread analytics (#20949)

2026-05-06 02:12:31 +00:00

realtime_context.rs

[codex] Route live thread writes through ThreadStore (#18882)

2026-04-23 10:17:09 -07:00

realtime_conversation_tests.rs

Update realtime handoff transcript handling (#18597)

2026-04-20 14:04:09 -07:00

realtime_conversation.rs

Make realtime sideband startup async (#20715)

2026-05-04 22:28:14 +00:00

realtime_prompt.rs

[codex] Update realtime V2 VAD silence delay and 1.5 prompt (#18092)

2026-04-16 14:30:57 -07:00

review_format.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

review_prompts.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

rollout.rs

codex: use ThreadStore history for core review forks (#20577)

2026-05-05 15:25:19 -07:00

safety_tests.rs

test: construct permission profiles directly (#23030)

2026-05-16 12:12:37 -07:00

safety.rs

Make turn diff tracking operation backed (#21180)

2026-05-07 11:33:47 +02:00

sandbox_tags_tests.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

sandbox_tags.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

session_prefix.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

session_rollout_init_error.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

session_startup_prewarm.rs

Remove explicit connector tool undeferral (#23390)

2026-05-18 21:33:46 -07:00

shell_detect.rs

chore: rename codex-command to codex-shell-command (#11378)

2026-02-10 17:03:46 -08:00

shell_snapshot_tests.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

shell_snapshot.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

shell_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

shell.rs

fix: add shell fallback paths for pwsh/powershell that work on GitHub Actions Windows runners (#16617)

2026-04-02 13:47:10 -07:00

skills.rs

cleanup: Remove skill env var dependency prompting (#22721)

2026-05-19 01:24:19 +00:00

spawn.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

state_db_bridge.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

stream_events_utils_tests.rs

Remove ToolsConfig from tool planning (#22835)

2026-05-19 11:24:09 +02:00

stream_events_utils.rs

[codex] Move pending input into input queue (#22728)

2026-05-18 15:43:01 -07:00

test_support.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

thread_manager_tests.rs

chore: isolate thread goal storage behind GoalStore (#23295)

2026-05-18 14:47:05 +02:00

thread_manager.rs

Make extension lifecycle hooks async (#23291)

2026-05-18 13:53:58 +02:00

thread_rollout_truncation_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

thread_rollout_truncation.rs

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

turn_diff_tracker_tests.rs

fix: preserve exact turn diffs after partial apply_patch failures (#21518)

2026-05-07 18:05:45 +02:00

turn_diff_tracker.rs

fix: preserve exact turn diffs after partial apply_patch failures (#21518)

2026-05-07 18:05:45 +02:00

turn_metadata_tests.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

turn_metadata.rs

Add user_input_requested_during_turn to MCP turn metadata (#22237)

2026-05-15 01:26:50 +00:00

turn_timing_tests.rs

Add turn start timestamp to turn metadata (#19473)

2026-04-28 16:36:59 +00:00

turn_timing.rs

[codex] Use compaction_trigger item for remote compaction v2 (#22809)

2026-05-15 11:40:35 +02:00

user_shell_command_tests.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

user_shell_command.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

util_tests.rs

Trim TUI legacy core helper usage (#22695)

2026-05-14 16:54:59 -07:00

util.rs

Trim TUI legacy core helper usage (#22695)

2026-05-14 16:54:59 -07:00

web_search.rs

…

windows_sandbox_read_grants_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_read_grants.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_tests.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00

windows_sandbox.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00