mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
Adam Perry @ OpenAI
281b416c44
## Why Python files under `scripts/` were not covered by the repository formatting recipe or the CI formatting job, so formatting drift could merge unnoticed. ## What - Add a dedicated `scripts/pyproject.toml` and `scripts/uv.lock` so root-script formatting uses a locked Ruff version. - Extend `just fmt` to format root Python scripts and add `fmt-scripts-check` for CI. - Run `just fmt-scripts-check` from `.github/workflows/ci.yml`, installing `uv` through SHA-pinned `astral-sh/setup-uv` while retaining the `uv` `0.11.3` pin. - Apply Ruff formatting to the root Python scripts, including `scripts/just-shell.py`, and extend `sdk/python/tests/test_artifact_workflow_and_binaries.py` to cover the root formatting recipe. - Update `AGENTS.md` so agents run `just fmt` after code changes anywhere in the repository. ## Validation - Extended the existing Python SDK workflow test to assert that `just fmt` includes root Python scripts.
73 lines
2.0 KiB
Python
73 lines
2.0 KiB
Python
#!/usr/bin/env python3
|
|
"""Cross-platform shell launcher for `just` recipes.
|
|
|
|
This keeps recipe bodies as normal shell snippets while giving the justfile one
|
|
portable placeholder, `{args}`, for forwarding variadic recipe arguments.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
|
|
|
|
ARGS_TOKEN = "{args}"
|
|
STDERR_NULL_TOKEN = "{stderr-null}"
|
|
POWERSHELL_ARGS = "@($args | Select-Object -Skip 1)"
|
|
POWERSHELL_STDERR_NULL = "2>$null; exit $LASTEXITCODE"
|
|
SH_ARGS = '"$@"'
|
|
SH_STDERR_NULL = "2>/dev/null"
|
|
|
|
|
|
def main() -> int:
|
|
if len(sys.argv) < 2:
|
|
print("just shell adapter expected a recipe command.", file=sys.stderr)
|
|
return 1
|
|
|
|
command = sys.argv[1]
|
|
recipe_name = sys.argv[2] if len(sys.argv) > 2 else ""
|
|
recipe_args = sys.argv[3:]
|
|
|
|
if os.name == "nt":
|
|
return run_powershell(command, recipe_name, recipe_args)
|
|
else:
|
|
return run_sh(command, recipe_name, recipe_args)
|
|
|
|
|
|
def run_sh(command: str, recipe_name: str, recipe_args: list[str]) -> int:
|
|
command = command.replace(ARGS_TOKEN, SH_ARGS)
|
|
command = command.replace(STDERR_NULL_TOKEN, SH_STDERR_NULL)
|
|
os.execvp("sh", ["sh", "-cu", command, recipe_name, *recipe_args])
|
|
|
|
|
|
def run_powershell(command: str, recipe_name: str, recipe_args: list[str]) -> int:
|
|
pwsh = shutil.which("pwsh.exe") or shutil.which("pwsh")
|
|
if pwsh is None:
|
|
print(
|
|
"PowerShell ('pwsh') is required for Windows just recipes. "
|
|
"Run 'just install' to install it.",
|
|
file=sys.stderr,
|
|
)
|
|
return 1
|
|
|
|
command = command.replace(ARGS_TOKEN, POWERSHELL_ARGS)
|
|
command = command.replace(STDERR_NULL_TOKEN, POWERSHELL_STDERR_NULL)
|
|
return subprocess.run(
|
|
[
|
|
pwsh,
|
|
"-NoLogo",
|
|
"-NoProfile",
|
|
"-CommandWithArgs",
|
|
command,
|
|
recipe_name,
|
|
*recipe_args,
|
|
],
|
|
check=False,
|
|
).returncode
|
|
|
|
|
|
if __name__ == "__main__":
|
|
raise SystemExit(main())
|