kbazzi 92d2e1df70 Retry failed Codex Apps MCP startup (#29920) ...

## Problem

The built-in Codex Apps MCP client shares a future for the full startup
operation: connect, complete `initialize`, fetch the initial tools, and
return a usable client. Sharing deduplicates startup work, but it also
memoizes terminal errors.

After a transient connection, handshake, or initial `tools/list`
failure, later tool builds observe the same failed future. The thread
cannot reconnect after the backend recovers and continues serving its
startup-time cached tool snapshot, which may be empty or stale.

## Fix

When Apps MCP startup ends in an error, Codex starts bounded recovery
without putting startup latency on tool-router construction:

1. The current tool build immediately continues with the cached startup
snapshot.
2. After the initial failure is reported, Codex starts one fresh full
startup attempt in the background.
3. Concurrent tool builds share that in-flight attempt and also continue
with cached tools.
4. On success, the recovered client becomes active, refreshes the Apps
tools cache, emits a `Ready` startup status, and is reused by later
operations.
5. On failure, the cache remains unchanged and later tool builds may
start another background attempt after exponential cooldown: 1s, 2s, 4s,
8s, 16s, then 30s maximum.

Each recreated startup performs a fresh MCP `initialize` and uncached
`tools/list`. The MCP client retains its existing bounded retries for
retryable `initialize` and `tools/list` failures.

This avoids adding the Apps startup timeout to every request during a
sustained outage.

## Scope

This is limited to the built-in Codex Apps MCP client:

- no reconnects for user-configured MCP servers;
- no cache deletion; and
- no proactive refresh for a healthy client with stale tools.

## Tests

Coverage verifies:

- tool builds return cached tools without waiting for a blocked
reconnect;
- concurrent tool builds start only one background reconnect;
- failed reconnects preserve cached tools and respect exponential
cooldown;
- a recovered client is retained and reused; and
- a long-lived thread exposes recovered app tools on a later follow-up.

Validation:

- `just test -p codex-mcp` — 95 passed
- `just test -p codex-core
later_follow_up_uses_background_recovered_apps_after_mid_thread_startup_failures
--no-capture` — passed
- `just fix -p codex-mcp`
- `just fmt`

92d2e1df70 · 2026-06-25 21:31:12 -07:00

History

..

apps_test_server.rs

Retry failed Codex Apps MCP startup (#29920)

2026-06-25 21:31:12 -07:00

BUILD.bazel

Remove CODEX_RS_SSE_FIXTURE test hook (#22413)

2026-05-13 03:08:01 +00:00

Cargo.toml

[codex] Load user instructions through an injected provider (#27101)

2026-06-11 19:28:47 +00:00

context_snapshot.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

hooks.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

lib.rs

test: branch on target OS instead of runner flavor (#29712)

2026-06-23 14:27:13 -07:00

process.rs

feat: close unified_exec at end of turn (#8052)

2025-12-16 12:16:43 +00:00

responses.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

streaming_sse.rs

Update models.json (#18586)

2026-04-20 10:27:01 -07:00

test_codex_exec.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

test_codex.rs

feat: add provider-aware model fallback to thread start (#29942)

2026-06-25 18:24:34 +00:00

test_environment_tests.rs

test: branch on target OS instead of runner flavor (#29712)

2026-06-23 14:27:13 -07:00

test_environment.rs

test: branch on target OS instead of runner flavor (#29712)

2026-06-23 14:27:13 -07:00

tracing.rs

feat(core, tracing): create turn spans over websockets (#14632)

2026-03-19 03:41:06 +00:00

zsh_fork.rs

core: expose permission profile to shell tools (#29941)

2026-06-25 19:00:23 +00:00