Michael Bolin 1c6a3f1097 fix: artifacts from previous frames were bleeding through in TUI (#989) ...

Prior to this PR, I would frequently see glyphs from previous frames
"bleed" through like this:


![image](https://github.com/user-attachments/assets/8784b3d7-f691-4df6-8666-34e2f134ee85)

I think this was due to two issues (now addressed in this PR):

* We were not making use of `ratatui::widgets::Clear` to clear out the
buffer before drawing into it.
* To calculate the `width` used with `wrapped_line_count_for_cell()`, we
were not accounting for the scrollbar.
* Now we calculate `effective_width` using
`inner.width.saturating_sub(1)` where the `1` is for the scrollbar.
* We compute `text_area` using `effective_with` and pass the `text_area`
to `paragraph.render()`.
* We eliminate the conditional `needs_scrollbar` check and always call
`render(Scrollbar)`

I suspect this bug was introduced in
https://github.com/openai/codex/pull/937, though I did not try to
verify: I'm just happy that it appears to be fixed!

1c6a3f1097 · 2025-05-17 10:51:11 -07:00

History

..

src

fix: artifacts from previous frames were bleeding through in TUI (#989)

2025-05-17 10:51:11 -07:00

tests

feat: initial import of Rust implementation of Codex CLI in codex-rs/ (#629)

2025-04-24 13:31:40 -07:00

Cargo.toml

feat: add support for file_opener option in Rust, similiar to #911 (#957)

2025-05-16 11:33:08 -07:00