Eric Traut 13468115fc Guard core test subprocess cleanup (#27343) ...

## Why

Local integration-heavy `codex-core` CLI tests can time out or be
interrupted after spawning `codex exec`. Stopping only the direct child
is not enough: `codex exec` can leave grandchildren behind, including
`python3`/`python3.12` processes that get reparented to PID 1 and keep
running after the test is gone.

This PR fixes that failure mode directly for the affected CLI
integration tests, without changing production code or reducing local
test concurrency.

## What

- Run the `cli_stream` `codex exec` subprocesses through a small private
wrapper in `core/tests/suite/cli_stream.rs`.
- Spawn those subprocesses in their own process group before execution.
- Keep `.output()`-style stdout/stderr capture and the existing
30-second timeout behavior.
- Own each spawned process with a drop guard that kills the whole
process group on success, timeout, panic, or other early return.

The switch from `assert_cmd::Command` to `std::process::Command` is only
for these subprocess launches; `assert_cmd` does not expose a pre-spawn
hook for setting the process group.

## Verification

- `just test -p codex-core --test all responses_mode_stream_cli`

This is limited to core integration tests; it does not change production
`src` code paths.

13468115fc · 2026-06-10 12:19:26 -07:00

History

..

common

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

suite

Guard core test subprocess cleanup (#27343)

2026-06-10 12:19:26 -07:00

all.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

responses_headers.rs

[codex] Store compact window id in rollout (#27264)

2026-06-10 08:47:16 -07:00