mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Michael Bolin 1cfc967eb8 fix: Features should be immutable over the lifetime of a session/thread (#7540 )

I noticed that `features: Features` was defined on `struct
SessionConfiguration`, which is commonly owned by `SessionState`, which
is in turn owned by `Session`.

Though I do not believe that `Features` should be allowed to be modified
over the course of a session (if the feature state is not invariant, it
makes it harder to reason about), which argues that it should live on
`Session` rather than `SessionState` or `SessionConfiguration`.

This PR moves `Features` to `Session` and updates all call sites. It
appears the only place we were mutating `Features` was:

- in tests
- the sub-agent config for a review task:


https://github.com/openai/codex/blob/3ef76ff29d5eed258fb6b8550e0e2b973d0dca21/codex-rs/core/src/tasks/review.rs#L86-L89

Note this change also means it is no longer an `async` call to check the
state of a feature, eliminating the possibility of a
[TOCTTOU](https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use)
error between checking the state of a feature and acting on it:


https://github.com/openai/codex/blob/3ef76ff29d5eed258fb6b8550e0e2b973d0dca21/codex-rs/core/src/codex.rs#L1069-L1076

1cfc967eb8 · 2025-12-03 16:12:31 -08:00

History

src

fix: Features should be immutable over the lifetime of a session/thread (#7540 )

2025-12-03 16:12:31 -08:00

templates

fix: parallel tool call instruction injection (#6893 )

2025-11-19 11:01:57 +00:00

tests

Migrate model preset (#7542 )

2025-12-03 20:30:43 +00:00

Cargo.toml

feat: experimental support for skills.md (#7412 )

2025-12-01 20:22:35 -08:00

gpt_5_1_prompt.md

chore(core) Update shell instructions (#6679 )

2025-11-17 13:05:15 -08:00

gpt_5_codex_prompt.md

chore(core) Update shell instructions (#6679 )

2025-11-17 13:05:15 -08:00

gpt-5.1-codex-max_prompt.md

feat: arcticfox in the wild (#6906 )

2025-11-19 16:31:06 +00:00

prompt.md

Add file reference guidelines to gpt-5 prompt (#3651 )

2025-09-15 08:35:30 -07:00

README.md

docs: align sandbox defaults, dedupe sections and improve getting started guide (#5357 )

2025-10-19 16:41:10 -07:00

review_prompt.md

docs: Fix markdown list item spacing in codex-rs/core/review_prompt.md (#4144 )

2025-10-30 17:39:21 -07:00

README.md

codex-core

This crate implements the business logic for Codex. It is designed to be used by the various Codex UIs written in Rust.

Dependencies

Note that codex-core makes some assumptions about certain helper utilities being available in the environment. Currently, this support matrix is:

macOS

Expects /usr/bin/sandbox-exec to be present.

Linux

Expects the binary containing codex-core to run the equivalent of codex sandbox linux (legacy alias: codex debug landlock) when arg0 is codex-linux-sandbox. See the codex-arg0 crate for details.

All Platforms

Expects the binary containing codex-core to simulate the virtual apply_patch CLI when arg1 is --codex-run-as-apply-patch. See the codex-arg0 crate for details.