Michael Bolin 862158b9e9 app-server: make thread/shellCommand tests shell-aware (#16635) ...

## Why
`thread/shellCommand` executes the raw command string through the
current user shell, which is PowerShell on Windows. The two v2
app-server tests in `app-server/tests/suite/v2/thread_shell_command.rs`
used POSIX `printf`, so Bazel CI on Windows failed with `printf` not
being recognized as a PowerShell command.

For reference, the user-shell task wraps commands with the active shell
before execution:
[`core/src/tasks/user_shell.rs`](https://github.com/openai/codex/blob/7a3eec6fdb356bd71f80582119eb829179ff0da1/codex-rs/core/src/tasks/user_shell.rs#L120-L126).

## What Changed
Added a test-local helper that builds a shell-appropriate output command
and expected newline sequence from `default_user_shell()`:

- PowerShell: `Write-Output '...'` with `\r\n`
- Cmd: `echo ...` with `\r\n`
- POSIX shells: `printf '%s\n' ...` with `\n`

Both `thread_shell_command_runs_as_standalone_turn_and_persists_history`
and `thread_shell_command_uses_existing_active_turn` now use that
helper.

## Verification
- `cargo test -p codex-app-server thread_shell_command`

862158b9e9 · 2026-04-02 17:28:47 -07:00

History

..

common

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

suite

app-server: make thread/shellCommand tests shell-aware (#16635)

2026-04-02 17:28:47 -07:00

all.rs

fix: separate codex mcp into codex mcp-server and codex app-server (#4471)

2025-09-30 07:06:18 +00:00