mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
Eric Traut
096e5e76a2
## Summary Choosing “Don’t remind me” can silently fail when `version.json` disappears before dismissal because `dismiss_version` returns success without writing anything. The same update can then reappear on the next launch. Initialize a minimal `VersionInfo` from the selected version when the cache cannot be read, then persist the dismissal through the existing write path. Fixes #27147
53 lines
1.7 KiB
Rust
53 lines
1.7 KiB
Rust
use crate::legacy_core::config::Config;
|
|
use chrono::DateTime;
|
|
use chrono::Utc;
|
|
use serde::Deserialize;
|
|
use serde::Serialize;
|
|
use std::path::Path;
|
|
use std::path::PathBuf;
|
|
|
|
#[derive(Serialize, Deserialize, Debug, Clone)]
|
|
pub(crate) struct VersionInfo {
|
|
pub(crate) latest_version: String,
|
|
// ISO-8601 timestamp (RFC3339)
|
|
pub(crate) last_checked_at: DateTime<Utc>,
|
|
#[serde(default)]
|
|
pub(crate) dismissed_version: Option<String>,
|
|
}
|
|
|
|
const VERSION_FILENAME: &str = "version.json";
|
|
|
|
pub(crate) fn version_filepath(config: &Config) -> PathBuf {
|
|
config.codex_home.join(VERSION_FILENAME).into_path_buf()
|
|
}
|
|
|
|
pub(crate) fn read_version_info(version_file: &Path) -> anyhow::Result<VersionInfo> {
|
|
let contents = std::fs::read_to_string(version_file)?;
|
|
Ok(serde_json::from_str(&contents)?)
|
|
}
|
|
|
|
/// Persist a dismissal for the current latest version so we don't show
|
|
/// the update popup again for this version.
|
|
pub(crate) async fn dismiss_version(config: &Config, version: &str) -> anyhow::Result<()> {
|
|
let version_file = version_filepath(config);
|
|
let mut info = match read_version_info(&version_file) {
|
|
Ok(info) => info,
|
|
Err(_) => VersionInfo {
|
|
latest_version: version.to_string(),
|
|
last_checked_at: DateTime::<Utc>::UNIX_EPOCH,
|
|
dismissed_version: None,
|
|
},
|
|
};
|
|
info.dismissed_version = Some(version.to_string());
|
|
let json_line = format!("{}\n", serde_json::to_string(&info)?);
|
|
if let Some(parent) = version_file.parent() {
|
|
tokio::fs::create_dir_all(parent).await?;
|
|
}
|
|
tokio::fs::write(version_file, json_line).await?;
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
#[path = "updates_cache_tests.rs"]
|
|
mod tests;
|