codex

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Michael Bolin 9009490357 fix: use PowerShell to parse PowerShell (#7607 )

Previous to this PR, we used a hand-rolled PowerShell parser in
`windows_safe_commands.rs` to take a `&str` of PowerShell script see if
it is equivalent to a list of `execvp(3)` invocations, and if so, we
then test each using `is_safe_powershell_command()` to determine if the
overall command is safe:


https://github.com/openai/codex/blob/6e6338aa876bb4258abe25b02ac6417b8ea9dff0/codex-rs/core/src/command_safety/windows_safe_commands.rs#L89-L98

Unfortunately, our PowerShell parser did not recognize `@(...)` as a
special construct, so it was treated as an ordinary token. This meant
that the following would erroneously be considered "safe:"

```powershell
ls @(calc.exe)
```

The fix introduced in this PR is to do something comparable what we do
for Bash/Zsh, which is to use a "proper" parser to derive the list of
`execvp(3)` calls. For Bash/Zsh, we rely on
https://crates.io/crates/tree-sitter-bash, but there does not appear to
be a crate of comparable quality for parsing PowerShell statically
(https://github.com/airbus-cert/tree-sitter-powershell/ is the best
thing I found).

Instead, in this PR, we use a PowerShell script to parse the input
PowerShell program to produce the AST.

9009490357 · 2025-12-12 13:06:49 -08:00

History

is_dangerous_command.rs

Windows: flag some invocations that launch browsers/URLs as dangerous (#7111 )

2025-11-21 13:36:17 -08:00

is_safe_command.rs

feat: more safe commands (#7728 )

2025-12-12 11:48:25 +01:00

mod.rs

Revert "Revert "Overhaul shell detection and centralize command generation for unified exec"" (#6607 )

2025-11-13 16:45:17 -08:00

powershell_parser.ps1