rhan-oai bb536d65bd [codex-analytics] prevent stale guardian events from satisfying reused reviews (#20080) ...

## Why

Reused Guardian review trunks can still have older child-turn events
queued when a later review starts. The review waiter currently accepts
the first terminal event it sees from the shared child session, so a
stale `TurnComplete` can be attributed to the new review. That produces
impossible analytics combinations such as non-null TTFT with sub-10 ms
completion latency and zero token deltas on `trunk_reused` reviews.

## What changed

- Preserve the child turn id returned by the Guardian review
`Op::UserTurn` submission.
- Restrict Guardian review waiting to events correlated with that
submitted child turn.
- Restrict timeout/abort draining to terminal events for the same child
turn.
- Add regression coverage for stale prior-turn completions, stale
prior-turn errors, and interrupt draining in
`codex-rs/core/src/guardian/review_session.rs`.

## Verification

- `cargo test -p codex-core guardian::review_session::tests::`
- `cargo clippy -p codex-core --tests -- -D warnings`

bb536d65bd · 2026-04-29 18:26:39 -07:00

History

..

agent

Add ThreadManager sample crate (#20141)

2026-04-29 11:21:06 -07:00

apps

Split DeveloperInstructions into individual fragments. (#18813)

2026-04-21 10:22:36 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

config

[mcp] Fix plugin MCP approval policy. (#19537)

2026-04-29 15:40:03 -07:00

context

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

context_manager

Remove ghost snapshots (#19481)

2026-04-27 18:48:57 -07:00

guardian

[codex-analytics] prevent stale guardian events from satisfying reused reviews (#20080)

2026-04-29 18:26:39 -07:00

plugins

Add hooks/list app-server RPC (#19778)

2026-04-29 23:39:57 +00:00

sandboxing

permissions: derive legacy exec policies at boundaries (#19737)

2026-04-26 22:11:49 -07:00

session

fix: handle deferred network proxy denials (#19184)

2026-04-29 19:13:57 +00:00

state

[codex] Add token usage to turn tracing spans (#19432)

2026-04-28 11:41:32 -07:00

tasks

[codex] Add token usage to turn tracing spans (#19432)

2026-04-28 11:41:32 -07:00

tools

Reduce the surface of collaboration modes (#20149)

2026-04-29 17:22:41 -07:00

unified_exec

fix: handle deferred network proxy denials (#19184)

2026-04-29 19:13:57 +00:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

agents_md_tests.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

agents_md.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

apply_patch_tests.rs

[codex] Migrate apply_patch to executor filesystem (#17027)

2026-04-07 21:20:22 +00:00

apply_patch.rs

permissions: migrate approval and sandbox consumers to profiles (#19393)

2026-04-26 15:30:40 -07:00

arc_monitor_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

arc_monitor.rs

Remove ghost snapshots (#19481)

2026-04-27 18:48:57 -07:00

client_common_tests.rs

Allow guardian bare allow output (#18797)

2026-04-21 15:37:12 -07:00

client_common.rs

[codex] Trace cancelled inference streams (#19839)

2026-04-27 21:58:29 +00:00

client_tests.rs

[rollout-trace] Include x-request-id in rollout trace. (#20066)

2026-04-28 21:11:17 +00:00

client.rs

[rollout-trace] Include x-request-id in rollout trace. (#20066)

2026-04-28 21:11:17 +00:00

codex_delegate_tests.rs

Fix /review interrupt and TUI exit wedges (#18921)

2026-04-23 13:28:12 -07:00

codex_delegate.rs

[codex-analytics] remove ga flag (#19863)

2026-04-27 19:29:19 +00:00

codex_thread.rs

Include auto-review rollout in feedback uploads (#20064)

2026-04-29 11:44:55 -07:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

commit_attribution_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

commit_attribution.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

compact_remote.rs

Remove ghost snapshots (#19481)

2026-04-27 18:48:57 -07:00

compact_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

compact.rs

Remove ghost snapshots (#19481)

2026-04-27 18:48:57 -07:00

connectors_tests.rs

Support disabling tool suggest for specific tools. (#20072)

2026-04-29 00:19:34 +00:00

connectors.rs

Add environment provider snapshot (#20058)

2026-04-28 20:05:18 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

environment_selection.rs

Add environment provider snapshot (#20058)

2026-04-28 20:05:18 -07:00

event_mapping_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

event_mapping.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

exec_env_tests.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_env.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_policy_tests.rs

permissions: derive config defaults as profiles (#19772)

2026-04-27 16:50:10 -07:00

exec_policy.rs

permissions: remove core legacy policy round trips (#19394)

2026-04-26 17:43:32 -07:00

exec_tests.rs

fix: handle deferred network proxy denials (#19184)

2026-04-29 19:13:57 +00:00

exec.rs

fix: handle deferred network proxy denials (#19184)

2026-04-29 19:13:57 +00:00

file_watcher_tests.rs

fix: FS watcher when file does not exist yet (#18492)

2026-04-20 11:23:00 +01:00

file_watcher.rs

fix: FS watcher when file does not exist yet (#18492)

2026-04-20 11:23:00 +01:00

flags.rs

chore: drop unused values from env_flags (#4188)

2025-09-24 14:29:51 -07:00

function_tool.rs

nit: drop unused function call error (#8903)

2026-01-08 15:07:30 +00:00

git_info_tests.rs

Refactor config loading to use filesystem abstraction (#18209)

2026-04-17 00:51:21 +00:00

goals.rs

Preserve assistant phase for replayed messages (#19832)

2026-04-28 08:46:13 -07:00

hook_runtime.rs

Discover hooks bundled with plugins (#19705)

2026-04-28 14:17:18 -07:00

installation_id.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

landlock.rs

linux-sandbox: switch helper plumbing to PermissionProfile (#20106)

2026-04-28 19:43:44 -07:00

lib.rs

Add codex-core public API listing (#20243)

2026-04-29 22:58:08 +00:00

mcp_openai_file.rs

refactor: route Codex auth through AuthProvider (#18811)

2026-04-23 17:14:02 -07:00

mcp_skill_dependencies.rs

permissions: derive compatibility policies from profiles (#19392)

2026-04-26 15:06:42 -07:00

mcp_tool_approval_templates.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

mcp_tool_call_tests.rs

[mcp] Fix plugin MCP approval policy. (#19537)

2026-04-29 15:40:03 -07:00

mcp_tool_call.rs

[mcp] Fix plugin MCP approval policy. (#19537)

2026-04-29 15:40:03 -07:00

mcp_tool_exposure_test.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

mcp_tool_exposure.rs

add token-based tool deferral behind feature flag (#18097)

2026-04-17 18:34:06 +08:00

mcp.rs

fix: fully revert agent identity runtime wiring (#18757)

2026-04-21 14:30:55 -07:00

memory_usage.rs

chore: split memories part 1 (#19818)

2026-04-27 16:01:05 +02:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

message_history_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

message_history.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

network_policy_decision_tests.rs

extract models manager and related ownership from core (#16508)

2026-04-02 23:00:02 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

network_proxy_loader_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

network_proxy_loader.rs

inline hostname resolution for remote sandbox config (#19739)

2026-04-27 03:18:57 +00:00

original_image_detail.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

otel_init.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

personality_migration_tests.rs

[codex] Add local thread store listing (#17824)

2026-04-15 11:34:27 -07:00

personality_migration.rs

Support multiple cwd filters for thread list (#18502)

2026-04-22 06:10:09 -04:00

prompt_debug.rs

Reduce the surface of collaboration modes (#20149)

2026-04-29 17:22:41 -07:00

realtime_context_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

realtime_context.rs

[codex] Route live thread writes through ThreadStore (#18882)

2026-04-23 10:17:09 -07:00

realtime_conversation_tests.rs

Update realtime handoff transcript handling (#18597)

2026-04-20 14:04:09 -07:00

realtime_conversation.rs

Add realtime silence tool (#18635)

2026-04-20 15:43:20 -07:00

realtime_prompt.rs

[codex] Update realtime V2 VAD silence delay and 1.5 prompt (#18092)

2026-04-16 14:30:57 -07:00

review_format.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

review_prompts.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

rollout.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

safety_tests.rs

permissions: remove cwd special path (#19841)

2026-04-27 13:41:27 -07:00

safety.rs

permissions: migrate approval and sandbox consumers to profiles (#19393)

2026-04-26 15:30:40 -07:00

sandbox_tags_tests.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

sandbox_tags.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

session_prefix.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

session_rollout_init_error.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

session_startup_prewarm.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

shell_detect.rs

chore: rename codex-command to codex-shell-command (#11378)

2026-02-10 17:03:46 -08:00

shell_snapshot_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

shell_snapshot.rs

Avoid false shell snapshot cleanup warnings (#18441)

2026-04-20 15:15:05 +01:00

shell_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

shell.rs

fix: add shell fallback paths for pwsh/powershell that work on GitHub Actions Windows runners (#16617)

2026-04-02 13:47:10 -07:00

skills_watcher.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

skills.rs

Split DeveloperInstructions into individual fragments. (#18813)

2026-04-21 10:22:36 -07:00

spawn.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

state_db_bridge.rs

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

stream_events_utils_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

stream_events_utils.rs

chore: split memories part 1 (#19818)

2026-04-27 16:01:05 +02:00

test_support.rs

Reduce the surface of collaboration modes (#20149)

2026-04-29 17:22:41 -07:00

thread_manager_tests.rs

Reduce the surface of collaboration modes (#20149)

2026-04-29 17:22:41 -07:00

thread_manager.rs

Reduce the surface of collaboration modes (#20149)

2026-04-29 17:22:41 -07:00

thread_rollout_truncation_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

thread_rollout_truncation.rs

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

turn_diff_tracker_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_diff_tracker.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

turn_metadata_tests.rs

Escape turn metadata headers as ASCII JSON (#19620)

2026-04-29 15:35:33 -07:00

turn_metadata.rs

Escape turn metadata headers as ASCII JSON (#19620)

2026-04-29 15:35:33 -07:00

turn_timing_tests.rs

Add turn start timestamp to turn metadata (#19473)

2026-04-28 16:36:59 +00:00

turn_timing.rs

Add turn start timestamp to turn metadata (#19473)

2026-04-28 16:36:59 +00:00

unavailable_tool.rs

[mcp] Add dummy tools for previously called but currently missing tools. (#17853)

2026-04-15 21:48:05 +00:00

user_shell_command_tests.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

user_shell_command.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

util_tests.rs

Update models.json (#18586)

2026-04-20 10:27:01 -07:00

util.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

web_search.rs

add missing fields to WebSearchAction and update app-server types (#10276)

2026-01-30 16:37:56 -08:00

windows_sandbox_read_grants_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_read_grants.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_tests.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00

windows_sandbox.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00