mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Michael Bolin 46baedd7cb fix: change codex/sandbox-state/update from a notification to a request (#8142 )

Historically, `accept_elicitation_for_prompt_rule()` was flaky because
we were using a notification to update the sandbox followed by a `shell`
tool request that we expected to be subject to the new sandbox config,
but because [rmcp](https://crates.io/crates/rmcp) MCP servers delegate
each incoming message to a new Tokio task, messages are not guaranteed
to be processed in order, so sometimes the `shell` tool call would run
before the notification was processed.

Prior to this PR, we relied on a generous `sleep()` between the
notification and the request to reduce the change of the test flaking
out.

This PR implements a proper fix, which is to use a _request_ instead of
a notification for the sandbox update so that we can wait for the
response to the sandbox request before sending the request to the
`shell` tool call. Previously, `rmcp` did not support custom requests,
but I fixed that in
https://github.com/modelcontextprotocol/rust-sdk/pull/590, which made it
into the `0.12.0` release (see #8288).

This PR updates `shell-tool-mcp` to expect
`"codex/sandbox-state/update"` as a _request_ instead of a notification
and sends the appropriate ack. Note this behavior is tied to our custom
`codex/sandbox-state` capability, which Codex honors as an MCP client,
which is why `core/src/mcp_connection_manager.rs` had to be updated as
part of this PR, as well.

This PR also updates the docs at `shell-tool-mcp/README.md`.

46baedd7cb · 2025-12-18 15:32:01 -08:00

History

src

fix: change codex/sandbox-state/update from a notification to a request (#8142 )

2025-12-18 15:32:01 -08:00

templates

Removed experimental "command risk assessment" feature (#7799 )

2025-12-10 09:48:11 -08:00

tests

fix: flaky tests 5 (#8282 )

2025-12-18 21:08:43 +00:00

Cargo.toml

Support SYSTEM skills. (#8220 )

2025-12-17 18:48:28 -08:00

gpt_5_1_prompt.md

chore(prompt) Remove truncation details (#7941 )

2025-12-12 20:21:53 +00:00

gpt_5_2_prompt.md

chore(prompt) Remove truncation details (#7941 )

2025-12-12 20:21:53 +00:00

gpt_5_codex_prompt.md

refactoring with_escalated_permissions to use SandboxPermissions instead (#7750 )

2025-12-10 17:18:48 +00:00

gpt-5.1-codex-max_prompt.md

refactoring with_escalated_permissions to use SandboxPermissions instead (#7750 )

2025-12-10 17:18:48 +00:00

gpt-5.2-codex_prompt.md

caribou (#8265 )

2025-12-18 08:58:44 -08:00

models.json

Load models from static file (#8153 )

2025-12-17 14:34:13 -08:00

prompt.md

chore(prompt) Update base prompt (#7943 )

2025-12-12 20:50:49 +00:00

README.md

docs: align sandbox defaults, dedupe sections and improve getting started guide (#5357 )

2025-10-19 16:41:10 -07:00

review_prompt.md

docs: Fix markdown list item spacing in codex-rs/core/review_prompt.md (#4144 )

2025-10-30 17:39:21 -07:00

README.md

codex-core

This crate implements the business logic for Codex. It is designed to be used by the various Codex UIs written in Rust.

Dependencies

Note that codex-core makes some assumptions about certain helper utilities being available in the environment. Currently, this support matrix is:

macOS

Expects /usr/bin/sandbox-exec to be present.

Linux

Expects the binary containing codex-core to run the equivalent of codex sandbox linux (legacy alias: codex debug landlock) when arg0 is codex-linux-sandbox. See the codex-arg0 crate for details.

All Platforms

Expects the binary containing codex-core to simulate the virtual apply_patch CLI when arg1 is --codex-run-as-apply-patch. See the codex-arg0 crate for details.