mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Michael Bolin 9a8730f31e ci: verify codex-rs Cargo manifests inherit workspace settings (#16353 )

## Why

Bazel clippy now catches lints that `cargo clippy` can still miss when a
crate under `codex-rs` forgets to opt into workspace lints. The concrete
example here was `codex-rs/app-server/tests/common/Cargo.toml`: Bazel
flagged a clippy violation in `models_cache.rs`, but Cargo did not
because that crate inherited workspace package metadata without
declaring `[lints] workspace = true`.

We already mirror the workspace clippy deny list into Bazel after
[#15955](https://github.com/openai/codex/pull/15955), so we also need a
repo-side check that keeps every `codex-rs` manifest opted into the same
workspace settings.

## What changed

- add `.github/scripts/verify_cargo_workspace_manifests.py`, which
parses every `codex-rs/**/Cargo.toml` with `tomllib` and verifies:
  - `version.workspace = true`
  - `edition.workspace = true`
  - `license.workspace = true`
  - `[lints] workspace = true`
- top-level crate names follow the `codex-*` / `codex-utils-*`
conventions, with explicit exceptions for `windows-sandbox-rs` and
`utils/path-utils`
- run that script in `.github/workflows/ci.yml`
- update the current outlier manifests so the check is enforceable
immediately
- fix the newly exposed clippy violations in the affected crates
(`app-server/tests/common`, `file-search`, `feedback`,
`shell-escalation`, and `debug-client`)






---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/16353).
* #16351
* __->__ #16353

9a8730f31e · 2026-03-31 21:59:28 +00:00

History

bazel.yml

build: migrate argument-comment-lint to a native Bazel aspect (#16106 )

2026-03-28 12:41:56 -07:00

blob-size-policy.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

cargo-deny.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

ci.yml

ci: verify codex-rs Cargo manifests inherit workspace settings (#16353 )

2026-03-31 21:59:28 +00:00

cla.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

close-stale-contributor-prs.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

codespell.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

Dockerfile.bazel

ci(bazel): install Node from node-version.txt in remote image (#12205 )

2026-02-20 11:51:17 -08:00

issue-deduplicator.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

issue-labeler.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

README.md

ci: split fast PR Rust CI from full post-merge Cargo CI (#16072 )

2026-03-27 21:08:08 -07:00

rust-ci-full.yml

ci: run Windows argument-comment-lint via native Bazel (#16120 )

2026-03-30 15:32:04 -07:00

rust-ci.yml

ci: run Windows argument-comment-lint via native Bazel (#16120 )

2026-03-30 15:32:04 -07:00

rust-release-argument-comment-lint.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release-prepare.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release-windows.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release-zsh.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rusty-v8-release.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

sdk.yml

ci: run SDK tests with a Bazel-built codex (#16046 )

2026-03-27 17:17:22 -07:00

v8-canary.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

zstd

ci(windows): use DotSlash for zstd in rust-release-windows (#11542 )

2026-02-11 20:57:11 -08:00

README.md

Workflow Strategy

The workflows in this directory are split so that pull requests get fast, review-friendly signal while main still gets the full cross-platform verification pass.

Pull Requests

bazel.yml is the main pre-merge verification path for Rust code. It runs Bazel test and Bazel clippy on the supported Bazel targets.
rust-ci.yml keeps the Cargo-native PR checks intentionally small:
- cargo fmt --check
- cargo shear
- argument-comment-lint on Linux, macOS, and Windows
- tools/argument-comment-lint package tests when the lint or its workflow wiring changes

The PR workflow still keeps the Linux lint lane on the default-targets-only invocation for now, but the released linter runs on Linux, macOS, and Windows before merge.

Post-Merge On `main`

bazel.yml also runs on pushes to main. This re-verifies the merged Bazel path and helps keep the BuildBuddy caches warm.
rust-ci-full.yml is the full Cargo-native verification workflow. It keeps the heavier checks off the PR path while still validating them after merge:
- the full Cargo clippy matrix
- the full Cargo nextest matrix
- release-profile Cargo builds
- cross-platform argument-comment-lint
- Linux remote-env tests

Rule Of Thumb

If a build/test/clippy check can be expressed in Bazel, prefer putting the PR-time version in bazel.yml.
Keep rust-ci.yml fast enough that it usually does not dominate PR latency.
Reserve rust-ci-full.yml for heavyweight Cargo-native coverage that Bazel does not replace yet.

README.md

Workflow Strategy

Pull Requests

Post-Merge On main

Rule Of Thumb

Post-Merge On `main`