Dylan Hurd 2cf2a6a844 chore(core) rm AskForApproval::OnFailure (#28418) ...

## Summary
Deletes the OnFailure variant of the `AskForApproval` enum. This option
has been deprecated since #11631.

## Testing
- [x] Tests pass

2cf2a6a844 · 2026-06-23 12:13:54 -07:00

History

..

snapshots

core: wrap token budget window context (#29494)

2026-06-22 23:37:49 +00:00

abort_tasks.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

additional_context.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

agent_execution.rs

Namespace multi-agent v2 tools under collaboration (#29067)

2026-06-23 14:15:20 +02:00

agent_jobs.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

agent_websocket.rs

[codex] Use input items for Responses Lite tools (#27946)

2026-06-22 23:56:16 -07:00

agents_md.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

apply_patch_cli.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

approvals.rs

chore(core) rm AskForApproval::OnFailure (#28418)

2026-06-23 12:13:54 -07:00

auto_review.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

cli_stream.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

client_websockets.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

client.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

code_mode.rs

[core] debounce current-time reminders by elapsed time (#29659)

2026-06-23 10:13:27 -07:00

codex_delegate.rs

chore(features) rm Feature::ApplyPatchFreeform (#22711)

2026-05-14 16:15:56 -07:00

collaboration_instructions.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

compact_remote_parity.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

compact_remote.rs

core: rename metadata -> internal_chat_message_metadata_passthrough (#28968)

2026-06-22 11:11:25 -07:00

compact_resume_fork.rs

Support openai/form extended form elicitations (#27500)

2026-06-18 11:54:49 -07:00

compact.rs

core: rename metadata -> internal_chat_message_metadata_passthrough (#28968)

2026-06-22 11:11:25 -07:00

current_time_reminder.rs

[core] debounce current-time reminders by elapsed time (#29659)

2026-06-23 10:13:27 -07:00

deprecation_notice.rs

Add indexed web search mode (#28489)

2026-06-19 05:35:57 -07:00

exec_policy.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

exec.rs

Add network environment ID plumbing (#28766)

2026-06-18 14:09:38 +02:00

extension_sandbox.rs

remove flag for image preparation (#29429)

2026-06-22 10:05:11 -07:00

fork_thread.rs

Share resumed rollout history (#28426)

2026-06-23 10:23:25 -04:00

guardian_review.rs

[codex] Start the guardian child session when parent session is started (#27982)

2026-06-22 11:54:44 -07:00

hooks_mcp.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

hooks.rs

chore(core) rm AskForApproval::OnFailure (#28418)

2026-06-23 12:13:54 -07:00

image_rollout.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

items.rs

[codex] Persist built-in image results reported as generating (#28656)

2026-06-17 06:03:00 +00:00

json_result.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

live_cli.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

mcp_refresh_cleanup.rs

Shut down superseded MCP managers on refresh (#29608)

2026-06-23 18:29:27 +01:00

mcp_tool_exposure.rs

[codex] Use tool search for MCP tools by default (#29486)

2026-06-22 16:45:23 -07:00

mcp_turn_metadata.rs

[ez][codex-rs] Support apps._default.default_tools_approval_mode (#27965)

2026-06-17 08:50:39 -07:00

mod.rs

Shut down superseded MCP managers on refresh (#29608)

2026-06-23 18:29:27 +01:00

model_overrides.rs

[5 of 7] Replace OverrideTurnContext with ThreadSettings (#22508)

2026-05-18 21:03:51 -07:00

model_runtime_selectors.rs

Namespace multi-agent v2 tools under collaboration (#29067)

2026-06-23 14:15:20 +02:00

model_switching.rs

remove flag for image preparation (#29429)

2026-06-22 10:05:11 -07:00

model_visible_layout.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

models_cache_ttl.rs

[codex] Add comp_hash to model metadata (#27532)

2026-06-10 20:42:55 -07:00

models_etag_responses.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

multi_agent_mode.rs

Simplify multi-agent mode controls (#29324)

2026-06-22 10:05:36 +02:00

network_approval.rs

chore(core) rm AskForApproval::OnFailure (#28418)

2026-06-23 12:13:54 -07:00

openai_file_mcp.rs

[codex] Use tool search for MCP tools by default (#29486)

2026-06-22 16:45:23 -07:00

otel.rs

[codex] Expose service tier and reasoning effort in OTEL (#29155)

2026-06-22 20:44:48 -07:00

override_updates.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

pending_input.rs

Namespace multi-agent v2 tools under collaboration (#29067)

2026-06-23 14:15:20 +02:00

permissions_messages.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

personality_migration.rs

Persist session IDs across thread resume (#29327)

2026-06-22 09:36:08 +02:00

personality.rs

[codex] Add comp_hash to model metadata (#27532)

2026-06-10 20:42:55 -07:00

plugins.rs

[codex] Use tool search for MCP tools by default (#29486)

2026-06-22 16:45:23 -07:00

prompt_caching.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

prompt_debug_tests.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

quota_exceeded.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

realtime_conversation.rs

core: rename metadata -> internal_chat_message_metadata_passthrough (#28968)

2026-06-22 11:11:25 -07:00

remote_env.rs

chore(core) rm AskForApproval::OnFailure (#28418)

2026-06-23 12:13:54 -07:00

remote_models.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

request_compression.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

request_permissions_tool.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

request_permissions.rs

[codex] test exec relative additional permissions (#28587)

2026-06-16 20:45:57 +00:00

request_plugin_install.rs

[plugins] Refresh plugin and tool caches after remote install (#28951)

2026-06-18 20:08:04 -04:00

request_user_input.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

responses_api_proxy_headers.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

responses_lite.rs

[codex] Use input items for Responses Lite tools (#27946)

2026-06-22 23:56:16 -07:00

resume_warning.rs

Share resumed rollout history (#28426)

2026-06-23 10:23:25 -04:00

resume.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

review.rs

core: rename metadata -> internal_chat_message_metadata_passthrough (#28968)

2026-06-22 11:11:25 -07:00

rmcp_client.rs

Allow codex sandbox to consume MCP sandbox state (#29358)

2026-06-23 10:17:52 +02:00

rollout_budget.rs

Namespace multi-agent v2 tools under collaboration (#29067)

2026-06-23 14:15:20 +02:00

rollout_list_find.rs

Persist session IDs across thread resume (#29327)

2026-06-22 09:36:08 +02:00

safety_buffering.rs

Propagate safety buffering treatment metadata (#29473)

2026-06-22 19:51:03 -07:00

safety_check_downgrade.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

search_tool.rs

[codex] Use tool search for MCP tools by default (#29486)

2026-06-22 16:45:23 -07:00

shell_command.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

shell_serialization.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

shell_snapshot.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

skill_approval.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

skills.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

spawn_agent_description.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

sqlite_state.rs

Persist session IDs across thread resume (#29327)

2026-06-22 09:36:08 +02:00

stream_error_allows_next_turn.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

stream_no_completed.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

subagent_notifications.rs

Namespace multi-agent v2 tools under collaboration (#29067)

2026-06-23 14:15:20 +02:00

token_budget.rs

core: wrap token budget window context (#29494)

2026-06-22 23:37:49 +00:00

tool_harness.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

tool_parallelism.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

tools.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

truncation.rs

remove flag for image preparation (#29429)

2026-06-22 10:05:11 -07:00

turn_state.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

unified_exec_zsh_fork_approvals.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

unified_exec.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

unstable_features_warning.rs

[codex] Remove child AGENTS.md prompt experiment (#28993)

2026-06-18 16:13:07 -07:00

user_notification.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

user_shell_cmd.rs

[codex] Warn clearly when code mode output is truncated (#28467)

2026-06-16 10:37:06 -07:00

view_image.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

web_search.rs

Add indexed web search mode (#28489)

2026-06-19 05:35:57 -07:00

websocket_fallback.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

window_headers.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

windows_sandbox.rs

Add network environment ID plumbing (#28766)

2026-06-18 14:09:38 +02:00