agent/codex
1
0
Fork 0
mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
271d5cecf2e71f9ea171653306cc9ce7c6ec3f19
codex/.github/workflows
T
Adam Perry @ OpenAI 6471f8b31a [codex] Fix Windows BuildBuddy Bazel wrapper execution (#25915) 
## Why

#25156 moved Bazel CI launches into a shared Python wrapper. On Windows,
launching Bazel with `os.execvp` can split the spaced
`--test_env=PATH=...` argument and fail to propagate the eventual Bazel
exit status, allowing jobs to pass without running tests. This reapplies
the wrapper after #25909 with a Windows-safe launch path.

## What changed

Use a waited `subprocess.run` launch on Windows while preserving
`os.execvp` on Unix. Add a process-level regression test for spaced
arguments and child exit status, and run it on Windows Bazel shard 1.

## Experiment

To confirm Bazel was actually invoking tests, patch `87b61d0be6`
temporarily added an intentionally failing `codex-core` unit test. Bazel
failed on that sentinel on all three major platforms:

- [Linux Bazel
test](https://github.com/openai/codex/actions/runs/26841132773/job/79151062486)
- [macOS Bazel
test](https://github.com/openai/codex/actions/runs/26841132773/job/79151062362)
- [Windows Bazel test shard
1/4](https://github.com/openai/codex/actions/runs/26841132773/job/79151062155)

The sentinel was removed after collecting this evidence. Windows Bazel
[clippy](https://github.com/openai/codex/actions/runs/26841132773/job/79151062914)
and [release
verification](https://github.com/openai/codex/actions/runs/26841132773/job/79151062739)
also passed.

## Validation

After removing the sentinel, `just test -p codex-core` no longer
reported it. The local run retained two unrelated environment-specific
failures.
6471f8b31a ยท 2026-06-02 16:22:32 -07:00
History
..
bazel.yml
[codex] Fix Windows BuildBuddy Bazel wrapper execution (#25915)
2026-06-02 16:22:32 -07:00
blob-size-policy.yml
ci: check out PR head commits in workflows (#21835)
2026-05-08 15:14:33 -07:00
cargo-deny.yml
[codex] Use git CLI for Cargo fetches across Rust workflows (#25775)
2026-06-02 07:39:41 -07:00
ci.yml
[codex] Add comprehensive root formatting check (#25683)
2026-06-02 01:20:25 +00:00
cla.yml
[codex] Pin GitHub Actions workflow references (#15828)
2026-03-27 23:00:05 +00:00
close-stale-contributor-prs.yml
[codex] Fully qualify hash-pins in GitHub Actions (#21436)
2026-05-07 14:31:20 -07:00
codespell.yml
ci: check out PR head commits in workflows (#21835)
2026-05-08 15:14:33 -07:00
Dockerfile.bazel
Remove js_repl feature (#19410)
2026-04-24 17:49:29 -07:00
issue-deduplicator.yml
ci: use issue triage environment for issue workflows (#25134)
2026-05-29 12:06:55 -07:00
issue-labeler.yml
ci: use issue triage environment for issue workflows (#25134)
2026-05-29 12:06:55 -07:00
python-sdk-release.yml
[codex] Publish Python runtime wheels with Python SDK releases (#25906)
2026-06-02 15:41:53 -07:00
README.md
Fan out rust-ci-full nextest by platform (#23358)
2026-05-19 17:54:41 -07:00
rust-ci-full-nextest-platform.yml
Uprev Rust toolchain pins to 1.95.0 (#24684)
2026-05-26 20:59:47 -07:00
rust-ci-full.yml
Revert "Add app-server startup benchmark crate" (#24937)
2026-05-28 17:49:41 +00:00
rust-ci.yml
[codex] Use git CLI for Cargo fetches across Rust workflows (#25775)
2026-06-02 07:39:41 -07:00
rust-release-argument-comment-lint.yml
[codex] Use git CLI for Cargo fetches across Rust workflows (#25775)
2026-06-02 07:39:41 -07:00
rust-release-prepare.yml
make rust-release-prepare use env secret (#22702)
2026-05-14 21:45:53 +00:00
rust-release-windows.yml
Revert "Use environment secrets for Azure signing" (#25948)
2026-06-02 15:12:07 -07:00
rust-release-zsh.yml
release: build macOS x64 zsh artifact (#24165)
2026-05-22 17:08:59 -07:00
rust-release.yml
[codex] Publish Python runtime wheels with Python SDK releases (#25906)
2026-06-02 15:41:53 -07:00
rusty-v8-release.yml
[codex] Fix Windows BuildBuddy Bazel wrapper execution (#25915)
2026-06-02 16:22:32 -07:00
sdk.yml
[codex] Pin Python SDK to glibc-compatible runtime (#25907)
2026-06-02 12:27:01 -07:00
v8-canary.yml
[codex] Fix Windows BuildBuddy Bazel wrapper execution (#25915)
2026-06-02 16:22:32 -07:00
zstd
ci(windows): use DotSlash for zstd in rust-release-windows (#11542)
2026-02-11 20:57:11 -08:00

README.md

Workflow Strategy

The workflows in this directory are split so that pull requests get fast, review-friendly signal while main still gets the full cross-platform verification pass.

Pull Requests

  • bazel.yml is the main pre-merge verification path for Rust code. It runs Bazel test and Bazel clippy on the supported Bazel targets, including the generated Rust test binaries needed to lint inline #[cfg(test)] code.
  • rust-ci.yml keeps the Cargo-native PR checks intentionally small:
    • cargo fmt --check
    • cargo shear
    • argument-comment-lint on Linux, macOS, and Windows
    • tools/argument-comment-lint package tests when the lint or its workflow wiring changes

Post-Merge On main

  • bazel.yml also runs on pushes to main. This re-verifies the merged Bazel path and helps keep the BuildBuddy caches warm.
  • rust-ci-full.yml is the full Cargo-native verification workflow. It keeps the heavier checks off the PR path while still validating them after merge:
    • the full Cargo clippy matrix
    • the full Cargo nextest matrix via per-platform archive-backed shards
    • Windows ARM64 nextest archives cross-compiled on Windows x64, then replayed on native Windows ARM64 shards
    • release-profile Cargo builds
    • cross-platform argument-comment-lint
    • Linux remote-env tests

Rule Of Thumb

  • If a build/test/clippy check can be expressed in Bazel, prefer putting the PR-time version in bazel.yml.
  • Keep rust-ci.yml fast enough that it usually does not dominate PR latency.
  • Reserve rust-ci-full.yml for heavyweight Cargo-native coverage that Bazel does not replace yet.
Reference in New Issue View Git Blame Copy Permalink