Celia Chen 0db6811b7c Fix: use function apply_patch tool for Bedrock model (#19416) ...

## Why

`openai.gpt-5.4-cmb` is served through the Amazon Bedrock provider,
whose request validator currently accepts `function` and `mcp` tool
specs but rejects Responses `custom` tools. The CMB catalog entry reuses
the bundled `gpt-5.4` metadata, which marks `apply_patch_tool_type` as
`freeform`. That causes Codex to include an `apply_patch` tool with
`type: "custom"`, so even heavily disabled sessions can fail before the
model runs with:

```text
Invalid tools: unknown variant `custom`, expected `function` or `mcp`
```

This is provider-specific: the model should still expose `apply_patch`,
but for Bedrock it needs to use the JSON/function tool shape instead of
the freeform/custom shape.

## What Changed

- Override the `openai.gpt-5.4-cmb` static catalog entry to set
`apply_patch_tool_type` to `function` after inheriting the rest of the
`gpt-5.4` model metadata.
- Update the catalog test expectation so the CMB entry continues to
track `gpt-5.4` metadata except for this Bedrock-specific tool shape
override.

## Verification

- `cargo test -p codex-model-provider`
- `just fix -p codex-model-provider`

0db6811b7c · 2026-04-24 18:45:09 +00:00

History

..

src

Fix: use function apply_patch tool for Bedrock model (#19416)

2026-04-24 18:45:09 +00:00

BUILD.bazel

feat: add opt-in provider runtime abstraction (#17713)

2026-04-17 02:27:45 +00:00

Cargo.toml

feat: let model providers own model discovery (#18950)

2026-04-24 04:28:25 +00:00