codex

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Eric Traut 0d44bd708e Fix duplicate /review messages in app-server TUI (#15839 )

## Symptoms
When `/review` ran through `tui_app_server`, the TUI could show
duplicate review content:
- the `>> Code review started: ... <<` banner appeared twice
- the final review body could also appear twice

## Problem
`tui_app_server` was treating review lifecycle items as renderable
content on more than one delivery path.

Specifically:
- `EnteredReviewMode` was rendered both when the item started and again
when it completed
- `ExitedReviewMode` rendered the review text itself, even though the
same review text was also delivered later as the assistant message item

That meant the same logical review event was committed into history
multiple times.

## Solution
Make review lifecycle items control state transitions only once, and
keep the final review body sourced from the assistant message item:
- render the review-start banner from the live `ItemStarted` path, while
still allowing replay to restore it once
- treat `ExitedReviewMode` as a mode-exit/finish-banner event instead of
rendering the review body from it
- preserve the existing assistant-message rendering path as the single
source of final review text

0d44bd708e · 2026-03-26 10:55:18 -06:00

History

frames

Move TUI on top of app server (parallel code) (#14717 )

2026-03-16 10:49:19 -06:00

src

Fix duplicate /review messages in app-server TUI (#15839 )

2026-03-26 10:55:18 -06:00

tests

[hooks] add non-streaming (non-stdin style) shell-only PostToolUse support (#15531 )

2026-03-25 19:18:03 -07:00

BUILD.bazel