pakrym-oai 1aa3e432cc [codex] simplify shell snapshot ownership (#27756) ...

## Why

Shell snapshot lifecycle state was split between `Shell` and
`SessionServices`: `Shell` carried the receiver while session code
exposed and forwarded the raw sender. That coupled shell identity to
mutable snapshot state and made refresh, inheritance, and file lifetime
harder to reason about.

## What changed

- make each `Arc<ShellSnapshot>` represent one cwd-specific snapshot
generation
- store the active generation in `SessionServices` with `ArcSwapOption`
- have construction start the background build and expose only a
cwd-validated snapshot path
- use `ShellSnapshotFile` ownership to delete snapshot files
automatically
- pass snapshot paths explicitly to shell runtimes instead of storing
snapshot state on `Shell`
- preserve inherited and in-flight generations by pinning their `Arc`
while they are in use

## Test plan

- `cargo check -p codex-core --lib`
- `just test -p codex-core 'shell_snapshot::tests'`
- `just test -p codex-core
shell_command_snapshot_still_intercepts_apply_patch`
- `just test -p codex-core
shell_snapshot_deleted_after_shutdown_with_skills`

1aa3e432cc · 2026-06-15 08:18:13 -07:00

History

..

approved_command_prefix_saved.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

apps_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

available_plugins_instructions.rs

fix(plugins) rm plugin descriptions (#23254)

2026-06-12 13:31:11 -07:00

available_skills_instructions.rs

skills: make backend plugin skills invocable without an executor (#27387)

2026-06-11 11:28:16 +02:00

collaboration_mode_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

contextual_user_message_tests.rs

[codex] Load AGENTS.md from all bound environments (#27696)

2026-06-12 00:10:06 -07:00

contextual_user_message.rs

Use internal model context fragments for goal steering (#24918)

2026-05-29 10:28:25 +02:00

environment_context_tests.rs

[codex] simplify shell snapshot ownership (#27756)

2026-06-15 08:18:13 -07:00

environment_context.rs

sandboxing: migrate cwd inputs to PathUri (#27816)

2026-06-12 11:38:01 -07:00

guardian_followup_review_reminder.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

hook_additional_context.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

image_generation_instructions.rs

Add saved image path hint to standalone image generation (#25947)

2026-06-04 09:39:20 -07:00

internal_model_context.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

legacy_apply_patch_exec_command_warning.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

legacy_model_mismatch_warning.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

legacy_unified_exec_process_limit_warning.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

mod.rs

skills: make backend plugin skills invocable without an executor (#27387)

2026-06-11 11:28:16 +02:00

model_switch_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

network_rule_saved.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

permissions_instructions.rs

chore: extract context fragments into dedicated crate (#26122)

2026-06-03 12:25:21 +02:00

personality_spec_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

plugin_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

realtime_end_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

realtime_start_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

realtime_start_with_instructions.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

subagent_notification.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

token_budget_context.rs

Include thread id in token budget context (#27663)

2026-06-11 15:10:29 -07:00

turn_aborted.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00

user_instructions.rs

[codex] Load AGENTS.md from all bound environments (#27696)

2026-06-12 00:10:06 -07:00

user_shell_command.rs

skills: resolve per-turn catalogs from turn input context (#26106)

2026-06-03 13:32:55 +02:00