mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
pakrym-oai
e752f7b4ae
The workspace denies `clippy::expect_used` in production. Although `clippy.toml` allows `expect` in tests, Bazel Clippy compiles integration-test helper code in a way that does not receive that exemption, which encouraged verbose `unwrap_or_else(... panic!(...))` and equivalent `match`/`let else` forms. This allows `clippy::expect_used` once at each integration-test crate root (including aggregated suites and test-support libraries), then replaces manual panic-based Result and Option unwraps with `expect`/`expect_err`. Standalone `tests/*.rs` files remain their own crate roots. Intentional assertion and unexpected-variant panics remain unchanged, and the production `expect_used = "deny"` lint remains in place. The cleanup is mechanical and net-negative in line count.
55 lines
1.7 KiB
Rust
55 lines
1.7 KiB
Rust
#![allow(clippy::expect_used)]
|
|
use std::fs;
|
|
use std::path::Path;
|
|
use std::path::PathBuf;
|
|
|
|
fn rust_sources_under(dir: &Path) -> Vec<PathBuf> {
|
|
let mut files = Vec::new();
|
|
let entries = fs::read_dir(dir).expect("source directory should be readable");
|
|
for entry in entries {
|
|
let entry = entry.expect("source directory entry should be readable");
|
|
let path = entry.path();
|
|
if path.is_dir() {
|
|
files.extend(rust_sources_under(&path));
|
|
} else if path.extension().is_some_and(|ext| ext == "rs") {
|
|
files.push(path);
|
|
}
|
|
}
|
|
files.sort();
|
|
files
|
|
}
|
|
|
|
#[test]
|
|
fn tui_runtime_source_does_not_depend_on_manager_escape_hatches() {
|
|
let src_file = codex_utils_cargo_bin::find_resource!("src/chatwidget.rs")
|
|
.expect("chatwidget source runfile should resolve");
|
|
let src_dir = src_file
|
|
.parent()
|
|
.expect("chatwidget source file should have a parent");
|
|
let sources = rust_sources_under(src_dir);
|
|
let forbidden = [
|
|
"AuthManager",
|
|
"ThreadManager",
|
|
"auth_manager(",
|
|
"thread_manager(",
|
|
];
|
|
|
|
let violations: Vec<String> = sources
|
|
.iter()
|
|
.flat_map(|path| {
|
|
let contents = fs::read_to_string(path).expect("Rust source file should be readable");
|
|
let path_display = path.display().to_string();
|
|
forbidden
|
|
.iter()
|
|
.filter(move |needle| contents.contains(**needle))
|
|
.map(move |needle| format!("{path_display} contains `{needle}`"))
|
|
})
|
|
.collect();
|
|
|
|
assert!(
|
|
violations.is_empty(),
|
|
"unexpected manager dependency regression(s):\n{}",
|
|
violations.join("\n")
|
|
);
|
|
}
|