Owen Lin 812cd2bb57 ensure thread.history_mode is immutable (#30261) ...

## Description

This PR makes `thread.history_mode` immutable after the thread's
canonical first `SessionMeta` has been written. Later same-thread
`SessionMeta` lines are compatibility metadata writes, not a new thread
definition.

Without this, an older binary could append a `SessionMeta` that omits
`history_mode`; when a newer binary replays it, serde defaults that
missing field to `legacy` and SQLite could downgrade a paginated thread.

## Why

`history_mode` is the persisted thread storage contract.
Paginated-thread fail-closed behavior and SQLite memory filtering depend
on it staying aligned with canonical rollout metadata, especially when
multiple Codex binary versions can touch the same local rollout.

## What changed

- Stop generic rollout metadata replay from overwriting `history_mode`
from later `SessionMeta` items.
- Remove `history_mode` from `ThreadMetadataPatch`, so mutable metadata
sync and app-server metadata updates cannot rewrite it.
- When local metadata sync has to recreate a missing SQLite row, recover
`history_mode` from the rollout's canonical first `SessionMeta` instead
of from a mutable patch.
- Keep the in-memory thread store using the created thread's canonical
`history_mode` instead of metadata patches.
- Fill the one remaining core test `CreateThreadParams` initializer with
the new `history_mode` field; Bazel CI caught this after the parent
history-mode PR landed.

## Validation

- `just fmt`
- `just test -p codex-thread-store`
- `just test -p codex-state
session_meta_does_not_set_model_or_reasoning_effort`

812cd2bb57 · 2026-06-26 12:32:31 -07:00

History

..

goals_migrations

feat: dedicated goal DB (#23300)

2026-05-19 11:11:41 +02:00

logs_migrations

Align SQLite feedback logs with feedback formatter (#13494)

2026-03-18 22:44:31 +00:00

memory_migrations

Move memory state to a dedicated SQLite DB (#24591)

2026-05-26 20:07:25 +02:00

migrations

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

src

ensure thread.history_mode is immutable (#30261)

2026-06-26 12:32:31 -07:00

BUILD.bazel

build: run buildifier from just fmt (#28125)

2026-06-13 21:43:39 -07:00

Cargo.toml

[codex] Pin bundled SQLite to fixed WAL-reset version (#27992)

2026-06-13 21:28:31 -07:00