mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
pakrym-oai
e752f7b4ae
The workspace denies `clippy::expect_used` in production. Although `clippy.toml` allows `expect` in tests, Bazel Clippy compiles integration-test helper code in a way that does not receive that exemption, which encouraged verbose `unwrap_or_else(... panic!(...))` and equivalent `match`/`let else` forms. This allows `clippy::expect_used` once at each integration-test crate root (including aggregated suites and test-support libraries), then replaces manual panic-based Result and Option unwraps with `expect`/`expect_err`. Standalone `tests/*.rs` files remain their own crate roots. Intentional assertion and unexpected-variant panics remain unchanged, and the production `expect_used = "deny"` lint remains in place. The cleanup is mechanical and net-negative in line count.
68 lines
2.0 KiB
Rust
68 lines
2.0 KiB
Rust
#![cfg(not(target_os = "windows"))]
|
|
#![allow(clippy::unwrap_used)]
|
|
|
|
use core_test_support::responses;
|
|
use core_test_support::skip_if_no_network;
|
|
use core_test_support::test_codex_exec::test_codex_exec;
|
|
use walkdir::WalkDir;
|
|
use wiremock::MockServer;
|
|
|
|
fn exec_sse_response() -> String {
|
|
responses::sse(vec![
|
|
responses::ev_response_created("resp-ephemeral"),
|
|
responses::ev_assistant_message("msg-ephemeral", "ephemeral response"),
|
|
responses::ev_completed("resp-ephemeral"),
|
|
])
|
|
}
|
|
|
|
fn session_rollout_count(home_path: &std::path::Path) -> usize {
|
|
let sessions_dir = home_path.join("sessions");
|
|
if !sessions_dir.exists() {
|
|
return 0;
|
|
}
|
|
|
|
WalkDir::new(sessions_dir)
|
|
.into_iter()
|
|
.filter_map(Result::ok)
|
|
.filter(|entry| entry.file_type().is_file())
|
|
.filter(|entry| entry.file_name().to_string_lossy().ends_with(".jsonl"))
|
|
.count()
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn persists_rollout_file_by_default() -> anyhow::Result<()> {
|
|
skip_if_no_network!(Ok(()));
|
|
|
|
let test = test_codex_exec();
|
|
let server = MockServer::start().await;
|
|
let _response_mock = responses::mount_sse_once(&server, exec_sse_response()).await;
|
|
|
|
test.cmd_with_server(&server)
|
|
.arg("--skip-git-repo-check")
|
|
.arg("default persistence behavior")
|
|
.assert()
|
|
.code(0);
|
|
|
|
assert_eq!(session_rollout_count(test.home_path()), 1);
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn does_not_persist_rollout_file_in_ephemeral_mode() -> anyhow::Result<()> {
|
|
skip_if_no_network!(Ok(()));
|
|
|
|
let test = test_codex_exec();
|
|
let server = MockServer::start().await;
|
|
let _response_mock = responses::mount_sse_once(&server, exec_sse_response()).await;
|
|
|
|
test.cmd_with_server(&server)
|
|
.arg("--skip-git-repo-check")
|
|
.arg("--ephemeral")
|
|
.arg("ephemeral behavior")
|
|
.assert()
|
|
.code(0);
|
|
|
|
assert_eq!(session_rollout_count(test.home_path()), 0);
|
|
Ok(())
|
|
}
|