mod archive_thread; mod create_thread; mod helpers; mod list_threads; mod live_writer; mod read_thread; mod search_threads; mod unarchive_thread; mod update_thread_metadata; #[cfg(test)] mod test_support; use async_trait::async_trait; use codex_protocol::ThreadId; use codex_rollout::RolloutRecorder; use codex_rollout::StateDbHandle; use std::collections::HashMap; use std::collections::hash_map::Entry; use std::path::PathBuf; use std::sync::Arc; use tokio::sync::Mutex; use crate::AppendThreadItemsParams; use crate::ArchiveThreadParams; use crate::CreateThreadParams; use crate::ListThreadsParams; use crate::LoadThreadHistoryParams; use crate::ReadThreadByRolloutPathParams; use crate::ReadThreadParams; use crate::ResumeThreadParams; use crate::SearchThreadsParams; use crate::StoredThread; use crate::StoredThreadHistory; use crate::ThreadPage; use crate::ThreadSearchPage; use crate::ThreadStore; use crate::ThreadStoreError; use crate::ThreadStoreResult; use crate::UpdateThreadMetadataParams; /// Local filesystem/SQLite-backed implementation of [`ThreadStore`]. /// /// Local storage has two compatibility surfaces. Rollout JSONL files are the /// durable replay format and remain readable without SQLite, including older /// files that encode metadata in `SessionMeta` items and name-index entries. /// The SQLite state DB, when available, is the queryable metadata index used by /// list/read paths for fast lookup. /// /// Live appends still write canonical JSONL history, but append-derived /// metadata is observed above the store and applied through /// [`ThreadStore::update_thread_metadata`]. This implementation applies that /// patch literally to SQLite while keeping the JSONL/name-index compatibility /// behavior needed for SQLite-less reads, repair, and old local rollout files. #[derive(Clone)] pub struct LocalThreadStore { pub(super) config: LocalThreadStoreConfig, live_recorders: Arc>>, state_db: Option, } /// Process-scoped configuration for local thread storage. /// /// This describes where local storage lives. New-thread rollout metadata such /// as cwd, provider, and memory mode is supplied when live persistence is opened. #[derive(Clone, Debug, PartialEq, Eq)] pub struct LocalThreadStoreConfig { pub codex_home: PathBuf, pub sqlite_home: PathBuf, /// Provider used only when older local metadata does not contain one. pub default_model_provider_id: String, } impl LocalThreadStoreConfig { pub fn from_config(config: &impl codex_rollout::RolloutConfigView) -> Self { Self { codex_home: config.codex_home().to_path_buf(), sqlite_home: config.sqlite_home().to_path_buf(), default_model_provider_id: config.model_provider_id().to_string(), } } } impl std::fmt::Debug for LocalThreadStore { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { f.debug_struct("LocalThreadStore") .field("config", &self.config) .finish_non_exhaustive() } } impl LocalThreadStore { /// Create a local store using an already initialized state DB handle. pub fn new(config: LocalThreadStoreConfig, state_db: Option) -> Self { Self { config, live_recorders: Arc::new(Mutex::new(HashMap::new())), state_db, } } /// Return the state DB handle used by local rollout writers. pub async fn state_db(&self) -> Option { self.state_db.clone() } /// Read a local rollout-backed thread by path. pub async fn read_thread_by_rollout_path( &self, rollout_path: PathBuf, include_archived: bool, include_history: bool, ) -> ThreadStoreResult { read_thread::read_thread_by_rollout_path( self, rollout_path, include_archived, include_history, ) .await } /// Return the live local rollout path for legacy local-only code paths. pub async fn live_rollout_path(&self, thread_id: ThreadId) -> ThreadStoreResult { live_writer::rollout_path(self, thread_id).await } pub(super) async fn live_recorder( &self, thread_id: ThreadId, ) -> ThreadStoreResult { self.live_recorders .lock() .await .get(&thread_id) .cloned() .ok_or(ThreadStoreError::ThreadNotFound { thread_id }) } pub(super) async fn ensure_live_recorder_absent( &self, thread_id: ThreadId, ) -> ThreadStoreResult<()> { if self.live_recorders.lock().await.contains_key(&thread_id) { return Err(ThreadStoreError::InvalidRequest { message: format!("thread {thread_id} already has a live local writer"), }); } Ok(()) } pub(super) async fn insert_live_recorder( &self, thread_id: ThreadId, recorder: RolloutRecorder, ) -> ThreadStoreResult<()> { match self.live_recorders.lock().await.entry(thread_id) { Entry::Occupied(entry) => Err(ThreadStoreError::InvalidRequest { message: format!("thread {} already has a live local writer", entry.key()), }), Entry::Vacant(entry) => { entry.insert(recorder); Ok(()) } } } } #[async_trait] impl ThreadStore for LocalThreadStore { fn as_any(&self) -> &dyn std::any::Any { self } async fn create_thread(&self, params: CreateThreadParams) -> ThreadStoreResult<()> { live_writer::create_thread(self, params).await } async fn resume_thread(&self, params: ResumeThreadParams) -> ThreadStoreResult<()> { live_writer::resume_thread(self, params).await } async fn append_items(&self, params: AppendThreadItemsParams) -> ThreadStoreResult<()> { live_writer::append_items(self, params).await } async fn persist_thread(&self, thread_id: ThreadId) -> ThreadStoreResult<()> { live_writer::persist_thread(self, thread_id).await } async fn flush_thread(&self, thread_id: ThreadId) -> ThreadStoreResult<()> { live_writer::flush_thread(self, thread_id).await } async fn shutdown_thread(&self, thread_id: ThreadId) -> ThreadStoreResult<()> { live_writer::shutdown_thread(self, thread_id).await } async fn discard_thread(&self, thread_id: ThreadId) -> ThreadStoreResult<()> { live_writer::discard_thread(self, thread_id).await } async fn load_history( &self, params: LoadThreadHistoryParams, ) -> ThreadStoreResult { if let Ok(rollout_path) = live_writer::rollout_path(self, params.thread_id).await { if !params.include_archived && helpers::rollout_path_is_archived( self.config.codex_home.as_path(), rollout_path.as_path(), ) { return Err(ThreadStoreError::InvalidRequest { message: format!("thread {} is archived", params.thread_id), }); } return read_thread::read_thread_by_rollout_path( self, rollout_path, /*include_archived*/ true, /*include_history*/ true, ) .await? .history .ok_or_else(|| ThreadStoreError::Internal { message: format!("failed to load history for thread {}", params.thread_id), }); } read_thread::read_thread( self, ReadThreadParams { thread_id: params.thread_id, include_archived: params.include_archived, include_history: true, }, ) .await? .history .ok_or_else(|| ThreadStoreError::Internal { message: format!("failed to load history for thread {}", params.thread_id), }) } async fn read_thread(&self, params: ReadThreadParams) -> ThreadStoreResult { read_thread::read_thread(self, params).await } async fn read_thread_by_rollout_path( &self, params: ReadThreadByRolloutPathParams, ) -> ThreadStoreResult { read_thread::read_thread_by_rollout_path( self, params.rollout_path, params.include_archived, params.include_history, ) .await } async fn list_threads(&self, params: ListThreadsParams) -> ThreadStoreResult { list_threads::list_threads(self, params).await } async fn search_threads( &self, params: SearchThreadsParams, ) -> ThreadStoreResult { search_threads::search_threads(self, params).await } async fn update_thread_metadata( &self, params: UpdateThreadMetadataParams, ) -> ThreadStoreResult { update_thread_metadata::update_thread_metadata(self, params).await } async fn archive_thread(&self, params: ArchiveThreadParams) -> ThreadStoreResult<()> { archive_thread::archive_thread(self, params).await } async fn unarchive_thread( &self, params: ArchiveThreadParams, ) -> ThreadStoreResult { unarchive_thread::unarchive_thread(self, params).await } } #[cfg(test)] mod tests { use std::sync::Arc; use codex_protocol::ThreadId; use codex_protocol::models::BaseInstructions; use codex_protocol::protocol::EventMsg; use codex_protocol::protocol::RolloutItem; use codex_protocol::protocol::SessionSource; use codex_protocol::protocol::ThreadMemoryMode; use codex_protocol::protocol::UserMessageEvent; use tempfile::TempDir; use super::*; use crate::LiveThread; use crate::ThreadEventPersistenceMode; use crate::ThreadPersistenceMetadata; use crate::local::test_support::test_config; use crate::local::test_support::write_archived_session_file; use crate::local::test_support::write_session_file; #[tokio::test] async fn live_writer_lifecycle_writes_and_closes() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let thread_id = ThreadId::default(); store .create_thread(create_thread_params(thread_id)) .await .expect("create live thread"); let rollout_path = store .live_rollout_path(thread_id) .await .expect("load rollout path"); store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("first live write")], }) .await .expect("append live item"); store .persist_thread(thread_id) .await .expect("persist live thread"); store .flush_thread(thread_id) .await .expect("flush live thread"); assert_rollout_contains_message(rollout_path.as_path(), "first live write").await; store .shutdown_thread(thread_id) .await .expect("shutdown live thread"); let err = store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("write after shutdown")], }) .await .expect_err("shutdown should remove the live thread writer"); assert!( matches!(err, ThreadStoreError::ThreadNotFound { thread_id: missing } if missing == thread_id) ); } #[tokio::test] async fn raw_append_items_does_not_update_sqlite_metadata() { // This pins the ThreadStore contract: raw appends are history-only. Callers that need // metadata updates must use LiveThread or call update_thread_metadata explicitly. let home = TempDir::new().expect("temp dir"); let config = test_config(home.path()); let runtime = codex_state::StateRuntime::init( config.sqlite_home.clone(), config.default_model_provider_id.clone(), ) .await .expect("state db should initialize"); let store = LocalThreadStore::new(config, Some(runtime.clone())); let thread_id = ThreadId::default(); store .create_thread(create_thread_params(thread_id)) .await .expect("create live thread"); store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("raw append")], }) .await .expect("append raw item"); store.flush_thread(thread_id).await.expect("flush thread"); assert_eq!( runtime .get_thread(thread_id) .await .expect("sqlite metadata read"), None ); } #[tokio::test] async fn live_thread_observes_appended_items_into_sqlite_metadata() { let home = TempDir::new().expect("temp dir"); let config = test_config(home.path()); let runtime = codex_state::StateRuntime::init( config.sqlite_home.clone(), config.default_model_provider_id.clone(), ) .await .expect("state db should initialize"); let store = Arc::new(LocalThreadStore::new(config, Some(runtime.clone()))); let thread_id = ThreadId::default(); let live_thread = LiveThread::create(store.clone(), create_thread_params(thread_id)) .await .expect("create live thread"); live_thread .append_items(&[user_message_item("observed append")]) .await .expect("append observed item"); live_thread.flush().await.expect("flush thread"); let metadata = runtime .get_thread(thread_id) .await .expect("sqlite metadata read") .expect("sqlite metadata"); assert_eq!( metadata.first_user_message.as_deref(), Some("observed append") ); assert_eq!(metadata.preview.as_deref(), Some("observed append")); assert_eq!(metadata.title, "observed append"); } #[tokio::test] async fn live_thread_shutdown_does_not_materialize_empty_thread_metadata() { let home = TempDir::new().expect("temp dir"); let config = test_config(home.path()); let runtime = codex_state::StateRuntime::init( config.sqlite_home.clone(), config.default_model_provider_id.clone(), ) .await .expect("state db should initialize"); let store = Arc::new(LocalThreadStore::new(config, Some(runtime.clone()))); let thread_id = ThreadId::default(); let live_thread = LiveThread::create(store.clone(), create_thread_params(thread_id)) .await .expect("create live thread"); let rollout_path = store .live_rollout_path(thread_id) .await .expect("live rollout path"); live_thread.shutdown().await.expect("shutdown thread"); assert!( !tokio::fs::try_exists(rollout_path.as_path()) .await .expect("rollout path should be checkable") ); assert_eq!( runtime .get_thread(thread_id) .await .expect("sqlite metadata read"), None ); } #[tokio::test] async fn live_thread_shutdown_with_buffered_items_materializes_before_metadata_read() { let home = TempDir::new().expect("temp dir"); let config = test_config(home.path()); let runtime = codex_state::StateRuntime::init( config.sqlite_home.clone(), config.default_model_provider_id.clone(), ) .await .expect("state db should initialize"); let store = Arc::new(LocalThreadStore::new(config, Some(runtime.clone()))); let thread_id = ThreadId::default(); let live_thread = LiveThread::create(store.clone(), create_thread_params(thread_id)) .await .expect("create live thread"); let rollout_path = store .live_rollout_path(thread_id) .await .expect("live rollout path"); live_thread .append_items(&[RolloutItem::EventMsg(EventMsg::TokenCount( codex_protocol::protocol::TokenCountEvent { info: None, rate_limits: None, }, ))]) .await .expect("append metadata-only item"); live_thread.shutdown().await.expect("shutdown thread"); assert!( tokio::fs::try_exists(rollout_path.as_path()) .await .expect("rollout path should be checkable") ); let metadata = runtime .get_thread(thread_id) .await .expect("sqlite metadata read") .expect("sqlite metadata"); assert_eq!(metadata.rollout_path, rollout_path); } #[tokio::test] async fn live_thread_resume_loads_history_before_observing_metadata() { let home = TempDir::new().expect("temp dir"); let config = test_config(home.path()); let runtime = codex_state::StateRuntime::init( config.sqlite_home.clone(), config.default_model_provider_id.clone(), ) .await .expect("state db should initialize"); let store = Arc::new(LocalThreadStore::new(config, Some(runtime.clone()))); let uuid = uuid::Uuid::from_u128(401); let thread_id = ThreadId::from_string(&uuid.to_string()).expect("valid thread id"); let rollout_path = write_session_file(home.path(), "2025-01-03T17-00-00", uuid).expect("session file"); let live_thread = LiveThread::resume( store, ResumeThreadParams { thread_id, rollout_path: Some(rollout_path), history: None, include_archived: false, metadata: ThreadPersistenceMetadata { cwd: Some(home.path().to_path_buf()), model_provider: "different-provider".to_string(), memory_mode: ThreadMemoryMode::Enabled, }, event_persistence_mode: ThreadEventPersistenceMode::Limited, }, ) .await .expect("resume live thread"); live_thread .append_items(&[user_message_item("new live append")]) .await .expect("append after resume"); let metadata = runtime .get_thread(thread_id) .await .expect("sqlite metadata read") .expect("sqlite metadata"); assert_eq!( metadata.created_at.to_rfc3339(), "2025-01-03T17:00:00+00:00" ); assert_eq!(metadata.model_provider, "test-provider"); assert_eq!( metadata.first_user_message.as_deref(), Some("Hello from user") ); } #[tokio::test] async fn live_thread_resume_loads_history_from_explicit_external_rollout_path() { let home = TempDir::new().expect("temp dir"); let external_home = TempDir::new().expect("external temp dir"); let config = test_config(home.path()); let runtime = codex_state::StateRuntime::init( config.sqlite_home.clone(), config.default_model_provider_id.clone(), ) .await .expect("state db should initialize"); let store = Arc::new(LocalThreadStore::new(config, Some(runtime.clone()))); let uuid = uuid::Uuid::from_u128(402); let thread_id = ThreadId::from_string(&uuid.to_string()).expect("valid thread id"); let rollout_path = write_session_file(external_home.path(), "2025-01-03T17-30-00", uuid) .expect("external session file"); let live_thread = LiveThread::resume( store, ResumeThreadParams { thread_id, rollout_path: Some(rollout_path), history: None, include_archived: false, metadata: ThreadPersistenceMetadata { cwd: Some(home.path().to_path_buf()), model_provider: "different-provider".to_string(), memory_mode: ThreadMemoryMode::Enabled, }, event_persistence_mode: ThreadEventPersistenceMode::Limited, }, ) .await .expect("resume external live thread"); live_thread .append_items(&[user_message_item("new external append")]) .await .expect("append after external resume"); let metadata = runtime .get_thread(thread_id) .await .expect("sqlite metadata read") .expect("sqlite metadata"); assert_eq!( metadata.created_at.to_rfc3339(), "2025-01-03T17:30:00+00:00" ); assert_eq!(metadata.model_provider, "test-provider"); assert_eq!( metadata.first_user_message.as_deref(), Some("Hello from user") ); } #[tokio::test] async fn create_thread_rejects_missing_cwd() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let thread_id = ThreadId::default(); let mut params = create_thread_params(thread_id); params.metadata.cwd = None; let err = store .create_thread(params) .await .expect_err("local thread store should require cwd"); assert!(matches!( err, ThreadStoreError::InvalidRequest { message } if message == "local thread store requires a cwd" )); } #[tokio::test] async fn discard_thread_drops_unmaterialized_live_writer() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let thread_id = ThreadId::default(); store .create_thread(create_thread_params(thread_id)) .await .expect("create live thread"); let rollout_path = store .live_rollout_path(thread_id) .await .expect("load rollout path"); store .discard_thread(thread_id) .await .expect("discard live thread"); assert!( !tokio::fs::try_exists(rollout_path.as_path()) .await .expect("check rollout path") ); let err = store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("write after discard")], }) .await .expect_err("discard should remove the live thread writer"); assert!( matches!(err, ThreadStoreError::ThreadNotFound { thread_id: missing } if missing == thread_id) ); } #[tokio::test] async fn resume_thread_reopens_live_writer_and_appends() { let home = TempDir::new().expect("temp dir"); let config = test_config(home.path()); let thread_id = ThreadId::default(); let first_store = LocalThreadStore::new(config.clone(), /*state_db*/ None); first_store .create_thread(create_thread_params(thread_id)) .await .expect("create initial thread"); first_store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("before resume")], }) .await .expect("append initial item"); first_store .persist_thread(thread_id) .await .expect("persist initial thread"); first_store .flush_thread(thread_id) .await .expect("flush initial thread"); let rollout_path = first_store .live_rollout_path(thread_id) .await .expect("load rollout path"); first_store .shutdown_thread(thread_id) .await .expect("shutdown initial writer"); let resumed_store = LocalThreadStore::new(config, /*state_db*/ None); resumed_store .resume_thread(ResumeThreadParams { thread_id, rollout_path: None, history: None, include_archived: true, metadata: thread_metadata(), event_persistence_mode: ThreadEventPersistenceMode::Limited, }) .await .expect("resume live thread"); resumed_store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("after resume")], }) .await .expect("append resumed item"); resumed_store .flush_thread(thread_id) .await .expect("flush resumed thread"); assert_rollout_contains_message(rollout_path.as_path(), "before resume").await; assert_rollout_contains_message(rollout_path.as_path(), "after resume").await; } #[tokio::test] async fn create_thread_rejects_duplicate_live_writer() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let thread_id = ThreadId::default(); store .create_thread(create_thread_params(thread_id)) .await .expect("create live thread"); let err = store .create_thread(create_thread_params(thread_id)) .await .expect_err("duplicate live writer should fail"); assert!(matches!(err, ThreadStoreError::InvalidRequest { .. })); assert!(err.to_string().contains("already has a live local writer")); } #[tokio::test] async fn resume_thread_rejects_duplicate_live_writer() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let thread_id = ThreadId::default(); store .create_thread(create_thread_params(thread_id)) .await .expect("create live thread"); let rollout_path = store .live_rollout_path(thread_id) .await .expect("live rollout path"); let err = store .resume_thread(ResumeThreadParams { thread_id, rollout_path: Some(rollout_path), history: None, include_archived: true, metadata: thread_metadata(), event_persistence_mode: ThreadEventPersistenceMode::Limited, }) .await .expect_err("duplicate live resume should fail"); assert!(matches!(err, ThreadStoreError::InvalidRequest { .. })); assert!(err.to_string().contains("already has a live local writer")); } #[tokio::test] async fn resume_thread_rejects_missing_cwd() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let uuid = uuid::Uuid::from_u128(407); let thread_id = ThreadId::from_string(&uuid.to_string()).expect("valid thread id"); let rollout_path = write_session_file(home.path(), "2025-01-04T11-30-00", uuid).expect("session file"); let err = store .resume_thread(ResumeThreadParams { thread_id, rollout_path: Some(rollout_path), history: None, include_archived: true, metadata: ThreadPersistenceMetadata { cwd: None, model_provider: "test-provider".to_string(), memory_mode: ThreadMemoryMode::Enabled, }, event_persistence_mode: ThreadEventPersistenceMode::Limited, }) .await .expect_err("missing cwd should fail"); assert!(matches!(err, ThreadStoreError::InvalidRequest { .. })); assert!(err.to_string().contains("requires a cwd")); } #[tokio::test] async fn load_history_uses_live_writer_rollout_path() { let home = TempDir::new().expect("temp dir"); let external_home = TempDir::new().expect("external temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let uuid = uuid::Uuid::from_u128(404); let thread_id = ThreadId::from_string(&uuid.to_string()).expect("valid thread id"); let rollout_path = write_session_file(external_home.path(), "2025-01-04T10-00-00", uuid) .expect("external session file"); store .resume_thread(ResumeThreadParams { thread_id, rollout_path: Some(rollout_path), history: None, include_archived: true, metadata: thread_metadata(), event_persistence_mode: ThreadEventPersistenceMode::Limited, }) .await .expect("resume live thread"); store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("external history item")], }) .await .expect("append live item"); store .flush_thread(thread_id) .await .expect("flush live thread"); let history = store .load_history(LoadThreadHistoryParams { thread_id, include_archived: false, }) .await .expect("load external live history"); assert!(history.items.iter().any(|item| { matches!( item, RolloutItem::EventMsg(EventMsg::UserMessage(event)) if event.message == "external history item" ) })); } #[tokio::test] async fn read_thread_uses_live_writer_rollout_path_for_external_resume() { let home = TempDir::new().expect("temp dir"); let external_home = TempDir::new().expect("external temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let uuid = uuid::Uuid::from_u128(406); let thread_id = ThreadId::from_string(&uuid.to_string()).expect("valid thread id"); let rollout_path = write_session_file(external_home.path(), "2025-01-04T11-00-00", uuid) .expect("external session file"); store .resume_thread(ResumeThreadParams { thread_id, rollout_path: Some(rollout_path.clone()), history: None, include_archived: true, metadata: thread_metadata(), event_persistence_mode: ThreadEventPersistenceMode::Limited, }) .await .expect("resume live thread"); let thread = store .read_thread(ReadThreadParams { thread_id, include_archived: false, include_history: true, }) .await .expect("read external live thread"); assert_eq!(thread.rollout_path, Some(rollout_path)); assert!(thread.history.expect("history").items.iter().any(|item| { matches!( item, RolloutItem::EventMsg(EventMsg::UserMessage(event)) if event.message == "Hello from user" ) })); } #[tokio::test] async fn load_history_uses_live_writer_rollout_path_for_archived_source() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let uuid = uuid::Uuid::from_u128(405); let thread_id = ThreadId::from_string(&uuid.to_string()).expect("valid thread id"); let rollout_path = write_archived_session_file(home.path(), "2025-01-04T10-30-00", uuid) .expect("archived session file"); store .resume_thread(ResumeThreadParams { thread_id, rollout_path: Some(rollout_path), history: None, include_archived: true, metadata: thread_metadata(), event_persistence_mode: ThreadEventPersistenceMode::Limited, }) .await .expect("resume live archived thread"); store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("archived live history item")], }) .await .expect("append live item"); store .flush_thread(thread_id) .await .expect("flush live thread"); let err = store .read_thread(ReadThreadParams { thread_id, include_archived: false, include_history: false, }) .await .expect_err("active-only read should reject archived live thread"); assert!(matches!(err, ThreadStoreError::InvalidRequest { .. })); let err = store .load_history(LoadThreadHistoryParams { thread_id, include_archived: false, }) .await .expect_err("active-only history should reject archived live thread"); assert!(matches!(err, ThreadStoreError::InvalidRequest { .. })); assert!(err.to_string().contains("archived")); let history = store .load_history(LoadThreadHistoryParams { thread_id, include_archived: true, }) .await .expect("load archived live history"); assert!(history.items.iter().any(|item| { matches!( item, RolloutItem::EventMsg(EventMsg::UserMessage(event)) if event.message == "archived live history item" ) })); } #[tokio::test] async fn read_thread_by_rollout_path_includes_history() { let home = TempDir::new().expect("temp dir"); let store = LocalThreadStore::new(test_config(home.path()), /*state_db*/ None); let thread_id = ThreadId::default(); store .create_thread(create_thread_params(thread_id)) .await .expect("create thread"); store .append_items(AppendThreadItemsParams { thread_id, items: vec![user_message_item("path read")], }) .await .expect("append item"); store.flush_thread(thread_id).await.expect("flush thread"); let rollout_path = store .live_rollout_path(thread_id) .await .expect("load rollout path"); let thread = store .read_thread_by_rollout_path( rollout_path, /*include_archived*/ true, /*include_history*/ true, ) .await .expect("read thread by rollout path"); assert_eq!(thread.thread_id, thread_id); assert_eq!( thread .history .expect("history") .items .into_iter() .filter(|item| matches!(item, RolloutItem::EventMsg(EventMsg::UserMessage(_)))) .count(), 1 ); } fn create_thread_params(thread_id: ThreadId) -> CreateThreadParams { CreateThreadParams { thread_id, forked_from_id: None, parent_thread_id: None, source: SessionSource::Exec, thread_source: None, base_instructions: BaseInstructions::default(), dynamic_tools: Vec::new(), metadata: thread_metadata(), event_persistence_mode: ThreadEventPersistenceMode::Limited, } } fn thread_metadata() -> ThreadPersistenceMetadata { ThreadPersistenceMetadata { cwd: Some(std::env::current_dir().expect("cwd")), model_provider: "test-provider".to_string(), memory_mode: ThreadMemoryMode::Enabled, } } fn user_message_item(message: &str) -> RolloutItem { RolloutItem::EventMsg(EventMsg::UserMessage(UserMessageEvent { client_id: None, message: message.to_string(), images: None, local_images: Vec::new(), text_elements: Vec::new(), ..Default::default() })) } async fn assert_rollout_contains_message(path: &std::path::Path, expected: &str) { let (items, _, _) = RolloutRecorder::load_rollout_items(path) .await .expect("load rollout items"); assert!(items.iter().any(|item| { matches!( item, RolloutItem::EventMsg(EventMsg::UserMessage(event)) if event.message == expected ) })); } }