3066 Commits

• feat: support proxy for ws connection (#9719)

  reapply websocket changes without changing tls lib.

  Anton Panasenko · 2026-01-22 15:23:15 -08:00
  e117a3ff33
• Fix typo in experimental_prompt.md (#9716)

  Simple typo fix in the first sentence of the experimental_prompt.md
  instructions file.

  iudi · 2026-01-22 14:07:14 -08:00
  afd63e8bae
• feat: fix formatting of codex features list (#9715)

  The formatting of `codex features list` made it hard to follow. This PR
  introduces column width math to make things nice.
  
  Maybe slightly hard to machine-parse (since not a simple `\t`), but we
  should introduce a `--json` option if that's really important.
  
  You can see the before/after in the screenshot:
  
  <img width="1119" height="932" alt="image"
  src="https://github.com/user-attachments/assets/c99dce85-899a-4a2d-b4af-003938f5e1df"
  />

  Michael Bolin · 2026-01-22 13:02:41 -08:00
  5d963ee5d9
• feat(app-server): support archived threads in thread/list (#9571)
  Owen Lin · 2026-01-22 12:22:36 -08:00
  733cb68496
• feat(app-server): thread/read API (#9569)
  Owen Lin · 2026-01-22 12:22:01 -08:00
  80240b3b67
• feat(core) update Personality on turn (#9644)

  ## Summary
  Support updating Personality mid-Thread via UserTurn/OverwriteTurn. This
  is explicitly unused by the clients so far, to simplify PRs - app-server
  and tui implementations will be follow-ups.
  
  ## Testing
  - [x] added integration tests

  Dylan Hurd · 2026-01-22 12:04:23 -08:00
  8b3521ee77
• Modes label below textarea (#9645)

  # Summary
  - Add a collaboration mode indicator rendered at the bottom-right of the
  TUI composer footer.
  - Style modes per design (Plan in #D72EE1, Execute matching dim context
  style, Pair Programming using the same cyan as text elements).
  - Add shared “(shift+tab to cycle)” hint text for all mode labels and
  align the indicator with the left footer margin.
  
  NOTE: currently this is hidden if the Collaboration Modes feature flag
  is disabled, or in Custom mode. Maybe we should show it in Custom mode
  too? I'll leave that out of this PR though
  
  # UI
  - Mode indicator appears below the textarea, bottom-right of the footer
  line.
  - Includes “(shift+tab to cycle)” and keeps right padding aligned to the
  left footer indent.
  
  <img width="983" height="200" alt="Screenshot 2026-01-21 at 7 17 54 PM"
  src="https://github.com/user-attachments/assets/d1c5e4ed-7d7b-4f6c-9e71-bc3cf6400e0e"
  />
  
  <img width="980" height="200" alt="Screenshot 2026-01-21 at 7 18 53 PM"
  src="https://github.com/user-attachments/assets/d22ff0da-a406-4930-85c5-affb2234e84b"
  />
  
  <img width="979" height="201" alt="Screenshot 2026-01-21 at 7 19 12 PM"
  src="https://github.com/user-attachments/assets/862cb17f-0495-46fa-9b01-a4a9f29b52d5"
  />

  charley-oai · 2026-01-22 17:31:11 +00:00
  4210fb9e6c
• Support end_turn flag (#9698)

  Experimental flag that signals the end of the turn.

  pakrym-oai · 2026-01-22 17:27:48 +00:00
  b511c38ddb
• Revert "feat: support proxy for ws connection" (#9693)

  Reverts openai/codex#9409

  pakrym-oai · 2026-01-22 15:57:18 +00:00
  4d48d4e0c2
• Chore: add cmd related info to exec approval request (#9659)

  ### Summary
  We now rely purely on `item/commandExecution/requestApproval` item to
  render pending approval in VSCE and app. With v2 approach, it does not
  include the actual cmd that it is attempting and therefore we can only
  use `proposedExecpolicyAmendment` to render which can be incomplete.
  
  ### Reproduce
  * Add `prefix_rule(pattern=["echo"], decision="prompt")` to your
  `~/.codex/rules.default.rules`.
  * Ask to `Run  echo "approval-test" please` in VSCE or app. 
  * The pending approval protal does show up but with no content
  
  #### Example screenshot
  <img width="3434" height="3648" alt="Screenshot 2026-01-21 at 8 23
  25 PM"
  src="https://github.com/user-attachments/assets/75644837-21f1-40f8-8b02-858d361ff817"
  />
  
  #### Sample output
  ```
    {"method":"item/commandExecution/requestApproval","id":0,"params":{
      "threadId":"019be439-5a90-7600-a7ea-2d2dcc50302a",
      "turnId":"0",
      "itemId":"call_usgnQ4qEX5U9roNdjT7fPzhb",
      "reason":"`/bin/zsh -lc 'echo \"testing\"'` requires approval by policy",
      "proposedExecpolicyAmendment":null
    }}
  
  ```
  
  ### Fix
  Inlude `command` string, `cwd` and `command_actions` in
  `CommandExecutionRequestApprovalParams` so that consumers can display
  the correct command instead of relying on exec policy output.

  Shijie Rao · 2026-01-21 23:58:53 -08:00
  a4cb97ba5a
• Fix: Lower log level for closed-channel send (#9653)

  ## What?
  - Downgrade the closed-channel send error log to debug in
  `codex-rs/core/src/codex.rs`.
  
  ## Why?
  - `async_channel::Sender::send` only fails when the channel is closed,
  so the current error-level log is noisy during normal shutdown. See
  issue #9652.
  
  ## How?
  - Replace the error log with a debug log on send failure.
  
  ## Tests
  - `just fmt`
  - `just fix -p codex-core`
  - `cargo test -p codex-core`

  Kbediako · 2026-01-21 22:09:58 -08:00
  079fd2adb9
• feat(tui) /permissions flow (#9561)

  ## Summary
  Adds the `/permissions` command, with a (usually) shorter set of
  permissions. `/approvals` still exists, for backwards compatibility.
  
  <img width="863" height="309" alt="Screenshot 2026-01-20 at 4 12 51 PM"
  src="https://github.com/user-attachments/assets/c49b5ba5-bc47-46dd-9067-e1a5670328fe"
  />
  
  
  ## Testing
  - [x] updated unit tests
  - [x] Tested locally

  Dylan Hurd · 2026-01-21 21:38:46 -08:00
  038b78c915
• Add tui.experimental_mode setting (#9656)

  To simplify testing

  pakrym-oai · 2026-01-22 05:27:57 +00:00
  836f0343a3
• Add UI for skill enable/disable. (#9627)

  "/skill" will now allow you to enable/disable skills:
  <img width="658" height="199" alt="image"
  src="https://github.com/user-attachments/assets/bf8994c8-d6c1-462f-8bbb-f1ee9241caa4"
  />

  xl-openai · 2026-01-21 18:21:12 -08:00
  577ba3a4ca
• feat(core) ModelInfo.model_instructions_template (#9597)

  ## Summary
  #9555 is the start of a rename, so I'm starting to standardize here.
  Sets up `model_instructions` templating with a strongly-typed object for
  injecting a personality block into the model instructions.
  
  ## Testing
  - [x] Added tests
  - [x] Ran locally

  Dylan Hurd · 2026-01-21 18:11:18 -08:00
  96a72828be
• feat(tui): retire the tui2 experiment (#9640)

  ## Summary
  - Retire the experimental TUI2 implementation and its feature flag.
  - Remove TUI2-only config/schema/docs so the CLI stays on the
  terminal-native path.
  - Keep docs aligned with the legacy TUI while we focus on redraw-based
  improvements.
  
  ## Customer impact
  - Retires the TUI2 experiment and keeps Codex on the proven
  terminal-native UI while we invest in redraw-based improvements to the
  existing experience.
  
  ## Migration / compatibility
  - If you previously set tui2-related options in config.toml, they are
  now ignored and Codex continues using the existing terminal-native TUI
  (no action required).
  
  ## Context
  - What worked: a transcript-owned viewport delivered excellent resize
  rewrap and high-fidelity copy (especially for code).
  - Why stop: making that experience feel fully native across the
  environment matrix (terminal emulator, OS, input modality, multiplexer,
  font/theme, alt-screen behavior) creates a combinatorial explosion of
  edge cases.
  - What next: we are focusing on redraw-based improvements to the
  existing terminal-native TUI so scrolling, selection, and copy remain
  native while resize/redraw correctness improves.
  
  ## Testing
  - just write-config-schema
  - just fmt
  - cargo clippy --fix --all-features --tests --allow-dirty --allow-no-vcs
  -p codex-core
  - cargo clippy --fix --all-features --tests --allow-dirty --allow-no-vcs
  -p codex-cli
  - cargo check
  - cargo test -p codex-core
  - cargo test -p codex-cli

  Josh McKinney · 2026-01-22 01:02:29 +00:00
  a489b64cb5
• Reduce burst testing flake (#9549)

  ## Summary
  
  - make paste-burst tests deterministic by injecting explicit timestamps
  instead of relying on wall clock timing
  - add time-aware helpers for input/submission paths so tests can drive
  the burst heuristic precisely
  - update burst-related tests to flush using computed timeouts while
  preserving behavior assertions
  - increase timeout slack in
  shell_tools_start_before_response_completed_when_stream_delayed to
  reduce flakiness

  charley-oai · 2026-01-21 16:42:31 -08:00
  41e38856f6
• feat: publish config schema on release (#9572)

  Follow up to #8956; publish schema on new release to stable URL.
  
  Also canonicalize schema (sort keys) when writing. This avoids reliance
  on default `schema_rs` behavior and makes the schema easier to read.

  sayan-oai · 2026-01-21 16:24:14 -08:00
  c285b88980
• fix(tui) turn timing incremental (#9599)

  ## Summary
  When we send multiple assistant messages, reset the timer so "Worked for
  2m 36s" is the time since the last time we showed the message, rather
  than an ever-increasing number.
  
  We could instead change the copy so it's more clearly a running counter.
  
  ## Testing
  - [x] ran locally
  
  <img width="903" height="732" alt="Screenshot 2026-01-21 at 1 42 51 AM"
  src="https://github.com/user-attachments/assets/bb4d827b-3a0e-48ba-bd6a-d8cd65d8e892"
  />

  Dylan Hurd · 2026-01-21 15:59:56 -08:00
  f1240ff4fe
• feat: better sorting of shell commands (#9629)

  This PR changes the way we sort slash command by going in this order:
  1. Exact match
  2. Prefix
  3. Fuzzy
  
  As a result, we you type `/ps` the default command is not `/approvals`

  jif-oai · 2026-01-21 23:03:01 +00:00
  5dad1b956e
• Add layered config.toml support to app server (#9510)

  This PR adds support for chained (layered) config.toml file merging for
  clients that use the app server interface. This feature already exists
  for the TUI, but it does not work for GUI clients.
  
  It does the following:
  * Changes code paths for new thread, resume thread, and fork thread to
  use the effective config based on the cwd.
  * Updates the `config/read` API to accept an optional `cwd` parameter.
  If specified, the API returns the effective config based on that cwd
  path. Also optionally includes all layers including project config
  files. If cwd is not specified, the API falls back on its older behavior
  where it considers only the global (non-project) config files when
  computing the effective config.
  
  The changes in codex_message_processor.rs look deceptively large. They
  mostly just involve moving existing blocks of code to a later point in
  some functions so it can use the cwd to calculate the config.
  
  This PR builds upon #9509 and should be reviewed and merged after that
  PR.
  
  Tested:
  * Verified change with (dependent, as-yet-uncommitted) changes to IDE
  Extension and confirmed correct behavior
  
  The full fix requires additional changes in the IDE Extension code base,
  but they depend on this PR.

  Eric Traut · 2026-01-21 14:21:48 -08:00
  2ca9a56528
• Add collaboration_mode to TurnContextItem (#9583)

  ## Summary
  - add optional `collaboration_mode` to `TurnContextItem` in rollouts
  - persist the current collaboration mode when recording turn context
  (sampling + compaction)
  
  ## Rationale
  We already persist turn context data for resume logic. Capturing
  collaboration mode in the rollout gives us the mode context for each
  turn, enabling follow‑up work to diff mode instructions correctly on
  resume.
  
  ## Changes
  - protocol: add optional `collaboration_mode` field to `TurnContextItem`
  - core: persist collaboration mode alongside other turn context settings
  in rollouts

  charley-oai · 2026-01-21 14:14:21 -08:00
  fe641f759f
• Chore: update plan mode output in prompt (#9592)

  ### Summary
  * Update plan prompt output
  * Update requestUserInput response to be a single key value pair
  `answer: String`.

  Shijie Rao · 2026-01-21 14:12:18 -08:00
  3fcb40245e
• Add websockets logging (#9633)

  To help with debugging.

  pakrym-oai · 2026-01-21 21:35:38 +00:00
  f2e1ad59bc
• forgot to add some windows sandbox nux events. (#9624)
  iceweasel-oai · 2026-01-21 13:24:09 -08:00
  7a9c9b8636
• Update skills/list protocol readme (#9623)

  Updates readme example for `skills/list` to reflect latest response
  spec.

  Gav Verma · 2026-01-21 12:51:51 -08:00
  2e06d61339
• docs: fix outdated MCP subcommands documentation (#9622)
  Tien Nguyen · 2026-01-21 11:17:37 -08:00
  68b8381723
• define/emit some metrics for windows sandbox setup (#9573)

  This should give us visibility into how users are using the elevated
  sandbox nux flow, and the timing of the elevated setup.

  iceweasel-oai · 2026-01-21 11:07:26 -08:00
  f81dd128a2
• fix: Fix tilde expansion to avoid absolute-path escape (#9621)

  ### Motivation
  - Prevent inputs like `~//` or `~///etc` from expanding to arbitrary
  absolute paths (e.g. `/`) because `Path::join` discards the left side
  when the right side is absolute, which could allow config values to
  escape `HOME` and broaden writable roots.
  
  ### Description
  - In `codex-rs/utils/absolute-path/src/lib.rs` update
  `maybe_expand_home_directory` to trim leading separators from the suffix
  and return `home` when the remainder is empty so tilde expansion stays
  rooted under `HOME`.
  - Add a non-Windows unit test
  `home_directory_double_slash_on_non_windows_is_expanded_in_deserialization`
  that validates `"~//code"` expands to `home.join("code")`.
  
  ### Testing
  - Ran `just fmt` successfully.
  - Ran `just fix -p codex-utils-absolute-path` (Clippy autofix)
  successfully.
  - Ran `cargo test -p codex-utils-absolute-path` and all tests passed.
  
  ------
  [Codex
  Task](https://chatgpt.com/codex/tasks/task_i_697007481cac832dbeb1ee144d1e4cbe)

  Tiffany Citra · 2026-01-21 10:43:10 -08:00
  8179312ff5
• chore: defensive shell snapshot (#9609)

  This PR adds 2 defensive mechanisms for shell snapshotting:
  * Filter out invalid env variables (containing `-` for example) without
  dropping the whole snapshot
  * Validate the snapshot before considering it as valid by running a mock
  command with a shell snapshot

  jif-oai · 2026-01-21 18:41:58 +00:00
  3355adad1d
• nit: ui on interruption (#9606)
  jif-oai · 2026-01-21 14:09:15 +00:00
  338f2d634b
• nit: better collab tui (#9551)

  <img width="478" height="304" alt="Screenshot 2026-01-21 at 11 53 50"
  src="https://github.com/user-attachments/assets/e2ef70de-2fff-44e0-a574-059177966ed2"
  />

  jif-oai · 2026-01-21 11:53:58 +00:00
  f1b6a43907
• fix: nit tui on terminal interactions (#9602)
  jif-oai · 2026-01-21 11:30:34 +00:00
  13358fa131
• feat: async shell snapshot (#9600)
  jif-oai · 2026-01-21 10:41:13 +00:00
  b75024c465
• Added "codex." prefix to "conversation.turn.count" metric name (#9594)

  All other metrics names start with "codex.", so I presume this was an
  unintended omission.

  Eric Traut · 2026-01-21 10:00:47 +00:00
  16b9380e99
• feat: display raw command on user shell (#9598)
  jif-oai · 2026-01-21 09:44:38 +00:00
  a22a61e678
• feat: max threads config (#9483)

  # External (non-OpenAI) Pull Request Requirements
  
  Before opening this Pull Request, please read the dedicated
  "Contributing" markdown file or your PR may be closed:
  https://github.com/openai/codex/blob/main/docs/contributing.md
  
  If your PR conforms to our contribution guidelines, replace this text
  with a detailed and high quality description of your changes.
  
  Include a link to a bug report or enhancement request.

  jif-oai · 2026-01-21 09:39:11 +00:00
  f1c961d5f7
• fix going up and down on questions after writing notes (#9596)
  Ahmed Ibrahim · 2026-01-21 09:37:37 +00:00
  6e9a31def1
• Add request-user-input overlay (#9585)

  - Add request-user-input overlay and routing in the TUI

  Ahmed Ibrahim · 2026-01-21 00:19:35 -08:00
  5f55ed666b
• Feature to auto-enable websockets transport (#9578)
  pakrym-oai · 2026-01-20 20:32:06 -08:00
  527b7b4c02
• feat: add skill injected counter metric (#9575)
  alexsong-oai · 2026-01-20 19:05:37 -08:00
  fabc2bcc32
• Reject ask user question tool in Execute and Custom (#9560)

  ## Summary
  - Keep `request_user_input` in the tool list but reject it at runtime in
  Execute/Custom modes with a clear model-facing error.
  - Add a session accessor for current collaboration mode and enforce the
  gate in the request_user_input handler.
  - Update core/app-server tests to use Plan mode for success and add
  Execute/Custom rejection coverage.

  charley-oai · 2026-01-20 18:32:17 -08:00
  0523a259c8
• Prompt Expansion: Preserve Text Elements (#9518)

  Summary
  - Preserve `text_elements` through custom prompt argument parsing and
  expansion (named and numeric placeholders).
  - Translate text element ranges through Shlex parsing using sentinel
  substitution, and rehydrate text + element ranges per arg.
  - Drop image attachments when their placeholder does not survive prompt
  expansion, keeping attachments consistent with rendered elements.
  - Mirror changes in TUI2 and expand tests for prompt parsing/expansion
  edge cases.
  
  Tests
  - placeholders with spaces as single tokens (positional + key=value,
  quoted + unquoted),
    - prompt expansion with image placeholders,
    - large paste + image arg combinations,
    - unused image arg dropped after expansion.

  charley-oai · 2026-01-20 18:30:20 -08:00
  531748a080
• feat: rename experimental_instructions_file to model_instructions_file (#9555)

  A user who has `experimental_instructions_file` set will now see this:
  
  <img width="888" height="660" alt="image"
  src="https://github.com/user-attachments/assets/51c98312-eb9b-4881-81f1-bea6677e158d"
  />
  
  And a `codex exec` would include this warning:
  
  <img width="888" height="660" alt="image"
  src="https://github.com/user-attachments/assets/a89f62be-1edf-4593-a75e-e0b4a762ed7d"
  />

  Michael Bolin · 2026-01-21 02:25:08 +00:00
  f4d55319d1
• Show session header before configuration (#9568)

  We were skipping if we know the model. We shouldn't

  Ahmed Ibrahim · 2026-01-21 02:13:54 +00:00
  3a0eeb8edf
• feat(tui2): add /experimental menu (#9562)

  Adds an /experimental slash command and bottom-pane view to toggle beta
  features.
  
  Persists feature-flag updates to config.toml, matching tui behavior.

  Josh McKinney · 2026-01-21 00:20:57 +00:00
  0a26675155
• [codex-tui] exit when terminal is dumb (#9293)

  Using terminal with TERM=dumb specifically mean that TUIs and the like
  don't work. Ensure that codex doesn't run in these environments and exit
  with odd errors like crossterm's "Error: The cursor position could not
  be read within a normal duration"
  
  ---------
  
  Co-authored-by: Josh McKinney <joshka@openai.com>

  Jeff Mickey · 2026-01-20 16:17:38 -08:00
  c14e6813fb
• fix(core): require approval for force delete on Windows (#8590)

  ### What
  Implemented detection for dangerous "force delete" commands on Windows
  to trigger the user approval prompt when `--ask-for-approval on-request`
  is set. This aligns Windows behavior with the existing safety checks for
  `rm -rf` on Linux.
  
  ### Why
  Fixes #8567 - a critical safety gap where destructive Windows commands
  could bypass the approval prompt. This prevents accidental data loss by
  ensuring the user explicitly confirms operations that would otherwise
  suppress the OS's native confirmation prompts.
  
  ### How
  Updated the Windows command safety module to identify and flag the
  following patterns as dangerous:
  *   **PowerShell**:
  * Detects `Remove-Item` (and aliases `rm`, `ri`, `del`, `erase`, `rd`,
  `rmdir`) when used with the `-Force` flag.
  * Uses token-based analysis to robustly detect these patterns even
  inside script blocks (`{...}`), sub-expression `(...)`, or
  semicolon-chained sequences.
  *   **CMD**:
      *   Detects `del /f` (force delete files).
      *   Detects `rd /s /q` (recursive delete quiet).
  * **Command Chaining**: Added support for analyzing chained commands
  (using `&`, `&&`, `|`, `||`) to separate and check individual commands
  (e.g., catching `del /f` hidden in `echo log & del /f data`).
  
  ### Testing
  Added comprehensive unit tests covering:
  * **PowerShell**: `Remove-Item -Path 'test' -Recurse -Force` (Exact
  reproduction case).
  * **Complex Syntax**: Verified detection inside blocks (e.g., `if
  ($true) { rm -Force }`) and with trailing punctuation.
  *   **CMD**:
      *   `del /f` (Flagged).
      *   `rd /s /q` (Flagged).
      *   Chained commands: `echo hi & del /f file` (Flagged).
  *   **False Positives**:
      *   `rd /s` (Not flagged - relies on native prompt).
      *   Standard deletions without force flags.
  
  Verified with `cargo test` and `cargo clippy`.
  
  ---------
  
  Co-authored-by: Eric Traut <etraut@openai.com>

  HDCode · 2026-01-20 15:25:27 -08:00
  80f80181c2
• queue only when task is working (#9558)
  Ahmed Ibrahim · 2026-01-20 15:24:45 -08:00
  fbd8afad81
• Enable remote models (#9554)
  Ahmed Ibrahim · 2026-01-20 23:17:22 +00:00
  de4980d2ac