20 Commits

• Add js_repl host helpers and exec end events (#10672)

  ## Summary
  
  This PR adds host-integrated helper APIs for `js_repl` and updates model
  guidance so the agent can use them reliably.
  
  ### What’s included
  
  - Add `codex.tool(name, args?)` in the JS kernel so `js_repl` can call
  normal Codex tools.
  - Keep persistent JS state and scratch-path helpers available:
    - `codex.state`
    - `codex.tmpDir`
  - Wire `js_repl` tool calls through the standard tool router path.
  - Add/align `js_repl` execution completion/end event behavior with
  existing tool logging patterns.
  - Update dynamic prompt injection (`project_doc`) to document:
    - how to call `codex.tool(...)`
    - raw output behavior
  - image flow via `view_image` (`codex.tmpDir` +
  `codex.tool("view_image", ...)`)
  - stdio safety guidance (`console.log` / `codex.tool`, avoid direct
  `process.std*`)
  
  ## Why
  
  - Standardize JS-side tool usage on `codex.tool(...)`
  - Make `js_repl` behavior more consistent with existing tool execution
  and event/logging patterns.
  - Give the model enough runtime guidance to use `js_repl` safely and
  effectively.
  
  ## Testing
  
  - Added/updated unit and runtime tests for:
    - `codex.tool` calls from `js_repl` (including shell/MCP paths)
    - image handoff flow via `view_image`
    - prompt-injection text for `js_repl` guidance
    - execution/end event behavior and related regression coverage
  
  
  
  
  #### [git stack](https://github.com/magus/git-stack-cli)
  - ✅ `1` https://github.com/openai/codex/pull/10674
  - 👉 `2` https://github.com/openai/codex/pull/10672
  - ⏳ `3` https://github.com/openai/codex/pull/10671
  - ⏳ `4` https://github.com/openai/codex/pull/10673
  - ⏳ `5` https://github.com/openai/codex/pull/10670

  Curtis 'Fjord' Hawthorne · 2026-02-12 12:10:25 -08:00
  466be55abc
• Prefer websocket transport when model opts in (#11386)

  Summary
  - add a `prefer_websockets` field to `ModelInfo`, defaulting to `false`
  in all fixtures and constructors
  - wire the new flag into websocket selection so models that opt in
  always use websocket transport even when the feature gate is off
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-02-10 18:50:48 -08:00
  c68999ee6d
• Always expose view_image and return unsupported image-input error (#11336)

  - Keep `view_image` in the advertised tool list for all models.
  - Return a clear error when the current model does not support image
  inputs, and cover it with a unit test.

  Ahmed Ibrahim · 2026-02-10 11:25:12 -08:00
  6e96e4837e
• fix: make sure the shell exists (#10222)
  jif-oai · 2026-01-30 14:18:31 +01:00
  09d25e91e9
• feat(core) update Personality on turn (#9644)

  ## Summary
  Support updating Personality mid-Thread via UserTurn/OverwriteTurn. This
  is explicitly unused by the clients so far, to simplify PRs - app-server
  and tui implementations will be follow-ups.
  
  ## Testing
  - [x] added integration tests

  Dylan Hurd · 2026-01-22 12:04:23 -08:00
  8b3521ee77
• Add collaboration_mode override to turns (#9408)
  Ahmed Ibrahim · 2026-01-16 21:51:25 -08:00
  146d54cede
• Add text element metadata to types (#9235)

  Initial type tweaking PR to make the diff of
  https://github.com/openai/codex/pull/9116 smaller
  
  This should not change any behavior, just adds some fields to types

  charley-oai · 2026-01-14 16:41:50 -08:00
  4a9c2bcc5a
• Label attached images so agent can understand in-message labels (#8950)

  Agent wouldn't "see" attached images and would instead try to use the
  view_file tool:
  <img width="1516" height="504" alt="image"
  src="https://github.com/user-attachments/assets/68a705bb-f962-4fc1-9087-e932a6859b12"
  />
  
  In this PR, we wrap image content items in XML tags with the name of
  each image (now just a numbered name like `[Image #1]`), so that the
  model can understand inline image references (based on name). We also
  put the image content items above the user message which the model seems
  to prefer (maybe it's more used to definitions being before references).
  
  We also tweak the view_file tool description which seemed to help a bit
  
  Results on a simple eval set of images:
  
  Before
  <img width="980" height="310" alt="image"
  src="https://github.com/user-attachments/assets/ba838651-2565-4684-a12e-81a36641bf86"
  />
  
  After
  <img width="918" height="322" alt="image"
  src="https://github.com/user-attachments/assets/10a81951-7ee6-415e-a27e-e7a3fd0aee6f"
  />
  
  ```json
  [
    {
      "id": "single_describe",
      "prompt": "Describe the attached image in one sentence.",
      "images": ["image_a.png"]
    },
    {
      "id": "single_color",
      "prompt": "What is the dominant color in the image? Answer with a single color word.",
      "images": ["image_b.png"]
    },
    {
      "id": "orientation_check",
      "prompt": "Is the image portrait or landscape? Answer in one sentence.",
      "images": ["image_c.png"]
    },
    {
      "id": "detail_request",
      "prompt": "Look closely at the image and call out any small details you notice.",
      "images": ["image_d.png"]
    },
    {
      "id": "two_images_compare",
      "prompt": "I attached two images. Are they the same or different? Briefly explain.",
      "images": ["image_a.png", "image_b.png"]
    },
    {
      "id": "two_images_captions",
      "prompt": "Provide a short caption for each image (Image 1, Image 2).",
      "images": ["image_c.png", "image_d.png"]
    },
    {
      "id": "multi_image_rank",
      "prompt": "Rank the attached images from most colorful to least colorful.",
      "images": ["image_a.png", "image_b.png", "image_c.png"]
    },
    {
      "id": "multi_image_choice",
      "prompt": "Which image looks more vibrant? Answer with 'Image 1' or 'Image 2'.",
      "images": ["image_b.png", "image_d.png"]
    }
  ]
  ```

  charley-oai · 2026-01-09 21:33:45 -08:00
  6709ad8975
• renaming: task to turn (#8963)
  jif-oai · 2026-01-09 17:31:17 +00:00
  1aed01e99f
• fix: increase timeout for wait_for_event() for Bazel (#8946)

  This seems to be necessary to get the Bazel builds on ARM Linux to go
  green on https://github.com/openai/codex/pull/8875.
  
  I don't feel great about timeout-whack-a-mole, but we're still learning
  here...

  Michael Bolin · 2026-01-08 15:37:46 -08:00
  bdfdebcfa1
• feat: retroactive image placeholder to prevent poisoning (#6774)

  If an image can't be read by the API, it will poison the entire history,
  preventing any new turn on the conversation.
  This detect such cases and replace the image by a placeholder

  jif-oai · 2025-12-03 11:35:56 +00:00
  51307eaf07
• tests: replace mount_sse_once_match with mount_sse_once for SSE mocking (#6640)
  pakrym-oai · 2025-11-13 18:04:05 -08:00
  6c384eb9c6
• Promote shared helpers for suite tests (#6460)

  ## Summary
  - add `TestCodex::submit_turn_with_policies` and extend the response
  helpers with reusable tool-call utilities
  - update the grep_files, read_file, list_dir, shell_serialization, and
  tools suites to rely on the shared helpers instead of local copies
  - make the list_dir helper return `anyhow::Result` so clippy no longer
  warns about `expect`
  
  ## Testing
  - `just fix -p codex-core`
  - `cargo test -p codex-core --test all
  suite::grep_files::grep_files_tool_collects_matches`
  - `cargo test -p codex-core
  suite::grep_files::grep_files_tool_collects_matches -- --ignored`
  (filter requests ignored tests so nothing runs, but the build stays
  clean)
  
  
  ------
  [Codex
  Task](https://chatgpt.com/codex/tasks/task_i_69112d53abac83219813cab4d7cb6446)

  Ahmed Ibrahim · 2025-11-13 17:12:10 -08:00
  2a6e9b20df
• verify mime type of images (#5888)

  solves: https://github.com/openai/codex/issues/5675
  
  Block non-image uploads in the view_image workflow. We now confirm the
  file’s MIME is image/* before building the data URL; otherwise we emit a
  “unsupported MIME type” error to the model. This stops the agent from
  sending application/json blobs that the Responses API rejects with 400s.
  
  <img width="409" height="556" alt="Screenshot 2025-10-28 at 1 15 10 PM"
  src="https://github.com/user-attachments/assets/a92199e8-2769-4b1d-8e33-92d9238c90fe"
  />

  zhao-oai · 2025-10-28 14:52:51 -07:00
  36113509f2
• feat: image resizing (#5446)

  Add image resizing on the client side to reduce load on the API

  jif-oai · 2025-10-27 16:58:10 +00:00
  aea7610c76
• Add ItemStarted/ItemCompleted events for UserInputItem (#5306)

  Adds a new ItemStarted event and delivers UserMessage as the first item
  type (more to come).
  
  
  Renames `InputItem` to `UserInput` considering we're using the `Item`
  suffix for actual items.

  pakrym-oai · 2025-10-20 13:34:44 -07:00
  9c903c4716
• Simplify request body assertions (#4845)

  We'll have a lot more test like these

  pakrym-oai · 2025-10-07 09:56:39 +01:00
  35a770e871
• Add helper for response created SSE events in tests (#4758)

  ## Summary
  - add a reusable `ev_response_created` helper that builds
  `response.created` SSE events for integration tests
  - update the exec and core integration suites to use the new helper
  instead of repeating manual JSON literals
  - keep the streaming fixtures consistent by relying on the shared helper
  in every touched test
  
  ## Testing
  - `just fmt`
  
  
  ------
  https://chatgpt.com/codex/tasks/task_i_68e1fe885bb883208aafffb94218da61

  pakrym-oai · 2025-10-05 21:11:43 +00:00
  aecbe0f333
• Use wait_for_event helpers in tests (#4753)

  ## Summary
  - replace manual event polling loops in several core test suites with
  the shared wait_for_event helpers
  - keep prior assertions intact by using closure captures for stateful
  expectations, including plan updates, patch lifecycles, and review flow
  checks
  - rely on wait_for_event_with_timeout where longer waits are required,
  simplifying timeout handling
  
  ## Testing
  - just fmt
  
  
  ------
  https://chatgpt.com/codex/tasks/task_i_68e1d58582d483208febadc5f90dd95e

  pakrym-oai · 2025-10-04 22:04:05 -07:00
  06853d94f0
• chore: refactor tool handling (#4510)

  # Tool System Refactor
  
  - Centralizes tool definitions and execution in `core/src/tools/*`:
  specs (`spec.rs`), handlers (`handlers/*`), router (`router.rs`),
  registry/dispatch (`registry.rs`), and shared context (`context.rs`).
  One registry now builds the model-visible tool list and binds handlers.
  - Router converts model responses to tool calls; Registry dispatches
  with consistent telemetry via `codex-rs/otel` and unified error
  handling. Function, Local Shell, MCP, and experimental `unified_exec`
  all flow through this path; legacy shell aliases still work.
  - Rationale: reduce per‑tool boilerplate, keep spec/handler in sync, and
  make adding tools predictable and testable.
  
  Example: `read_file`
  - Spec: `core/src/tools/spec.rs` (see `create_read_file_tool`,
  registered by `build_specs`).
  - Handler: `core/src/tools/handlers/read_file.rs` (absolute `file_path`,
  1‑indexed `offset`, `limit`, `L#: ` prefixes, safe truncation).
  - E2E test: `core/tests/suite/read_file.rs` validates the tool returns
  the requested lines.
  
  ## Next steps:
  - Decompose `handle_container_exec_with_params` 
  - Add parallel tool calls

  jif-oai · 2025-10-03 13:21:06 +01:00
  33d3ecbccc