codex

fix: parse git apply paths correctly (#8824 )

Fixes apply.rs path parsing so 
- quoted diff headers are tokenized and extracted correctly, 
- /dev/null headers are ignored before prefix stripping to avoid bogus
dev/null paths, and
- git apply output paths are unescaped from C-style quoting.

**Why**
This prevents potentially missed staging and misclassified paths when
applying or reverting patches, which could lead to incorrect behavior
for repos with spaces or escaped characters in filenames.

**Impact**
I checked and this is only used in the cloud tasks support and `codex
apply <task_id>` flow.

Thibault Sottiaux · 2026-01-07 13:00:31 +00:00

a59052341d

Fix: /undo destructively interacts with git staging (#8214 ) (#8303 )

Fixes #8214 by removing the '--staged' flag from the undo git restore
command. This ensures that while the working tree is reverted to the
snapshot state, the user's staged changes (index) are preserved,
preventing data loss. Also adds a regression test.

GalaxyDetective · 2025-12-19 10:07:41 -08:00

014235f533

feat: add config to disable warnings around ghost snapshot (#8178 )

jif-oai · 2025-12-17 18:50:22 +00:00

3d92b443b0

feat: ghost snapshot v2 (#8055 )

This PR updates ghost snapshotting to avoid capturing oversized
untracked artifacts while keeping undo safe. Snapshot creation now
builds a temporary index from `git status --porcelain=2 -z`, writes a
tree and detached commit without touching refs, and records any ignored
large files/dirs in the snapshot report. Undo uses that metadata to
preserve large local artifacts while still cleaning up new transient
files.

jif-oai · 2025-12-15 11:14:36 +01:00

0d9801d448

feat: config ghost commits (#7873 )

jif-oai · 2025-12-15 09:13:06 +01:00

4274e6189a

feat: use remote branch for review is local trails (#7813 )

jif-oai · 2025-12-10 17:04:52 +00:00

97b90094cd

feat: add pycache to excluded directories (#7545 )

jif-oai · 2025-12-03 20:06:55 +00:00

9e6c2c1e64

Fix: track only untracked paths in ghost snapshots (#7470 )

# Ghost snapshot ignores

This PR should close #7067, #7395, #7405.

Prior to this change the ghost snapshot task ran `git status
--ignored=matching` so the report picked up literally every ignored
file. When a directory only contained entries matched by patterns such
as `dozens/*.txt`, `/test123/generated/*.html`, or `/wp-includes/*`, Git
still enumerated them and the large-untracked-dir detection treated the
parent directory as “large,” even though everything inside was
intentionally ignored.

By removing `--ignored=matching` we only capture true untracked paths
now, so those patterns stay out of the snapshot report and no longer
trigger the “large untracked directories” warning.

---------

Signed-off-by: lionelchg <lionel.cheng@hotmail.fr>
Co-authored-by: lionelchg <lionel.cheng@hotmail.fr>

lionel-oai · 2025-12-02 19:42:33 +01:00

349734e38d

feat: ignore standard directories (#7483 )

jif-oai · 2025-12-02 18:42:07 +00:00

2222cab9ea

feat: warning large commits (#6838 )

jif-oai · 2025-11-19 10:22:10 +00:00

956d3bfac6

feat: git branch tooling (#6831 )

jif-oai · 2025-11-18 15:26:09 +00:00

fc55fd7a81

[app-server] remove serde(skip_serializing_if = "Option::is_none") annotations (#5939 )

We had this annotation everywhere in app-server APIs which made it so
that fields get serialized as `field?: T`, meaning if the field as
`None` we would omit the field in the payload. Removing this annotation
changes it so that we return `field: T | null` instead, which makes
codex app-server's API more aligned with the convention of public OpenAI
APIs like Responses.

Separately, remove the `#[ts(optional_fields = nullable)]` annotations
that were recently added which made all the TS types become `field?: T |
null` which is not great since clients need to handle undefined and
null.

I think generally it'll be best to have optional types be either:
- `field: T | null` (preferred, aligned with public OpenAI APIs)
- `field?: T` where we have to, such as types generated from the MCP
schema:
https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-06-18/schema.ts
(see changes to `mcp-types/`)

I updated @etraut-openai's unit test to check that all generated TS
types are one or the other, not both (so will error if we have a type
that has `field?: T | null`). I don't think there's currently a good use
case for that - but we can always revisit.

Owen Lin · 2025-10-30 18:18:53 +00:00

89c00611c2

Add missing "nullable" macro to protocol structs that contain optional fields (#5901 )

This PR addresses a current hole in the TypeScript code generation for
the API server protocol. Fields that are marked as "Optional<>" in the
Rust code are serialized such that the value is omitted when it is
deserialized — appearing as `undefined`, but the TS type indicates
(incorrectly) that it is always defined but possibly `null`. This can
lead to subtle errors that the TypeScript compiler doesn't catch. The
fix is to include the `#[ts(optional_fields = nullable)]` macro for all
protocol structs that contain one or more `Optional<>` fields.

This PR also includes a new test that validates that all TS protocol
code containing "| null" in its type is marked optional ("?") to catch
cases where `#[ts(optional_fields = nullable)]` is omitted.

Eric Traut · 2025-10-29 12:09:47 -07:00

069a38a06c

chore: merge git crates (#5909 )

Merge `git-apply` and `git-tooling` into `utils/`

jif-oai · 2025-10-29 12:11:44 +00:00

fa92cd92fa

14 Commits