10 Commits

• fix: Record EnvironmentContext in SendUserTurn (#3678)

  ## Summary
  SendUserTurn has not been correctly handling updates to policies. While
  the tui protocol handles this in `Op::OverrideTurnContext`, the
  SendUserTurn should be appending `EnvironmentContext` messages when the
  sandbox settings change. MCP client behavior should match the cli
  behavior, so we update `SendUserTurn` message to match.
  
  ## Testing
  - [x] Added prompt caching tests

  Dylan · 2025-09-16 11:32:20 -07:00
  11285655c4
• chore: enable clippy::redundant_clone (#3489)

  Created this PR by:
  
  - adding `redundant_clone` to `[workspace.lints.clippy]` in
  `cargo-rs/Cargol.toml`
  - running `cargo clippy --tests --fix`
  - running `just fmt`
  
  Though I had to clean up one instance of the following that resulted:
  
  ```rust
  let codex = codex;
  ```

  Michael Bolin · 2025-09-11 11:59:37 -07:00
  bec51f6c05
• put workspace roots in the environment context (#3375)

  to keep the tool description constant when the writable roots change.

  Jeremy Rose · 2025-09-10 15:10:52 -07:00
  f69f07b028
• Dividing UserMsgs into categories to send it back to the tui (#3127)

  This PR does the following:
  
  - divides user msgs into 3 categories: plain, user instructions, and
  environment context
  - Centralizes adding user instructions and environment context to a
  degree
  - Improve the integration testing
  
  Building on top of #3123
  
  Specifically this
  [comment](https://github.com/openai/codex/pull/3123#discussion_r2319885089).
  We need to send the user message while ignoring the User Instructions
  and Environment Context we attach.

  Ahmed Ibrahim · 2025-09-04 05:34:50 +00:00
  2b96f9f569
• chore: require uninlined_format_args from clippy (#2845)

  - added `uninlined_format_args` to `[workspace.lints.clippy]` in the
  `Cargo.toml` for the workspace
  - ran `cargo clippy --tests --fix`
  - ran `just fmt`

  Michael Bolin · 2025-08-28 11:25:23 -07:00
  74d2741729
• Move models.rs to protocol (#2595)

  Moving models.rs to protocol so we can use them in `Codex` operations

  Ahmed Ibrahim · 2025-08-22 22:18:54 +00:00
  097782c775
• [prompt] xml-format EnvironmentContext (#2272)

  ## Summary
  Before we land #2243, let's start printing environment_context in our
  preferred format. This struct will evolve over time with new
  information, xml gives us a balance of human readable without too much
  parsing, llm readable, and extensible.
  
  Also moves us over to an Option-based struct, so we can easily provide
  diffs to the model.
  
  ## Testing
  - [x] Updated tests to reflect new format

  Dylan · 2025-08-20 23:45:16 -07:00
  d2b2a6d13a
• Bridge command generation to powershell when on Windows (#2319)

  ## What? Why? How?
  - When running on Windows, codex often tries to invoke bash commands,
  which commonly fail (unless WSL is installed)
  - Fix: Detect if powershell is available and, if so, route commands to
  it
  - Also add a shell_name property to environmental context for codex to
  default to powershell commands when running in that environment
  
  ## Testing
  - Tested within WSL and powershell (e.g. get top 5 largest files within
  a folder and validated that commands generated were powershell commands)
  - Tested within Zsh
  - Updated unit tests
  
  ---------
  
  Co-authored-by: Eddy Escardo <eddy@openai.com>

  eddy-win · 2025-08-20 16:30:34 -07:00
  050b9baeb6
• chore: move mcp-server/src/wire_format.rs to protocol/src/mcp_protocol.rs (#2423)

  The existing `wire_format.rs` should share more types with the
  `codex-protocol` crate (like `AskForApproval` instead of maintaining a
  parallel `CodexToolCallApprovalPolicy` enum), so this PR moves
  `wire_format.rs` into `codex-protocol`, renaming it as
  `mcp-protocol.rs`. We also de-dupe types, where appropriate.
  
  ---
  [//]: # (BEGIN SAPLING FOOTER)
  Stack created with [Sapling](https://sapling-scm.com). Best reviewed
  with [ReviewStack](https://reviewstack.dev/openai/codex/pull/2423).
  * #2424
  * __->__ #2423

  Michael Bolin · 2025-08-18 09:36:57 -07:00
  712bfa04ac
• [context] Store context messages in rollouts (#2243)

  ## Summary
  Currently, we use request-time logic to determine the user_instructions
  and environment_context messages. This means that neither of these
  values can change over time as conversations go on. We want to add in
  additional details here, so we're migrating these to save these messages
  to the rollout file instead. This is simpler for the client, and allows
  us to append additional environment_context messages to each turn if we
  want
  
  ## Testing
  - [x] Integration test coverage
  - [x] Tested locally with a few turns, confirmed model could reference
  environment context and cached token metrics were reasonably high

  Dylan · 2025-08-14 14:51:13 -04:00
  544980c008