Commit Graph

2 Commits

  • re-enable Prettier check for codex-cli in CI (#417)
    This check was lost in https://github.com/openai/codex/pull/287. Both
    the root folder and `codex-cli/` have their own `pnpm format` commands
    that check the formatting of different things.
    
    Also ran `pnpm format:fix` to fix the formatting violations that got in
    while this was disabled in CI.
    
    ---
    [//]: # (BEGIN SAPLING FOOTER)
    Stack created with [Sapling](https://sapling-scm.com). Best reviewed
    with [ReviewStack](https://reviewstack.dev/openai/codex/pull/417).
    * #420
    * #419
    * #416
    * __->__ #417
  • Add fallback text for missing images (#397)
    # What?
    * When a prompt references an image path that doesn’t exist, replace it
    with
      ```[missing image: <path>]``` instead of throwing an ENOENT.
    * Adds a few unit tests for input-utils as there weren't any beforehand.
    
    # Why?
    Right now if you enter an invalid image path (e.g. it doesn't exist),
    codex immediately crashes with a ENOENT error like so:
    ```
    Error: ENOENT: no such file or directory, open 'test.png'
       ...
     {
      errno: -2,
      code: 'ENOENT',
      syscall: 'open',
      path: 'test.png'
    }
    ```
    This aborts the entire session. A soft fallback lets the rest of the
    input continue.
    
    # How?
    Wraps the image encoding + inputItem content pushing in a try-catch. 
    
    This is a minimal patch to avoid completely crashing — future work could
    surface a warning to the user when this happens, or something to that
    effect.
    
    ---------
    
    Co-authored-by: Thibault Sottiaux <tibo@openai.com>