Commit Graph

3 Commits

  • Support anyOf and enum in JsonSchema (#16875)
    This brings us into better alignment with the JSON schema subset that is
    supported in
    <https://developers.openai.com/api/docs/guides/structured-outputs#supported-schemas>,
    and also allows us to render richer function signatures in code mode
    (e.g., anyOf{null, OtherObjectType})
  • Add regression tests for JsonSchema (#17052)
    Tests added for existing JsonSchema in
    `codex-rs/tools/src/json_schema_tests.rs`:
    
    - `parse_tool_input_schema_coerces_boolean_schemas`
    - `parse_tool_input_schema_infers_object_shape_and_defaults_properties`
    - `parse_tool_input_schema_normalizes_integer_and_missing_array_items`
    - `parse_tool_input_schema_sanitizes_additional_properties_schema`
    -
    `parse_tool_input_schema_infers_object_shape_from_boolean_additional_properties_only`
    - `parse_tool_input_schema_infers_number_from_numeric_keywords`
    - `parse_tool_input_schema_infers_number_from_multiple_of`
    -
    `parse_tool_input_schema_infers_string_from_enum_const_and_format_keywords`
    - `parse_tool_input_schema_defaults_empty_schema_to_string`
    - `parse_tool_input_schema_infers_array_from_prefix_items`
    -
    `parse_tool_input_schema_preserves_boolean_additional_properties_on_inferred_object`
    -
    `parse_tool_input_schema_infers_object_shape_from_schema_additional_properties_only`
    
    Tests that we expect to fail on the baseline normalizer, but pass with
    the new JsonSchema:
    
    - `parse_tool_input_schema_preserves_nested_nullable_type_union`
    - `parse_tool_input_schema_preserves_nested_any_of_property`
  • codex-tools: extract shared tool schema parsing (#15923)
    ## Why
    
    `parse_tool_input_schema` and the supporting `JsonSchema` model were
    living in `core/src/tools/spec.rs`, but they already serve callers
    outside `codex-core`.
    
    Keeping that shared schema parsing logic inside `codex-core` makes the
    crate boundary harder to reason about and works against the guidance in
    `AGENTS.md` to avoid growing `codex-core` when reusable code can live
    elsewhere.
    
    This change takes the first extraction step by moving the schema parsing
    primitive into its own crate while keeping the rest of the tool-spec
    assembly in `codex-core`.
    
    ## What changed
    
    - added a new `codex-tools` crate under `codex-rs/tools`
    - moved the shared tool input schema model and sanitizer/parser into
    `tools/src/json_schema.rs`
    - kept `tools/src/lib.rs` exports-only, with the module-level unit tests
    split into `json_schema_tests.rs`
    - updated `codex-core` to use `codex-tools::JsonSchema` and re-export
    `parse_tool_input_schema`
    - updated `codex-app-server` dynamic tool validation to depend on
    `codex-tools` directly instead of reaching through `codex-core`
    - wired the new crate into the Cargo workspace and Bazel build graph