11 Commits

• chore: upgrade to Rust 1.89 (#2465)

  Codex created this PR from the following prompt:
  
  > upgrade this entire repo to Rust 1.89. Note that this requires
  updating codex-rs/rust-toolchain.toml as well as the workflows in
  .github/. Make sure that things are "clippy clean" as this change will
  likely uncover new Clippy errors. `just fmt` and `cargo clippy --tests`
  are sufficient to check for correctness
  
  Note this modifies a lot of lines because it folds nested `if`
  statements using `&&`.
  
  ---
  [//]: # (BEGIN SAPLING FOOTER)
  Stack created with [Sapling](https://sapling-scm.com). Best reviewed
  with [ReviewStack](https://reviewstack.dev/openai/codex/pull/2465).
  * #2467
  * __->__ #2465

  Michael Bolin · 2025-08-19 13:22:02 -07:00
  50c48e88f5
• Added allow-expect-in-tests / allow-unwrap-in-tests (#2328)

  This PR:
  * Added the clippy.toml to configure allowable expect / unwrap usage in
  tests
  * Removed as many expect/allow lines as possible from tests
  * moved a bunch of allows to expects where possible
  
  Note: in integration tests, non `#[test]` helper functions are not
  covered by this so we had to leave a few lingering `expect(expect_used`
  checks around

  Parker Thompson · 2025-08-14 17:59:01 -07:00
  a075424437
• chore: refactor exec.rs: create separate seatbelt.rs and spawn.rs files (#1762)

  At 550 lines, `exec.rs` was a bit large. In particular, I found it hard
  to locate the Seatbelt-related code quickly without a file with
  `seatbelt` in the name, so this refactors things so:
  
  - `spawn_command_under_seatbelt()` and dependent code moves to a new
  `seatbelt.rs` file
  - `spawn_child_async()` and dependent code moves to a new `spawn.rs`
  file

  Michael Bolin · 2025-07-31 13:11:47 -07:00
  5a0ad5ab8f
• fix git tests (#1747)

  the git tests were failing on my local machine due to gpg signing config
  in my ~/.gitconfig. tests should not be affected by ~/.gitconfig, so
  configure them to ignore it.

  Jeremy Rose · 2025-07-31 09:17:59 -07:00
  be0cd34300
• Relative instruction file (#1722)

  Passing in an instruction file with a bad path led to silent failures,
  also instruction relative paths were handled in an unintuitive fashion.

  easong-openai · 2025-07-29 10:06:05 -07:00
  f8fcaaaf6f
• Record Git metadata to rollout (#1598)

  # Summary
  
  - Writing effective evals for codex sessions requires context of the
  overall repository state at the moment the session began
  - This change adds this metadata (git repository, branch, commit hash)
  to the top of the rollout of the session (if available - if not it
  doesn't add anything)
  - Currently, this is only effective on a clean working tree, as we can't
  track uncommitted/untracked changes with the current metadata set.
  Ideally in the future we may want to track unclean changes somehow, or
  perhaps prompt the user to stash or commit them.
  
  # Testing
  - Added unit tests
  - `cargo test && cargo clippy --tests && cargo fmt -- --config
  imports_granularity=Item`
  
  ### Resulting Rollout
  <img width="1243" height="127" alt="Screenshot 2025-07-17 at 1 50 00 PM"
  src="https://github.com/user-attachments/assets/68108941-f015-45b2-985c-ea315ce05415"
  />

  vishnu-oai · 2025-07-24 11:35:28 -07:00
  2437a8d17a
• Add session loading support to Codex (#1602)

  ## Summary
  - extend rollout format to store all session data in JSON
  - add resume/write helpers for rollouts
  - track session state after each conversation
  - support `LoadSession` op to resume a previous rollout
  - allow starting Codex with an existing session via
  `experimental_resume` config variable
  
  We need a way later for exploring the available sessions in a user
  friendly way.
  
  ## Testing
  - `cargo test --no-run` *(fails: `cargo: command not found`)*
  
  ------
  https://chatgpt.com/codex/tasks/task_i_68792a29dd5c832190bf6930d3466fba
  
  This video is outdated. you should use `-c experimental_resume:<full
  path>` instead of `--resume <full path>`
  
  
  https://github.com/user-attachments/assets/7a9975c7-aa04-4f4e-899a-9e87defd947a

  aibrahim-oai · 2025-07-18 17:04:04 -07:00
  83eefb55fb
• Refactor env settings into config (#1601)

  ## Summary
  - add OpenAI retry and timeout fields to Config
  - inject these settings in tests instead of mutating env vars
  - plumb Config values through client and chat completions logic
  - document new configuration options
  
  ## Testing
  - `cargo test -p codex-core --no-run`
  
  ------
  https://chatgpt.com/codex/tasks/task_i_68792c5b04cc832195c03050c8b6ea94
  
  ---------
  
  Co-authored-by: Michael Bolin <mbolin@openai.com>

  aibrahim-oai · 2025-07-18 19:12:39 +00:00
  9846adeabf
• Storing the sessions in a more organized way for easier look up. (#1596)

  now storing the sessions in `~/.codex/sessions/YYYY/MM/DD/<file>`

  aibrahim-oai · 2025-07-17 10:12:15 -07:00
  fcbcc40f51
• support deltas in core (#1587)

  - Added support for message and reasoning deltas
  - Skipped adding the support in the cli and tui for later
  - Commented a failing test (wrong merge) that needs fix in a separate
  PR.
  
  Side note: I think we need to disable merge when the CI don't pass.

  aibrahim-oai · 2025-07-16 15:11:18 -07:00
  2bd3314886
• Add CLI streaming integration tests (#1542)

  ## Summary
  - add integration test for chat mode streaming via CLI using wiremock
  - add integration test for Responses API streaming via fixture
  - call `cargo run` to invoke the CLI during tests
  
  ## Testing
  - `cargo test -p codex-core --test cli_stream -- --nocapture`
  - `cargo clippy --all-targets --all-features -- -D warnings`
  
  
  ------
  https://chatgpt.com/codex/tasks/task_i_68715980bbec8321999534fdd6a013c1

  aibrahim-oai · 2025-07-12 18:05:58 -07:00
  3777e18243