21 Commits

• Apply argument comment lint across codex-rs (#14652)

  ## Why
  
  Once the repo-local lint exists, `codex-rs` needs to follow the
  checked-in convention and CI needs to keep it from drifting. This commit
  applies the fallback `/*param*/` style consistently across existing
  positional literal call sites without changing those APIs.
  
  The longer-term preference is still to avoid APIs that require comments
  by choosing clearer parameter types and call shapes. This PR is
  intentionally the mechanical follow-through for the places where the
  existing signatures stay in place.
  
  After rebasing onto newer `main`, the rollout also had to cover newly
  introduced `tui_app_server` call sites. That made it clear the first cut
  of the CI job was too expensive for the common path: it was spending
  almost as much time installing `cargo-dylint` and re-testing the lint
  crate as a representative test job spends running product tests. The CI
  update keeps the full workspace enforcement but trims that extra
  overhead from ordinary `codex-rs` PRs.
  
  ## What changed
  
  - keep a dedicated `argument_comment_lint` job in `rust-ci`
  - mechanically annotate remaining opaque positional literals across
  `codex-rs` with exact `/*param*/` comments, including the rebased
  `tui_app_server` call sites that now fall under the lint
  - keep the checked-in style aligned with the lint policy by using
  `/*param*/` and leaving string and char literals uncommented
  - cache `cargo-dylint`, `dylint-link`, and the relevant Cargo
  registry/git metadata in the lint job
  - split changed-path detection so the lint crate's own `cargo test` step
  runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes
  - continue to run the repo wrapper over the `codex-rs` workspace, so
  product-code enforcement is unchanged
  
  Most of the code changes in this commit are intentionally mechanical
  comment rewrites or insertions driven by the lint itself.
  
  ## Verification
  
  - `./tools/argument-comment-lint/run.sh --workspace`
  - `cargo test -p codex-tui-app-server -p codex-tui`
  - parsed `.github/workflows/rust-ci.yml` locally with PyYAML
  
  ---
  
  * -> #14652
  * #14651

  Michael Bolin · 2026-03-16 16:48:15 -07:00
  b77fe8fefe
• feat: improve skills cache key to take into account config layering (#14806)

  Fix https://github.com/openai/codex/issues/14161
  
  This fixes sub-agent [[skills.config]] overrides being ignored when
  parent and child share the same cwd. The root cause was that turn skill
  loading rebuilt from cwd-only state and reused a cwd-scoped cache, so
  role-local skill enable/disable overrides did not reliably affect the
  spawned agent's effective skill set.
  
  This change switches turn construction to use the effective per-turn
  config and adds a config-aware skills cache keyed by skill roots plus
  final disabled paths.

  jif-oai · 2026-03-16 16:12:44 +00:00
  18ad67549c
• fix: move inline codex-rs/core unit tests into sibling files (#14444)

  ## Why
  PR #13783 moved the `codex.rs` unit tests into `codex_tests.rs`. This
  applies the same extraction pattern across the rest of `codex-rs/core`
  so the production modules stay focused on runtime code instead of large
  inline test blocks.
  
  Keeping the tests in sibling files also makes follow-up edits easier to
  review because product changes no longer have to share a file with
  hundreds or thousands of lines of test scaffolding.
  
  ## What changed
  - replaced each inline `mod tests { ... }` in `codex-rs/core/src/**`
  with a path-based module declaration
  - moved each extracted unit test module into a sibling `*_tests.rs`
  file, using `mod_tests.rs` for `mod.rs` modules
  - preserved the existing `cfg(...)` guards and module-local structure so
  the refactor remains structural rather than behavioral
  
  ## Testing
  - `cargo test -p codex-core --lib` (`1653 passed; 0 failed; 5 ignored`)
  - `just fix -p codex-core`
  - `cargo fmt --check`
  - `cargo shear`

  Michael Bolin · 2026-03-12 08:16:36 -07:00
  0c8a36676a
• feat: support disabling bundled system skills (#13792)

  Support disable bundled system skills with a config:
  
  [skills.bundled]
  enabled = false

  xl-openai · 2026-03-09 22:02:53 -07:00
  0c33af7746
• feat: load from plugins (#12864)

  Support loading plugins.
  
  Plugins can now be enabled via [plugins.<name>] in config.toml. They are
  loaded as first-class entities through PluginsManager, and their default
  skills/ and .mcp.json contributions are integrated into the existing
  skills and MCP flows.

  xl-openai · 2026-03-01 10:50:56 -08:00
  752402c4fe
• nit: disable on windows (#13127)
  jif-oai · 2026-02-28 14:55:16 +01:00
  84b662e74f
• feat: skill disable respect config layer (#13027)
  jif-oai · 2026-02-28 14:17:05 +01:00
  d33f4b54ac
• Skip system skills for extra roots (#12744)

  When extra roots is set do not load system skills.

  xl-openai · 2026-02-25 19:55:28 -08:00
  8cdee988f9
• Simplify skill tracking (#12652)

  Remove a few layers of structs and store SkillMetadata.
  
  ---------
  
  Co-authored-by: alexsong-oai <alexsong@openai.com>

  pakrym-oai · 2026-02-23 22:47:39 -08:00
  68a7d98363
• Support implicit skill invocation analytics events (#12049)

  - use `skills_for_cwd` lookup to scope allowed skills and build
  invocation context for downstream processing
  - add detection in `stream_events_utils` to classify tool calls as
  implicit skill invocations per the proposal (script runners, extensions,
  `scripts` dirs, and SKILL.md reads)
  - deduplicate invocations per turn and emit analytics/OTEL events on the
  same background queue as explicit invokes

  alexsong-oai · 2026-02-23 21:55:49 -08:00
  09a82f364f
• feat: extend skills/list to support additional roots. (#10835)

  Add an optional perCwdExtraUserRoots

  xl-openai · 2026-02-09 13:30:38 -08:00
  a33ee46e3b
• Added support for live updates to skills (#10478)

  Add a centralized FileWatcher in codex-core (using notify) that watches
  skill roots from the config layer stack (recursive)
  
  Send `SkillsChanged` events when relevant file system changes are
  detected
  
  On `SkillsChanged`:
  * Invalidate the skills cache immediately in ThreadManager
  * Emit EventMsg::SkillsUpdateAvailable to active sessions
  ~~* Broadcast a new app-server notification:
  SkillsListUpdatedNotification~~
  
  This change does not inject new items into the event stream. That means
  the agent will not know about new skills, so it won't be able to
  implicitly invoke new skills. It also won't know about changes to
  existing skills, so if it has already read the contents of a modified
  skill, it will not honor the new behavior.
  
  This change also does not detect modifications to AGENTS.md.
  
  I plan to address these limitations in a follow-on PR modeled after
  #9985. Injection of new skills and AGENTS was deemed to risky, hence the
  need to split the feature into two stages. The changes in this PR were
  designed to easily accommodate the second stage once we have some other
  foundational changes in place.
  
  Testing: In addition to automated tests, I did manual testing to confirm
  that newly-created skills, deleted skills, and renamed skills are
  reflected in the TUI skill picker menu. Also confirmed that
  modifications to behaviors for explicitly-invoked skills are honored.
  
  ---------
  
  Co-authored-by: Xin Lin <xl@openai.com>

  Eric Traut · 2026-02-04 15:25:03 -08:00
  7bcc552325
• feat: Support loading skills from .agents/skills (#10317)

  This PR adds support for loading
  [skills](https://developers.openai.com/codex/skills) from
  `.agents/skills/`.
  - Issue: https://github.com/agentskills/agentskills/issues/15
  - Motivation: When skills live on the filesystem, sharing them across
  agents is awkward and often ends up requiring symlinks/duplication. A
  single location under `.agents/` makes it easier to share skills.
  - Loading from `.codex/skills/` will remain but will be deprecated soon.
  The change only applies to the [REPO
  scope](https://developers.openai.com/codex/skills#where-to-save-skills).
  - Documentation will be updated before this change is live.
  
  Testing with skills in two locations of this repo:
  <img width="960" height="152" alt="image"
  src="https://github.com/user-attachments/assets/28975ff9-7363-46dd-ad40-f4c7bfdb8234"
  />
  
  When starting Codex with CWD in `$repo_root` (should only pick up at
  root):
  <img width="513" height="143" alt="image"
  src="https://github.com/user-attachments/assets/389e1ea7-020c-481e-bda0-ce58562db59f"
  />
  
  When starting Codex with CWD in `$repo_root/codex-rs` (should pick up at
  cwd and crawl up to root):
  <img width="552" height="177" alt="image"
  src="https://github.com/user-attachments/assets/a5beb8de-11b4-45ed-8660-80707c77006a"
  />

  Gav Verma · 2026-01-31 18:45:05 -08:00
  39a6a84097
• Wire up cloud reqs in exec, app-server (#10241)

  We're fetching cloud requirements in TUI in
  https://github.com/openai/codex/pull/10167.
  
  This adds the same fetching in exec and app-server binaries also.

  gt-oai · 2026-01-30 23:53:41 +00:00
  a046481ad9
• Fetch Requirements from cloud (#10167)

  Load requirements from Codex Backend. It only does this for enterprise
  customers signed in with ChatGPT.
  
  Todo in follow-up PRs:
  * Add to app-server and exec too
  * Switch from fail-open to fail-closed on failure

  gt-oai · 2026-01-30 12:03:29 +00:00
  e85d019daa
• Support enable/disable skill via config/api. (#9328)

  In config.toml:
  ```
  [[skills.config]]
  path = "/Users/xl/.codex/skills/my_skill/SKILL.md"
  enabled = false
  ```
  
  API:
  skills/list, skills/config/write

  xl-openai · 2026-01-16 20:22:05 -08:00
  ad8bf59cbf
• Use ConfigLayerStack for skills discovery. (#8497)

  Use ConfigLayerStack to get all folders while loading skills.

  xl-openai · 2026-01-05 13:47:39 -08:00
  58a91a0b50
• Fix admin skills. (#8305)

  We were assembling the skill roots in two different places, and the
  admin root was missing in one of them. This change centralizes root
  selection into a helper so both paths stay in sync.

  xl-openai · 2025-12-19 04:10:19 +00:00
  339b052d68
• Support SYSTEM skills. (#8220)

  1. Remove PUBLIC skills and introduce SYSTEM skills embedded in the
  binary and installed into $CODEX_HOME/skills/.system at startup.
  2. Skills are now always enabled (feature flag removed).
  3. Update skills/list to accept forceReload and plumb it through (not
  used by clients yet).

  xl-openai · 2025-12-17 18:48:28 -08:00
  da3869eeb6
• Add public skills + improve repo skill discovery and error UX (#8098)

  1. Adds SkillScope::Public end-to-end (core + protocol) and loads skills
  from the public cache directory
  2. Improves repo skill discovery by searching upward for the nearest
  .codex/skills within a git repo
  3. Deduplicates skills by name with deterministic ordering to avoid
  duplicates across sources
  4. Fixes garbled “Skill errors” overlay rendering by preventing pending
  history lines from being injected during the modal
  5. Updates the project docs “Skills” intro wording to avoid hardcoded
  paths

  xl-openai · 2025-12-17 01:35:49 -08:00
  4897efcced
• Reimplement skills loading using SkillsManager + skills/list op. (#7914)

  refactor the way we load and manage skills:
  1. Move skill discovery/caching into SkillsManager and reuse it across
  sessions.
  2. Add the skills/list API (Op::ListSkills/SkillsListResponse) to fetch
  skills for one or more cwds. Also update app-server for VSCE/App;
  3. Trigger skills/list during session startup so UIs preload skills and
  handle errors immediately.

  xl-openai · 2025-12-14 09:58:17 -08:00
  5d77d4db6b