110 Commits

• Review Mode (Core) (#3401)

  ## 📝 Review Mode -- Core
  
  This PR introduces the Core implementation for Review mode:
  
  - New op `Op::Review { prompt: String }:` spawns a child review task
  with isolated context, a review‑specific system prompt, and a
  `Config.review_model`.
  - `EnteredReviewMode`: emitted when the child review session starts.
  Every event from this point onwards reflects the review session.
  - `ExitedReviewMode(Option<ReviewOutputEvent>)`: emitted when the review
  finishes or is interrupted, with optional structured findings:
  
  ```json
  {
    "findings": [
      {
        "title": "<≤ 80 chars, imperative>",
        "body": "<valid Markdown explaining *why* this is a problem; cite files/lines/functions>",
        "confidence_score": <float 0.0-1.0>,
        "priority": <int 0-3>,
        "code_location": {
          "absolute_file_path": "<file path>",
          "line_range": {"start": <int>, "end": <int>}
        }
      }
    ],
    "overall_correctness": "patch is correct" | "patch is incorrect",
    "overall_explanation": "<1-3 sentence explanation justifying the overall_correctness verdict>",
    "overall_confidence_score": <float 0.0-1.0>
  }
  ```
  
  ## Questions
  
  ### Why separate out its own message history?
  
  We want the review thread to match the training of our review models as
  much as possible -- that means using a custom prompt, removing user
  instructions, and starting a clean chat history.
  
  We also want to make sure the review thread doesn't leak into the parent
  thread.
  
  ### Why do this as a mode, vs. sub-agents?
  
  1. We want review to be a synchronous task, so it's fine for now to do a
  bespoke implementation.
  2. We're still unclear about the final structure for sub-agents. We'd
  prefer to land this quickly and then refactor into sub-agents without
  rushing that implementation.

  dedrisian-oai · 2025-09-12 23:25:10 +00:00
  90a0fd342f
• Add Azure Responses API workaround (#3528)

  Azure Responses API doesn't work well with store:false and response
  items.
  
  If store = false and id is sent an error is thrown that ID is not found
  If store = false and id is not sent an error is thrown that ID is
  required
  
  Add detection for Azure urls and add a workaround to preserve reasoning
  item IDs and send store:true

  pakrym-oai · 2025-09-12 13:52:15 -07:00
  e3c6903199
• feat: context compaction (#3446)

  ## Compact feature:
  1. Stops the model when the context window become too large
  2. Add a user turn, asking for the model to summarize
  3. Build a bridge that contains all the previous user message + the
  summary. Rendered from a template
  4. Start sampling again from a clean conversation with only that bridge

  jif-oai · 2025-09-12 13:07:10 -07:00
  ea225df22e
• feat: reasoning effort as optional (#3527)

  Allow the reasoning effort to be optional

  jif-oai · 2025-09-12 12:06:33 -07:00
  c6fd056aa6
• bug: fix model save (#3525)

  Fix those 2 behaviors:
  1. The model does not get saved if we don't CTRL + S
  2. The reasoning effort get saved

  jif-oai · 2025-09-12 10:38:12 -07:00
  bba567cee9
• Add Compact and Turn Context to the rollout items (#3444)

  Adding compact and turn context to the rollout items
  
  based on #3440

  Ahmed Ibrahim · 2025-09-11 18:08:51 +00:00
  674e3d3c90
• NIT unified exec (#3479)

  Fix the default value of the experimental flag of unified_exec

  jif-oai · 2025-09-11 16:19:12 +00:00
  114ce9ff4d
• Simplify auth flow and reconcile differences between ChatGPT and API Key auth (#3189)

  This PR does the following:
  * Adds the ability to paste or type an API key.
  * Removes the `preferred_auth_method` config option. The last login
  method is always persisted in auth.json, so this isn't needed.
  * If OPENAI_API_KEY env variable is defined, the value is used to
  prepopulate the new UI. The env variable is otherwise ignored by the
  CLI.
  * Adds a new MCP server entry point "login_api_key" so we can implement
  this same API key behavior for the VS Code extension.
  <img width="473" height="140" alt="Screenshot 2025-09-04 at 3 51 04 PM"
  src="https://github.com/user-attachments/assets/c11bbd5b-8a4d-4d71-90fd-34130460f9d9"
  />
  <img width="726" height="254" alt="Screenshot 2025-09-04 at 3 51 32 PM"
  src="https://github.com/user-attachments/assets/6cc76b34-309a-4387-acbc-15ee5c756db9"
  />

  Eric Traut · 2025-09-11 09:16:34 -07:00
  e13b35ecb0
• Change forking to read the rollout from file (#3440)

  This PR changes get history op to get path. Then, forking will use a
  path. This will help us have one unified codepath for resuming/forking
  conversations. Will also help in having rollout history in order. It
  also fixes a bug where you won't see the UI when resuming after forking.

  Ahmed Ibrahim · 2025-09-10 17:42:54 -07:00
  162e1235a8
• Unified execution (#3288)

  ## Unified PTY-Based Exec Tool
  
  Note: this requires to have this flag in the config:
  `use_experimental_unified_exec_tool=true`
  
  - Adds a PTY-backed interactive exec feature (“unified_exec”) with
  session reuse via
    session_id, bounded output (128 KiB), and timeout clamping (≤ 60 s).
  - Protocol: introduces ResponseItem::UnifiedExec { session_id,
  arguments, timeout_ms }.
  - Tools: exposes unified_exec as a function tool (Responses API);
  excluded from Chat
    Completions payload while still supported in tool lists.
  - Path handling: resolves commands via PATH (or explicit paths), with
  UTF‑8/newline‑aware
    truncation (truncate_middle).
  - Tests: cover command parsing, path resolution, session
  persistence/cleanup, multi‑session
    isolation, timeouts, and truncation behavior.

  jif-oai · 2025-09-10 17:38:11 -07:00
  c09ed74a16
• put workspace roots in the environment context (#3375)

  to keep the tool description constant when the writable roots change.

  Jeremy Rose · 2025-09-10 15:10:52 -07:00
  f69f07b028
• Back out "feat: POSIX unification and snapshot sessions (#3179)" (#3430)

  This reverts https://github.com/openai/codex/pull/3179.
  
  #3179 appears to introduce a regression where sourcing dotfiles causes a
  bunch of activity in the title bar (and potentially slows things down?)
  
  
  https://github.com/user-attachments/assets/a68f7fb3-0749-4e0e-a321-2aa6993e01da
  
  Verified this no longer happens after backing out #3179.
  
  Original commit changeset: 62bd0e3d9d

  Michael Bolin · 2025-09-10 12:40:24 -07:00
  51d9e05de7
• Move initial history to protocol (#3422)

  To fix an edge case of forking then resuming
  
  #3419

  Ahmed Ibrahim · 2025-09-10 10:17:24 -07:00
  45bd5ca4b9
• Introduce rollout items (#3380)

  This PR introduces Rollout items. This enable us to rollout eventmsgs
  and session meta.
  
  This is mostly #3214 with rebase on main

  Ahmed Ibrahim · 2025-09-09 23:52:33 +00:00
  43809a454e
• Replace config.responses_originator_header_internal_override with CODEX_INTERNAL_ORIGINATOR_OVERRIDE_ENV_VAR (#3388)

  The previous config approach had a few issues:
  1. It is part of the config but not designed to be used externally
  2. It had to be wired through many places (look at the +/- on this PR
  3. It wasn't guaranteed to be set consistently everywhere because we
  don't have a super well defined way that configs stack. For example, the
  extension would configure during newConversation but anything that
  happened outside of that (like login) wouldn't get it.
  
  This env var approach is cleaner and also creates one less thing we have
  to deal with when coming up with a better holistic story around configs.
  
  One downside is that I removed the unit test testing for the override
  because I don't want to deal with setting the global env or spawning
  child processes and figuring out how to introspect their originator
  header. The new code is sufficiently simple and I tested it e2e that I
  feel as if this is still worth it.

  Gabriel Peal · 2025-09-09 17:23:23 -04:00
  5eab4c7ab4
• feat: POSIX unification and snapshot sessions (#3179)

  ## Session snapshot
  For POSIX shell, the goal is to take a snapshot of the interactive shell
  environment, store it in a session file located in `.codex/` and only
  source this file for every command that is run.
  As a result, if a snapshot files exist, `bash -lc <CALL>` get replaced
  by `bash -c <CALL>`.
  
  This also fixes the issue that `bash -lc` does not source `.bashrc`,
  resulting in missing env variables and aliases in the codex session.
  ## POSIX unification
  Unify `bash` and `zsh` shell into a POSIX shell. The rational is that
  the tool will not use any `zsh` specific capabilities.
  
  ---------
  
  Co-authored-by: Michael Bolin <mbolin@openai.com>

  jif-oai · 2025-09-08 18:09:45 -07:00
  62bd0e3d9d
• allow mach-lookup for com.apple.system.opendirectoryd.libinfo (#3334)

  in the base sandbox policy. this is [allowed in Chrome
  renderers](https://source.chromium.org/chromium/chromium/src/+/main:sandbox/policy/mac/common.sb;l=266;drc=7afa0043cfcddb3ef9dafe5acbfc01c2f7e7df01),
  so I feel it's fairly safe.

  Jeremy Rose · 2025-09-08 16:28:52 -07:00
  ac58749bd3
• Generate more typescript types and return conversation id with ConversationSummary (#3219)

  This PR does multiple things that are necessary for conversation resume
  to work from the extension. I wanted to make sure everything worked so
  these changes wound up in one PR:
  1. Generate more ts types
  2. Resume rollout history files rather than create a new one every time
  it is resumed so you don't see a duplicate conversation in history for
  every resume. Chatted with @aibrahim-oai to verify this
  3. Return conversation_id in conversation summaries
  4. [Cleanup] Use serde and strong types for a lot of the rollout file
  parsing

  Gabriel Peal · 2025-09-08 17:54:47 -04:00
  5eaaf307e1
• Use ConversationId instead of raw Uuids (#3282)

  We're trying to migrate from `session_id: Uuid` to `conversation_id:
  ConversationId`. Not only does this give us more type safety but it
  unifies our terminology across Codex and with the implementation of
  session resuming, a conversation (which can span multiple sessions) is
  more appropriate.
  
  I started this impl on https://github.com/openai/codex/pull/3219 as part
  of getting resume working in the extension but it's big enough that it
  should be broken out.

  Gabriel Peal · 2025-09-07 23:22:25 -04:00
  c8fab51372
• Never store requests (#3212)

  When item ids are sent to Responses API it will load them from the
  database ignoring the provided values. This adds extra latency.
  
  Not having the mode to store requests also allows us to simplify the
  code.
  
  ## Breaking change
  
  The `disable_response_storage` configuration option is removed.

  pakrym-oai · 2025-09-05 10:41:47 -07:00
  5775174ec2
• Dividing UserMsgs into categories to send it back to the tui (#3127)

  This PR does the following:
  
  - divides user msgs into 3 categories: plain, user instructions, and
  environment context
  - Centralizes adding user instructions and environment context to a
  degree
  - Improve the integration testing
  
  Building on top of #3123
  
  Specifically this
  [comment](https://github.com/openai/codex/pull/3123#discussion_r2319885089).
  We need to send the user message while ignoring the User Instructions
  and Environment Context we attach.

  Ahmed Ibrahim · 2025-09-04 05:34:50 +00:00
  2b96f9f569
• Replay EventMsgs from Response Items when resuming a session with history. (#3123)

  ### Overview
  
  This PR introduces the following changes:
  	1.	Adds a unified mechanism to convert ResponseItem into EventMsg.
  2. Ensures that when a session is initialized with initial history, a
  vector of EventMsg is sent along with the session configuration. This
  allows clients to re-render the UI accordingly.
  	3. 	Added integration testing
  
  ### Caveats
  
  This implementation does not send every EventMsg that was previously
  dispatched to clients. The excluded events fall into two categories:
  	•	“Arguably” rolled-out events
  Examples include tool calls and apply-patch calls. While these events
  are conceptually rolled out, we currently only roll out ResponseItems.
  These events are already being handled elsewhere and transformed into
  EventMsg before being sent.
  	•	Non-rolled-out events
  Certain events such as TurnDiff, Error, and TokenCount are not rolled
  out at all.
  
  ### Future Directions
  
  At present, resuming a session involves maintaining two states:
  	•	UI State
  Clients can replay most of the important UI from the provided EventMsg
  history.
  	•	Model State
  The model receives the complete session history to reconstruct its
  internal state.
  
  This design provides a solid foundation. If, in the future, more precise
  UI reconstruction is needed, we have two potential paths:
  1. Introduce a third data structure that allows us to derive both
  ResponseItems and EventMsgs.
  2. Clearly divide responsibilities: the core system ensures the
  integrity of the model state, while clients are responsible for
  reconstructing the UI.

  Ahmed Ibrahim · 2025-09-04 04:47:00 +00:00
  f2036572b6
• Fix failing CI (#3130)

  In this test, the ChatGPT token path is used, and the auth layer tries
  to refresh the token if it thinks the token is “old.” Your helper writes
  a fixed last_refresh timestamp that has now aged past the 28‑day
  threshold, so the code attempts a real refresh against auth.openai.com,
  never reaches the mock, and you end up with
  received_requests().await.unwrap() being empty.

  Ahmed Ibrahim · 2025-09-03 22:38:32 +00:00
  6b83c1c3f3
• Add a common way to create HTTP client (#3110)

  Ensure User-Agent and originator are always sent.

  pakrym-oai · 2025-09-03 10:11:02 -07:00
  c636f821ae
• Improve gpt-oss compatibility (#2461)

  The gpt-oss models require reasoning with subsequent Chat Completions
  requests because otherwise the model forgets why the tools were called.
  This change fixes that and also adds some additional missing
  documentation around how to handle context windows in Ollama and how to
  show the CoT if you desire to.

  Dominik Kundel · 2025-09-02 19:49:03 -07:00
  b127a3643f
• Move CodexAuth and AuthManager to the core crate (#3074)

  Fix a long standing layering issue.

  pakrym-oai · 2025-09-02 18:36:19 -07:00
  03e2796ca4
• chore: unify history loading (#2736)

  We have two ways of loading conversation with a previous history. Fork
  conversation and the experimental resume that we had before. In this PR,
  I am unifying their code path. The path is getting the history items and
  recording them in a brand new conversation. This PR also constraint the
  rollout recorder responsibilities to be only recording to the disk and
  loading from the disk.
  
  The PR also fixes a current bug when we have two forking in a row:
  History 1:
  <Environment Context>
  UserMessage_1
  UserMessage_2
  UserMessage_3
  
  **Fork with n = 1 (only remove one element)**
  History 2:
  <Environment Context>
  UserMessage_1
  UserMessage_2
  <Environment Context>
  
  **Fork with n = 1 (only remove one element)**
  History 2:
  <Environment Context>
  UserMessage_1
  UserMessage_2
  **<Environment Context>**
  
  This shouldn't happen but because we were appending the `<Environment
  Context>` after each spawning and it's considered as _user message_.
  Now, we don't add this message if restoring and old conversation.

  Ahmed Ibrahim · 2025-09-02 22:44:29 +00:00
  431a10fc50
• chore: require uninlined_format_args from clippy (#2845)

  - added `uninlined_format_args` to `[workspace.lints.clippy]` in the
  `Cargo.toml` for the workspace
  - ran `cargo clippy --tests --fix`
  - ran `just fmt`

  Michael Bolin · 2025-08-28 11:25:23 -07:00
  74d2741729
• Add "View Image" tool (#2723)

  Adds a "View Image" tool so Codex can find and see images by itself:
  
  <img width="1772" height="420" alt="Screenshot 2025-08-26 at 10 40
  04 AM"
  src="https://github.com/user-attachments/assets/7a459c7b-0b86-4125-82d9-05fbb35ade03"
  />

  dedrisian-oai · 2025-08-27 17:41:23 -07:00
  4e9ad23864
• Bug fix: deduplicate assistant messages (#2758)

  We are treating assistant messages in a different way than other
  messages which resulted in a duplicated history.
  
  See #2698

  Ahmed Ibrahim · 2025-08-27 01:29:16 -07:00
  2d2f66f9c5
• test: faster test execution in codex-core (#2633)

  this dramatically improves time to run `cargo test -p codex-core` (~25x
  speedup).
  
  before:
  ```
  cargo test -p codex-core  35.96s user 68.63s system 19% cpu 8:49.80 total
  ```
  
  after:
  ```
  cargo test -p codex-core  5.51s user 8.16s system 63% cpu 21.407 total
  ```
  
  both tests measured "hot", i.e. on a 2nd run with no filesystem changes,
  to exclude compile times.
  
  approach inspired by [Delete Cargo Integration
  Tests](https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html),
  we move all test cases in tests/ into a single suite in order to have a
  single binary, as there is significant overhead for each test binary
  executed, and because test execution is only parallelized with a single
  binary.

  Jeremy Rose · 2025-08-24 11:10:53 -07:00
  32bbbbad61
• send-aggregated output (#2364)

  We want to send an aggregated output of stderr and stdout so we don't
  have to aggregate it stderr+stdout as we lose order sometimes.
  
  ---------
  
  Co-authored-by: Gabriel Peal <gpeal@users.noreply.github.com>

  Ahmed Ibrahim · 2025-08-23 16:54:31 +00:00
  957d44918d
• [apply_patch] freeform apply_patch tool (#2576)

  ## Summary
  GPT-5 introduced the concept of [custom
  tools](https://platform.openai.com/docs/guides/function-calling#custom-tools),
  which allow the model to send a raw string result back, simplifying
  json-escape issues. We are migrating gpt-5 to use this by default.
  
  However, gpt-oss models do not support custom tools, only normal
  functions. So we keep both tool definitions, and provide whichever one
  the model family supports.
  
  ## Testing
  - [x] Tested locally with various models
  - [x] Unit tests pass

  Dylan · 2025-08-22 13:42:34 -07:00
  236c4f76a6
• Add AuthManager and enhance GetAuthStatus command (#2577)

  This PR adds a central `AuthManager` struct that manages the auth
  information used across conversations and the MCP server. Prior to this,
  each conversation and the MCP server got their own private snapshots of
  the auth information, and changes to one (such as a logout or token
  refresh) were not seen by others.
  
  This is especially problematic when multiple instances of the CLI are
  run. For example, consider the case where you start CLI 1 and log in to
  ChatGPT account X and then start CLI 2 and log out and then log in to
  ChatGPT account Y. The conversation in CLI 1 is still using account X,
  but if you create a new conversation, it will suddenly (and
  unexpectedly) switch to account Y.
  
  With the `AuthManager`, auth information is read from disk at the time
  the `ConversationManager` is constructed, and it is cached in memory.
  All new conversations use this same auth information, as do any token
  refreshes.
  
  The `AuthManager` is also used by the MCP server's GetAuthStatus
  command, which now returns the auth method currently used by the MCP
  server.
  
  This PR also includes an enhancement to the GetAuthStatus command. It
  now accepts two new (optional) input parameters: `include_token` and
  `refresh_token`. Callers can use this to request the in-use auth token
  and can optionally request to refresh the token.
  
  The PR also adds tests for the login and auth APIs that I recently added
  to the MCP server.

  Eric Traut · 2025-08-22 13:10:11 -07:00
  dc42ec0eb4
• [apply-patch] Clean up apply-patch tool definitions (#2539)

  ## Summary
  We've experienced a bit of drift in system prompting for `apply_patch`:
  - As pointed out in #2030 , our prettier formatting started altering
  prompt.md in a few ways
  - We introduced a separate markdown file for apply_patch instructions in
  #993, but currently duplicate them in the prompt.md file
  - We added a first-class apply_patch tool in #2303, which has yet
  another definition
  
  This PR starts to consolidate our logic in a few ways:
  - We now only use
  `apply_patch_tool_instructions.md](https://github.com/openai/codex/compare/dh--apply-patch-tool-definition?expand=1#diff-d4fffee5f85cb1975d3f66143a379e6c329de40c83ed5bf03ffd3829df985bea)
  for system instructions
  - We no longer include apply_patch system instructions if the tool is
  specified
  
  I'm leaving the definition in openai_tools.rs as duplicated text for now
  because we're going to be iterated on the first-class tool soon.
  
  ## Testing
  - [x] Added integration tests to verify prompt stability
  - [x] Tested locally with several different models (gpt-5, gpt-oss,
  o4-mini)

  Dylan · 2025-08-21 20:07:41 -07:00
  e4c275d615
• [prompt] xml-format EnvironmentContext (#2272)

  ## Summary
  Before we land #2243, let's start printing environment_context in our
  preferred format. This struct will evolve over time with new
  information, xml gives us a balance of human readable without too much
  parsing, llm readable, and extensible.
  
  Also moves us over to an Option-based struct, so we can easily provide
  diffs to the model.
  
  ## Testing
  - [x] Updated tests to reflect new format

  Dylan · 2025-08-20 23:45:16 -07:00
  d2b2a6d13a
• Bridge command generation to powershell when on Windows (#2319)

  ## What? Why? How?
  - When running on Windows, codex often tries to invoke bash commands,
  which commonly fail (unless WSL is installed)
  - Fix: Detect if powershell is available and, if so, route commands to
  it
  - Also add a shell_name property to environmental context for codex to
  default to powershell commands when running in that environment
  
  ## Testing
  - Tested within WSL and powershell (e.g. get top 5 largest files within
  a folder and validated that commands generated were powershell commands)
  - Tested within Zsh
  - Updated unit tests
  
  ---------
  
  Co-authored-by: Eddy Escardo <eddy@openai.com>

  eddy-win · 2025-08-20 16:30:34 -07:00
  050b9baeb6
• fix: prefer config var to env var (#2495)
  Michael Bolin · 2025-08-20 04:51:59 +00:00
  ce434b1219
• chore: upgrade to Rust 1.89 (#2465)

  Codex created this PR from the following prompt:
  
  > upgrade this entire repo to Rust 1.89. Note that this requires
  updating codex-rs/rust-toolchain.toml as well as the workflows in
  .github/. Make sure that things are "clippy clean" as this change will
  likely uncover new Clippy errors. `just fmt` and `cargo clippy --tests`
  are sufficient to check for correctness
  
  Note this modifies a lot of lines because it folds nested `if`
  statements using `&&`.
  
  ---
  [//]: # (BEGIN SAPLING FOOTER)
  Stack created with [Sapling](https://sapling-scm.com). Best reviewed
  with [ReviewStack](https://reviewstack.dev/openai/codex/pull/2465).
  * #2467
  * __->__ #2465

  Michael Bolin · 2025-08-19 13:22:02 -07:00
  50c48e88f5
• Show login options when not signed in with ChatGPT (#2440)

  Motivation: we have users who uses their API key although they want to
  use ChatGPT account. We want to give them the chance to always login
  with their account.
  
  This PR displays login options when the user is not signed in with
  ChatGPT. Even if you have set an OpenAI API key as an environment
  variable, you will still be prompted to log in with ChatGPT.
  
  We’ve also added a new flag, `always_use_api_key_signing` false by
  default, which ensures you are never asked to log in with ChatGPT and
  always defaults to using your API key.
  
  
  
  https://github.com/user-attachments/assets/b61ebfa9-3c5e-4ab7-bf94-395c23a0e0af
  
  After ChatGPT sign in:
  
  
  https://github.com/user-attachments/assets/d58b366b-c46a-428f-a22f-2ac230f991c0

  Ahmed Ibrahim · 2025-08-19 03:22:48 +00:00
  97f995a749
• Add cache tests for UserTurn (#2432)
  Ahmed Ibrahim · 2025-08-18 21:28:09 +00:00
  ecb388045c
• Add an operation to override current task context (#2431)

  - Added an operation to override current task context
  - Added a test to check that cache stays the same

  Ahmed Ibrahim · 2025-08-18 19:59:19 +00:00
  c283f9f6ce
• [tools] Add apply_patch tool (#2303)

  ## Summary
  We've been seeing a number of issues and reports with our synthetic
  `apply_patch` tool, e.g. #802. Let's make this a real tool - in my
  anecdotal testing, it's critical for GPT-OSS models, but I'd like to
  make it the standard across GPT-5 and codex models as well.
  
  ## Testing
  - [x] Tested locally
  - [x] Integration test

  Dylan · 2025-08-15 11:55:53 -04:00
  6df8e35314
• Added allow-expect-in-tests / allow-unwrap-in-tests (#2328)

  This PR:
  * Added the clippy.toml to configure allowable expect / unwrap usage in
  tests
  * Removed as many expect/allow lines as possible from tests
  * moved a bunch of allows to expects where possible
  
  Note: in integration tests, non `#[test]` helper functions are not
  covered by this so we had to leave a few lingering `expect(expect_used`
  checks around

  Parker Thompson · 2025-08-14 17:59:01 -07:00
  a075424437
• fix: run python_multiprocessing_lock_works integration test on Mac and Linux (#2318)

  The high-order bit on this PR is that it makes it so `sandbox.rs` tests
  both Mac and Linux, as we introduce a general
  `spawn_command_under_sandbox()` function with platform-specific
  implementations for testing.
  
  An important, and interesting, discovery in porting the test to Linux is
  that (for reasons cited in the code comments), `/dev/shm` has to be
  added to `writable_roots` on Linux in order for `multiprocessing.Lock`
  to work there. Granting write access to `/dev/shm` comes with some
  degree of risk, so we do not make this the default for Codex CLI.
  
  Piggybacking on top of #2317, this moves the
  `python_multiprocessing_lock_works` test yet again, moving
  `codex-rs/core/tests/sandbox.rs` to `codex-rs/exec/tests/sandbox.rs`
  because in `codex-rs/exec/tests` we can use `cargo_bin()` like so:
  
  ```
  let codex_linux_sandbox_exe = assert_cmd::cargo::cargo_bin("codex-exec");
  ```
  
  which is necessary so we can use `codex_linux_sandbox_exe` and therefore
  `spawn_command_under_linux_sandbox` in an integration test.
  
  This also moves `spawn_command_under_linux_sandbox()` out of `exec.rs`
  and into `landlock.rs`, which makes things more consistent with
  `seatbelt.rs` in `codex-core`.
  
  For reference, https://github.com/openai/codex/pull/1808 is the PR that
  made the change to Seatbelt to get this test to pass on Mac.

  Michael Bolin · 2025-08-14 15:47:48 -07:00
  2ecca79663
• fix: move general sandbox tests to codex-rs/core/tests/sandbox.rs (#2317)

  Previous to this PR, `codex-rs/core/tests/sandbox.rs` contained
  integration tests that were specific to Seatbelt. This PR moves those
  tests to `codex-rs/core/src/seatbelt.rs` and designates
  `codex-rs/core/tests/sandbox.rs` to be used as the home for
  cross-platform (well, Mac and Linux...) sandbox tests.
  
  To start, this migrates
  `python_multiprocessing_lock_works_under_seatbelt()` from #1823 to the
  new `sandbox.rs` because this is the type of thing that should work on
  both Mac _and_ Linux, though I still need to do some work to clean up
  the test so it works on both platforms.

  Michael Bolin · 2025-08-14 14:48:38 -07:00
  a8c7f5391c
• [context] Store context messages in rollouts (#2243)

  ## Summary
  Currently, we use request-time logic to determine the user_instructions
  and environment_context messages. This means that neither of these
  values can change over time as conversations go on. We want to add in
  additional details here, so we're migrating these to save these messages
  to the rollout file instead. This is simpler for the client, and allows
  us to append additional environment_context messages to each turn if we
  want
  
  ## Testing
  - [x] Integration test coverage
  - [x] Tested locally with a few turns, confirmed model could reference
  environment context and cached token metrics were reasonably high

  Dylan · 2025-08-14 14:51:13 -04:00
  544980c008
• chore: introduce ConversationManager as a clearinghouse for all conversations (#2240)

  This PR does two things because after I got deep into the first one I
  started pulling on the thread to the second:
  
  - Makes `ConversationManager` the place where all in-memory
  conversations are created and stored. Previously, `MessageProcessor` in
  the `codex-mcp-server` crate was doing this via its `session_map`, but
  this is something that should be done in `codex-core`.
  - It unwinds the `ctrl_c: tokio::sync::Notify` that was threaded
  throughout our code. I think this made sense at one time, but now that
  we handle Ctrl-C within the TUI and have a proper `Op::Interrupt` event,
  I don't think this was quite right, so I removed it. For `codex exec`
  and `codex proto`, we now use `tokio::signal::ctrl_c()` directly, but we
  no longer make `Notify` a field of `Codex` or `CodexConversation`.
  
  Changes of note:
  
  - Adds the files `conversation_manager.rs` and `codex_conversation.rs`
  to `codex-core`.
  - `Codex` and `CodexSpawnOk` are no longer exported from `codex-core`:
  other crates must use `CodexConversation` instead (which is created via
  `ConversationManager`).
  - `core/src/codex_wrapper.rs` has been deleted in favor of
  `ConversationManager`.
  - `ConversationManager::new_conversation()` returns `NewConversation`,
  which is in line with the `new_conversation` tool we want to add to the
  MCP server. Note `NewConversation` includes `SessionConfiguredEvent`, so
  we eliminate checks in cases like `codex-rs/core/tests/client.rs` to
  verify `SessionConfiguredEvent` is the first event because that is now
  internal to `ConversationManager`.
  - Quite a bit of code was deleted from
  `codex-rs/mcp-server/src/message_processor.rs` since it no longer has to
  manage multiple conversations itself: it goes through
  `ConversationManager` instead.
  - `core/tests/live_agent.rs` has been deleted because I had to update a
  bunch of tests and all the tests in here were ignored, and I don't think
  anyone ever ran them, so this was just technical debt, at this point.
  - Removed `notify_on_sigint()` from `util.rs` (and in a follow-up, I
  hope to refactor the blandly-named `util.rs` into more descriptive
  files).
  - In general, I started replacing local variables named `codex` as
  `conversation`, where appropriate, though admittedly I didn't do it
  through all the integration tests because that would have added a lot of
  noise to this PR.
  
  
  
  
  ---
  [//]: # (BEGIN SAPLING FOOTER)
  Stack created with [Sapling](https://sapling-scm.com). Best reviewed
  with [ReviewStack](https://reviewstack.dev/openai/codex/pull/2240).
  * #2264
  * #2263
  * __->__ #2240

  Michael Bolin · 2025-08-13 13:38:18 -07:00
  08ed618f72
• Re-add markdown streaming (#2029)

  Wait for newlines, then render markdown on a line by line basis. Word wrap it for the current terminal size and then spit it out line by line into the UI. Also adds tests and fixes some UI regressions.

  easong-openai · 2025-08-12 17:37:28 -07:00
  6340acd885
• [prompts] integration test prompt caching (#2189)

  ## Summary
  Our current approach to prompt caching is fragile! The current approach
  works, but we are planning to update to a more resilient system (storing
  them in the rollout file). Let's start adding some integration tests to
  ensure stability while we migrate it.
  
  ## Testing
  - [x] These are the tests 😎

  Dylan · 2025-08-11 17:03:13 -07:00
  d33793d31d