5 Commits

• fix: fix clippy issue in examples/ folder (#18184)

  I believe this use of `expect()` was introduced in
  https://github.com/openai/codex/pull/17826, but was not flagged by CI.
  Though I did see it in the diagnostics panel in VS Code, so it's worth
  cleaning up.
  
  I guess our current CI does include `examples/` when running Clippy?

  Michael Bolin · 2026-04-16 12:48:31 -07:00
  ea34c6ed8d
• [codex] Add remote thread store implementation (#17826)

  - Add a "remote" thread store implementation
  - Implement the remote thread store as a thin wrapper that makes grpc
  calls to a configurable service endpoint
  - Implement only the thread/list method to start
  - Encode the grpc method/param shape as protobufs in the remote
  implementation
  
  A wart: the proto generation script is an "example" binary target. This
  is an example target only because Cargo lets examples use
  dev-dependencies, which keeps tonic-prost-build out of the normal
  codex-thread-store dependency surface. A regular bin would either need
  to add proto generation deps as normal runtime deps, or use a
  feature-gated optional dep, which this repo’s manifest checks explicitly
  reject.

  Tom · 2026-04-16 10:15:31 -07:00
  6e72f0dbfd
• Migrate archive/unarchive to local ThreadStore (#17892)

  # Summary
  - implement local ThreadStore archive/unarchive operations
  - implement local ThreadStore read_thread operation
  - break up the various ThreadStore local method implementations into
  separate files
  - migrate app-server archive/unarchive and core archive fixture to use
  ThreadStore (but not all read operations yet!)
  - use the ThreadStore's read operation as a proxy check for thread
  persistence/existence in the app server code
  - move all other filesystem operations related to archive (path
  validation etc) into the local thread store.
  
  # Tests
  - add dedicated local store archive/unarchive tests

  Tom · 2026-04-15 20:48:09 +00:00
  50d3128269
• [codex] Add local thread store listing (#17824)

  Builds on top of #17659 
  
  Move the filesystem + sqlite thread listing-related operations inside of
  a local ThreadStore implementation and call ThreadStore from the places
  that used to perform these filesystem/sqlite operations.
  
  This is the first of a series of PRs that will implement the rest of the
  local ThreadStore.
  
  Testing:
  - added unit tests for the thread store implementation
  - adjusted some unit tests in the realtime + personality packages whose
  callsites changed. Specifically I'm trying to hide ThreadMetadata inside
  of the local implementation and make ThreadMetadata a sqlite
  implementation detail concern rather than a public interface, preferring
  the more generate StoredThread interface instead
  - added a corner case test for the personality migration package that
  wasn't covered by the existing test suite
  - adjust the behavior of searched thread listing to run the existing
  local rollout repair/backfill pass _before_ querying SQLite results, so
  callers using ThreadStore::list_threads do not miss matches after a
  partial metadata warm-up

  Tom · 2026-04-15 11:34:27 -07:00
  cdfcd2ca92
• ThreadStore interface (#17659)

  Introduce a ThreadStore interface for mediating access to the filesystem
  (rollout jsonl files + sqlite db) based thread storage.
  
  In later PRs we'll move the existing fs code behind a "local"
  implementation of this ThreadStore interface.
  
  This PR should be a no-op behaviorally, it only introduces the
  interface.

  Tom · 2026-04-14 13:51:00 -07:00
  dae56994da