31 Commits

• [codex] reduce module visibility (#16978)

  ## Summary
  - reduce public module visibility across Rust crates, preferring private
  or crate-private modules with explicit crate-root public exports
  - update external call sites and tests to use the intended public crate
  APIs instead of reaching through module trees
  - add the module visibility guideline to AGENTS.md
  
  ## Validation
  - `cargo check --workspace --all-targets --message-format=short` passed
  before the final fix/format pass
  - `just fix` completed successfully
  - `just fmt` completed successfully
  - `git diff --check` passed

  pakrym-oai · 2026-04-07 08:03:35 -07:00
  413c1e1fdf
• chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

  ## Why
  
  `argument-comment-lint` was green in CI even though the repo still had
  many uncommented literal arguments. The main gap was target coverage:
  the repo wrapper did not force Cargo to inspect test-only call sites, so
  examples like the `latest_session_lookup_params(true, ...)` tests in
  `codex-rs/tui_app_server/src/lib.rs` never entered the blocking CI path.
  
  This change cleans up the existing backlog, makes the default repo lint
  path cover all Cargo targets, and starts rolling that stricter CI
  enforcement out on the platform where it is currently validated.
  
  ## What changed
  
  - mechanically fixed existing `argument-comment-lint` violations across
  the `codex-rs` workspace, including tests, examples, and benches
  - updated `tools/argument-comment-lint/run-prebuilt-linter.sh` and
  `tools/argument-comment-lint/run.sh` so non-`--fix` runs default to
  `--all-targets` unless the caller explicitly narrows the target set
  - fixed both wrappers so forwarded cargo arguments after `--` are
  preserved with a single separator
  - documented the new default behavior in
  `tools/argument-comment-lint/README.md`
  - updated `rust-ci` so the macOS lint lane keeps the plain wrapper
  invocation and therefore enforces `--all-targets`, while Linux and
  Windows temporarily pass `-- --lib --bins`
  
  That temporary CI split keeps the stricter all-targets check where it is
  already cleaned up, while leaving room to finish the remaining Linux-
  and Windows-specific target-gated cleanup before enabling
  `--all-targets` on those runners. The Linux and Windows failures on the
  intermediate revision were caused by the wrapper forwarding bug, not by
  additional lint findings in those lanes.
  
  ## Validation
  
  - `bash -n tools/argument-comment-lint/run.sh`
  - `bash -n tools/argument-comment-lint/run-prebuilt-linter.sh`
  - shell-level wrapper forwarding check for `-- --lib --bins`
  - shell-level wrapper forwarding check for `-- --tests`
  - `just argument-comment-lint`
  - `cargo test` in `tools/argument-comment-lint`
  - `cargo test -p codex-terminal-detection`
  
  ## Follow-up
  
  - Clean up remaining Linux-only target-gated callsites, then switch the
  Linux lint lane back to the plain wrapper invocation.
  - Clean up remaining Windows-only target-gated callsites, then switch
  the Windows lint lane back to the plain wrapper invocation.

  Michael Bolin · 2026-03-27 19:00:44 -07:00
  61dfe0b86c
• Apply argument comment lint across codex-rs (#14652)

  ## Why
  
  Once the repo-local lint exists, `codex-rs` needs to follow the
  checked-in convention and CI needs to keep it from drifting. This commit
  applies the fallback `/*param*/` style consistently across existing
  positional literal call sites without changing those APIs.
  
  The longer-term preference is still to avoid APIs that require comments
  by choosing clearer parameter types and call shapes. This PR is
  intentionally the mechanical follow-through for the places where the
  existing signatures stay in place.
  
  After rebasing onto newer `main`, the rollout also had to cover newly
  introduced `tui_app_server` call sites. That made it clear the first cut
  of the CI job was too expensive for the common path: it was spending
  almost as much time installing `cargo-dylint` and re-testing the lint
  crate as a representative test job spends running product tests. The CI
  update keeps the full workspace enforcement but trims that extra
  overhead from ordinary `codex-rs` PRs.
  
  ## What changed
  
  - keep a dedicated `argument_comment_lint` job in `rust-ci`
  - mechanically annotate remaining opaque positional literals across
  `codex-rs` with exact `/*param*/` comments, including the rebased
  `tui_app_server` call sites that now fall under the lint
  - keep the checked-in style aligned with the lint policy by using
  `/*param*/` and leaving string and char literals uncommented
  - cache `cargo-dylint`, `dylint-link`, and the relevant Cargo
  registry/git metadata in the lint job
  - split changed-path detection so the lint crate's own `cargo test` step
  runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes
  - continue to run the repo wrapper over the `codex-rs` workspace, so
  product-code enforcement is unchanged
  
  Most of the code changes in this commit are intentionally mechanical
  comment rewrites or insertions driven by the lint itself.
  
  ## Verification
  
  - `./tools/argument-comment-lint/run.sh --workspace`
  - `cargo test -p codex-tui-app-server -p codex-tui`
  - parsed `.github/workflows/rust-ci.yml` locally with PyYAML
  
  ---
  
  * -> #14652
  * #14651

  Michael Bolin · 2026-03-16 16:48:15 -07:00
  b77fe8fefe
• feat: search_tool migrate to bring you own tool of Responses API (#14274)

  ## Why
  
  to support a new bring your own search tool in Responses
  API(https://developers.openai.com/api/docs/guides/tools-tool-search#client-executed-tool-search)
  we migrating our bm25 search tool to use official way to execute search
  on client and communicate additional tools to the model.
  
  ## What
  - replace the legacy `search_tool_bm25` flow with client-executed
  `tool_search`
  - add protocol, SSE, history, and normalization support for
  `tool_search_call` and `tool_search_output`
  - return namespaced Codex Apps search results and wire namespaced
  follow-up tool calls back into MCP dispatch

  Anton Panasenko · 2026-03-11 17:51:51 -07:00
  77b0c75267
• Remove Responses V1 websocket implementation (#13364)

  V2 is the way to go!

  pakrym-oai · 2026-03-03 11:32:53 -07:00
  69df12efb3
• Chore: remove response model check and rely on header model for downgrade (#12061)

  ### Summary
  Ensure that we use the model value from the response header only so that
  we are guaranteed with the correct slug name. We are no longer checking
  against the model value from response so that we are less likely to have
  false positive.
  
  There are two different treatments - for SSE we use the header from the
  response and for websocket we check top-level events.

  Shijie Rao · 2026-02-18 01:50:06 +00:00
  b3a8571219
• add(core): safety check downgrade warning (#11964)

  Add per-turn notice when a request is downgraded to a fallback model due
  to cyber safety checks.
  
  **Changes**
  
  - codex-api: Emit a ServerModel event based on the openai-model response
  header and/or response payload (SSE + WebSocket), including when the
  model changes mid-stream.
  - core: When the server-reported model differs from the requested model,
  emit a single per-turn warning explaining the reroute to gpt-5.2 and
  directing users to Trusted
      Access verification and the cyber safety explainer.
  - app-server (v2): Surface these cyber model-routing warnings as
  synthetic userMessage items with text prefixed by Warning: (and document
  this behavior).

  Fouad Matin · 2026-02-16 22:13:36 -08:00
  02e9006547
• Handle response.incomplete (#11558)

  Treat it same as error.

  pakrym-oai · 2026-02-12 00:11:38 -08:00
  fd7f2aedc7
• change model cap to server overload (#11388)

  # External (non-OpenAI) Pull Request Requirements
  
  Before opening this Pull Request, please read the dedicated
  "Contributing" markdown file or your PR may be closed:
  https://github.com/openai/codex/blob/main/docs/contributing.md
  
  If your PR conforms to our contribution guidelines, replace this text
  with a detailed and high quality description of your changes.
  
  Include a link to a bug report or enhancement request.

  willwang-openai · 2026-02-11 17:16:27 -08:00
  3f1b41689a
• Do not attempt to append after response.completed (#11402)

  Completed responses are fully done, and new response must be created.

  pakrym-oai · 2026-02-11 07:45:17 -08:00
  eac5473114
• feat: support multiple rate limits (#11260)

  Added multi-limit support end-to-end by carrying limit_name in
  rate-limit snapshots and handling multiple buckets instead of only
  codex.
  Extended /usage client parsing to consume additional_rate_limits
  Updated TUI /status and in-memory state to store/render per-limit
  snapshots
  Extended app-server rate-limit read response: kept rate_limits and added
  rate_limits_by_name.
  Adjusted usage-limit error messaging for non-default codex limit buckets

  xl-openai · 2026-02-10 20:09:31 -08:00
  fdd0cd1de9
• Add a codex.rate_limits event for websockets (#10324)

  When communicating over websockets, we can't rely on headers to deliver
  rate limit information. This PR adds a `codex.rate_limits` event that
  the server can pass to the client to inform them about rate limit usage.
  The client parses this data the same way we parse rate limit headers in
  HTTP mode.
  
  This PR also wires up the etag and reasoning headers for websockets

  Rasmus Rygaard · 2026-02-04 06:01:47 -08:00
  df000da917
• chore: nuke chat/completions API (#10157)
  jif-oai · 2026-02-03 11:31:57 +00:00
  d2394a2494
• chore: add phase to message responseitem (#10455)

  ### What
  
  add wiring for `phase` field on `ResponseItem::Message` to lay
  groundwork for differentiating model preambles and final messages.
  currently optional.
  
  follows pattern in #9698.
  
  updated schemas with `just write-app-server-schema` so we can see type
  changes.
  
  ### Tests
  Updated existing tests for SSE parsing and hydrating from history

  sayan-oai · 2026-02-03 02:52:26 +00:00
  fc05374344
• Add websocket telemetry metrics and labels (#10316)

  Summary
  - expose websocket telemetry hooks through the responses client so
  request durations and event processing can be reported
  - record websocket request/event metrics and emit runtime telemetry
  events that the history UI now surfaces
  - improve tests to cover websocket telemetry reporting and guard runtime
  summary updates
  
  
  <img width="824" height="79" alt="Screenshot 2026-01-31 at 5 28 12 PM"
  src="https://github.com/user-attachments/assets/ea9a7965-d8b4-4e3c-a984-ef4fdc44c81d"
  />

  Anton Panasenko · 2026-01-31 19:16:44 -08:00
  101d359cd7
• fix: handle all web_search actions and in progress invocations (#9960)

  ### Summary
  - Parse all `web_search` tool actions (`search`, `find_in_page`,
  `open_page`).
  - Previously we only parsed + displayed `search`, which made the TUI
  appear to pause when the other actions were being used.
  - Show in progress `web_search` calls as `Searching the web`
    - Previously we only showed completed tool calls
  
  <img width="308" height="149" alt="image"
  src="https://github.com/user-attachments/assets/90a4e8ff-b06a-48ff-a282-b57b31121845"
  />
  
  ### Tests
  Added + updated tests, tested locally
  
  ### Follow ups
  Update VSCode extension to display these as well

  sayan-oai · 2026-01-27 03:33:48 +00:00
  86adf53235
• Support end_turn flag (#9698)

  Experimental flag that signals the end of the turn.

  pakrym-oai · 2026-01-22 17:27:48 +00:00
  b511c38ddb
• Act on reasoning-included per turn (#9402)

  - Reset reasoning-included flag each turn and update compaction test

  Ahmed Ibrahim · 2026-01-19 11:23:25 -08:00
  b11e96fb04
• fix(codex-api): treat invalid_prompt as non-retryable (#9400)

  **Goal**: Prevent response.failed events with `invalid_prompt` from
  being treated as retryable errors so the UI shows the actual error
  message instead of continually retrying.
  
  **Before**: Codex would continue to retry despite the prompt being
  marked as disallowed
  **After**: Codex will stop retrying once prompt is marked disallowed

  Fouad Matin · 2026-01-16 22:22:08 -08:00
  93a5e0fe1c
• Turn-state sticky routing per turn (#9332)

  - capture the header from SSE/WS handshakes, store it per
  ModelClientSession using `Oncelock`, echo it on turn-scoped requests,
  and add SSE+WS integration tests for within-turn persistence +
  cross-turn reset.
  
  - keep `x-codex-turn-state` sticky within a user turn to maintain
  routing continuity for retries/tool follow-ups.

  Ahmed Ibrahim · 2026-01-16 09:30:11 -08:00
  ebdd8795e9
• fix: eliminate unnecessary clone() for each SSE event (#9238)

  Given how many SSE events we get, seems worth fixing.

  Michael Bolin · 2026-01-15 00:06:09 +00:00
  3728db11b8
• fix: Emit response.completed immediately for Responses SSE (#9170)

  we see windows test failures like this:
  https://github.com/openai/codex/actions/runs/20930055601/job/60138344260.
  
  The issue is that SSE connections sometimes remain open after the
  completion event esp. for windows. We should emit the completion event
  and return immediately. this is consistent with the protocol:
  
  > The Model streams responses back in an SSE, which are collected until
  "completed" message and the SSE terminates
  
  from
  https://github.com/openai/codex/blob/dev/cc/fix-windows-test/codex-rs/docs/protocol_v1.md#L37.
  
  this helps us achieve parity with responses websocket logic here:
  https://github.com/openai/codex/blob/dev/cc/fix-windows-test/codex-rs/codex-api/src/endpoint/responses_websocket.rs#L220-L227.

  Celia Chen · 2026-01-14 10:05:00 -08:00
  02f67bace8
• Support response.done and add integration tests (#9129)

  The agent loop using a persistent incremental web socket connection.

  pakrym-oai · 2026-01-13 16:12:30 +00:00
  2d56519ecd
• Add model client sessions (#9102)

  Maintain a long-running session.

  pakrym-oai · 2026-01-13 01:15:56 +00:00
  490c1c1fdd
• Extract single responses SSE event parsing (#9114)

  To be reused in WebSockets parsing.

  pakrym-oai · 2026-01-12 13:59:51 -08:00
  3a6a43ff5c
• Log unhandled sse events (#8949)
  pakrym-oai · 2026-01-09 12:36:07 -08:00
  cabf85aa18
• fix(codex-api): handle Chat Completions DONE sentinel (#8708)

  Context
  - This code parses Server-Sent Events (SSE) from the legacy Chat
  Completions streaming API (wire_api = "chat").
  - The upstream protocol terminates a stream with a final sentinel event:
  data: [DONE].
  - Some of our test stubs/helpers historically end the stream with data:
  DONE (no brackets).
  
  How this was found
  - GitHub Actions on Windows failed in codex-app-server integration tests
  with wiremock verification errors (expected multiple POSTs, got 1).
  
  Diagnosis
  - The job logs included: codex_api::sse::chat: Failed to parse
  ChatCompletions SSE event ... data: DONE.
  - eventsource_stream surfaces the sentinel as a normal SSE event; it
  does not automatically close the stream.
  - The parser previously attempted to JSON-decode every data: payload.
  The sentinel is not JSON, so we logged and skipped it, then continued
  polling.
  - On servers that keep the HTTP connection open after emitting the
  sentinel (notably wiremock on Windows), skipping the sentinel meant we
  never emitted ResponseEvent::Completed.
  - Higher layers wait for completion before progressing (emitting
  approval requests and issuing follow-up model calls), so the test never
  reached the subsequent requests and wiremock panicked when its
  expected-call count was not met.
  
  Fix
  - Treat both data: [DONE] and data: DONE as explicit end-of-stream
  sentinels.
  - When a sentinel is seen, flush any pending assistant/reasoning items
  and emit ResponseEvent::Completed once.
  
  Tests
  - Add a regression unit test asserting we complete on the sentinel even
  if the underlying connection is not closed.

  Josh McKinney · 2026-01-05 09:29:42 -08:00
  bba5e5e0d4
• Refresh on models etag mismatch (#8491)

  - Send models etag
  - Refresh models on 412
  - This wires `ModelsManager` to `ModelFamily` so we don't mutate it
  mid-turn

  Ahmed Ibrahim · 2026-01-01 11:41:16 -08:00
  66b7c673e9
• fix: chat completion with parallel tool call (#7634)
  jif-oai · 2025-12-05 10:20:36 -08:00
  5f80ad6da8
• fix: sse for chat (#7594)
  jif-oai · 2025-12-04 16:46:56 -08:00
  6736d1828d
• chore: proper client extraction (#6996)
  jif-oai · 2025-11-25 18:06:12 +00:00
  4502b1b263