codex

fix: race condition unified exec (#3644 )

Fix race condition without storing an rx in the session

jimmyfraiture2 · 2025-09-15 06:52:39 -07:00

d555b68469

fix(core): flaky test completed_commands_do_not_persist_sessions (#3596 )

Fix flaky test:
```
        FAIL [   2.641s] codex-core unified_exec::tests::completed_commands_do_not_persist_sessions
  stdout ───

    running 1 test
    test unified_exec::tests::completed_commands_do_not_persist_sessions ... FAILED

    failures:

    failures:
        unified_exec::tests::completed_commands_do_not_persist_sessions

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 235 filtered out; finished in 2.63s
    
  stderr ───

    thread 'unified_exec::tests::completed_commands_do_not_persist_sessions' panicked at core/src/unified_exec/mod.rs:582:9:
    assertion failed: result.output.contains("codex")
```

Fouad Matin · 2025-09-14 18:04:05 -07:00

5185d69f13

Unified execution (#3288 )

## Unified PTY-Based Exec Tool

Note: this requires to have this flag in the config:
`use_experimental_unified_exec_tool=true`

- Adds a PTY-backed interactive exec feature (“unified_exec”) with
session reuse via
  session_id, bounded output (128 KiB), and timeout clamping (≤ 60 s).
- Protocol: introduces ResponseItem::UnifiedExec { session_id,
arguments, timeout_ms }.
- Tools: exposes unified_exec as a function tool (Responses API);
excluded from Chat
  Completions payload while still supported in tool lists.
- Path handling: resolves commands via PATH (or explicit paths), with
UTF‑8/newline‑aware
  truncation (truncate_middle).
- Tests: cover command parsing, path resolution, session
persistence/cleanup, multi‑session
  isolation, timeouts, and truncation behavior.

jif-oai · 2025-09-10 17:38:11 -07:00

c09ed74a16

chore: require uninlined_format_args from clippy (#2845 )

- added `uninlined_format_args` to `[workspace.lints.clippy]` in the
`Cargo.toml` for the workspace
- ran `cargo clippy --tests --fix`
- ran `just fmt`

Michael Bolin · 2025-08-28 11:25:23 -07:00

74d2741729

fix: Scope ExecSessionManager to Session instead of using global singleton (#2664 )

The `SessionManager` in `exec_command` owns a number of
`ExecCommandSession` objects where `ExecCommandSession` has a
non-trivial implementation of `Drop`, so we want to be able to drop an
individual `SessionManager` to help ensure things get cleaned up in a
timely fashion. To that end, we should have one `SessionManager` per
session rather than one global one for the lifetime of the CLI process.

Michael Bolin · 2025-08-24 22:52:49 -07:00

295ca27e98

feat: StreamableShell with exec_command and write_stdin tools (#2574 )

Michael Bolin · 2025-08-22 18:10:55 -07:00

e3b03eaccb

6 Commits