2 Commits

• [codex] Remove async_trait from first-party code (#27475)

  ## Why
  
  First-party async traits should expose their `Send` contracts explicitly
  without requiring `async_trait`. This completes the migration pattern
  established in #27303 and #27304.
  
  ## What changed
  
  - Replaced the remaining first-party `async_trait` traits with native
  return-position `impl Future + Send` where statically dispatched and
  explicit boxed `Send` futures where object safety is required.
  - Kept implementations behavior-preserving, outlining existing async
  bodies into inherent methods where that keeps the diff reviewable.
  - Removed all direct first-party `async-trait` dependencies and the
  workspace dependency declaration.
  - Added a cargo-deny policy that permits `async-trait` only through the
  remaining transitive wrapper crates.
  - Updated `rand` from 0.8.5 to 0.8.6 to resolve RUSTSEC-2026-0097 and
  keep the full cargo-deny check passing.
  
  ## Validation
  
  - `just test -p codex-exec-server`: 216 passed, 2 skipped.
  - `just test -p codex-model-provider`: 39 passed.
  - `just test -p codex-core` and `just test`: changed tests passed;
  remaining failures are environment-sensitive suites unrelated to this
  migration.
  - `cargo deny check`
  - `just fix`
  - `just fmt`
  - `cargo shear`
  - `just bazel-lock-check`

  Adam Perry @ OpenAI · 2026-06-11 18:16:39 -07:00
  5a56caf18c
• cloud-tasks: split the mock client out of cloud-tasks-client (#16456)

  ## Why
  
  `codex-cloud-tasks-client` was mixing two different roles: the real HTTP
  client and the mock implementation used by tests and local mock mode.
  Keeping both in the same crate forced Cargo feature toggles and Bazel
  `crate_features` just to pick an implementation.
  
  This change keeps `codex-cloud-tasks-client` focused on the shared API
  surface and real backend client, and moves the mock implementation into
  its own crate so we can remove those feature permutations cleanly.
  
  ## What changed
  
  - add a new `codex-cloud-tasks-mock-client` crate that owns `MockClient`
  - remove the `mock` and `online` features from
  `codex-cloud-tasks-client`
  - make `codex-cloud-tasks-client` unconditionally depend on
  `codex-backend-client` and export `HttpClient` directly
  - gate the mock-mode path in `codex-cloud-tasks` behind
  `#[cfg(debug_assertions)]`, so release builds always initialize the real
  HTTP client
  - update `codex-cloud-tasks` and its tests to use
  `codex-cloud-tasks-mock-client::MockClient` wherever mock behavior is
  needed
  - remove the matching Bazel `crate_features` override and shrink the
  manifest verifier allowlist accordingly
  
  ## How tested
  
  - `cargo test -p codex-cloud-tasks-client`
  - `cargo test -p codex-cloud-tasks-mock-client`
  - `cargo test -p codex-cloud-tasks`
  
  ---
  [//]: # (BEGIN SAPLING FOOTER)
  Stack created with [Sapling](https://sapling-scm.com). Best reviewed
  with [ReviewStack](https://reviewstack.dev/openai/codex/pull/16456).
  * #16457
  * __->__ #16456

  Michael Bolin · 2026-04-01 12:09:14 -07:00
  9f0be146db