5 Commits

• make tests pass cleanly in sandbox (#4067)

  This changes the reqwest client used in tests to be sandbox-friendly,
  and skips a bunch of other tests that don't work inside the
  sandbox/without network.

  Jeremy Rose · 2025-09-25 13:11:14 -07:00
  4a5f05c136
• chore: clippy on redundant closure (#4058)

  Add redundant closure clippy rules and let Codex fix it by minimising
  FQP

  jif-oai · 2025-09-22 19:30:16 +00:00
  be366a31ab
• Add non_sandbox_test helper (#3880)

  Makes tests shorter

  pakrym-oai · 2025-09-22 14:50:41 +00:00
  14a115d488
• chore: try to make it easier to debug the flakiness of test_shell_command_approval_triggers_elicitation (#2848)

  `test_shell_command_approval_triggers_elicitation()` is one of a number
  of integration tests that we have observed to be flaky on GitHub CI, so
  this PR tries to reduce the flakiness _and_ to provide us with more
  information when it flakes. Specifically:
  
  - Changed the command that we use to trigger the elicitation from `git
  init` to `python3 -c 'import pathlib; pathlib.Path(r"{}").touch()'`
  because running `git` seems more likely to invite variance.
  - Increased the timeout to wait for the task response from 10s to 20s.
  - Added more logging.

  Michael Bolin · 2025-08-28 12:33:33 -07:00
  1e9e703b96
• test: faster test execution in codex-core (#2633)

  this dramatically improves time to run `cargo test -p codex-core` (~25x
  speedup).
  
  before:
  ```
  cargo test -p codex-core  35.96s user 68.63s system 19% cpu 8:49.80 total
  ```
  
  after:
  ```
  cargo test -p codex-core  5.51s user 8.16s system 63% cpu 21.407 total
  ```
  
  both tests measured "hot", i.e. on a 2nd run with no filesystem changes,
  to exclude compile times.
  
  approach inspired by [Delete Cargo Integration
  Tests](https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html),
  we move all test cases in tests/ into a single suite in order to have a
  single binary, as there is significant overhead for each test binary
  executed, and because test execution is only parallelized with a single
  binary.

  Jeremy Rose · 2025-08-24 11:10:53 -07:00
  32bbbbad61