9 Commits

• [codex] Use expect in integration tests (#28441)

  The workspace denies `clippy::expect_used` in production. Although
  `clippy.toml` allows `expect` in tests, Bazel Clippy compiles
  integration-test helper code in a way that does not receive that
  exemption, which encouraged verbose `unwrap_or_else(... panic!(...))`
  and equivalent `match`/`let else` forms.
  
  This allows `clippy::expect_used` once at each integration-test crate
  root (including aggregated suites and test-support libraries), then
  replaces manual panic-based Result and Option unwraps with
  `expect`/`expect_err`. Standalone `tests/*.rs` files remain their own
  crate roots. Intentional assertion and unexpected-variant panics remain
  unchanged, and the production `expect_used = "deny"` lint remains in
  place.
  
  The cleanup is mechanical and net-negative in line count.

  pakrym-oai · 2026-06-15 21:53:47 -07:00
  e752f7b4ae
• [codex] reduce module visibility (#16978)

  ## Summary
  - reduce public module visibility across Rust crates, preferring private
  or crate-private modules with explicit crate-root public exports
  - update external call sites and tests to use the intended public crate
  APIs instead of reaching through module trees
  - add the module visibility guideline to AGENTS.md
  
  ## Validation
  - `cargo check --workspace --all-targets --message-format=short` passed
  before the final fix/format pass
  - `just fix` completed successfully
  - `just fmt` completed successfully
  - `git diff --check` passed

  pakrym-oai · 2026-04-07 08:03:35 -07:00
  413c1e1fdf
• tui: remove debug/test-only crate features (#16457)

  ## Why
  
  The remaining `vt100-tests` and `debug-logs` features in `codex-tui`
  were only gating test-only and debug-only behavior. Those feature
  toggles add Cargo and Bazel permutations without buying anything, and
  they make it easier for more crate features to linger in the workspace.
  
  ## What changed
  
  - delete `vt100-tests` and `debug-logs` from `codex-tui`
  - always compile the VT100 integration tests in the TUI test target
  instead of hiding them behind a Cargo feature
  - remove the unused textarea debug logging branch instead of replacing
  it with another gate
  - add the required argument-comment annotations in the VT100 tests now
  that Bazel sees those callsites during linting
  - shrink the manifest verifier allowlist again so only the remaining
  real feature exceptions stay permitted
  
  ## How tested
  
  - `cargo test -p codex-tui`
  - `just argument-comment-lint -p codex-tui`

  Michael Bolin · 2026-04-01 12:40:33 -07:00
  d1043ef90e
• Rename tui_app_server to tui (#16104)

  This is a follow-up to https://github.com/openai/codex/pull/15922. That
  previous PR deleted the old `tui` directory and left the new
  `tui_app_server` directory in place. This PR renames `tui_app_server` to
  `tui` and fixes up all references.

  Eric Traut · 2026-03-28 11:23:07 -06:00
  61429a6c10
• Remove the legacy TUI split (#15922)

  This is the part 1 of 2 PRs that will delete the `tui` /
  `tui_app_server` split. This part simply deletes the existing `tui`
  directory and marks the `tui_app_server` feature flag as removed. I left
  the `tui_app_server` feature flag in place for now so its presence
  doesn't result in an error. It is simply ignored.
  
  Part 2 will rename the `tui_app_server` directory `tui`. I did this as
  two parts to reduce visible code churn.

  Eric Traut · 2026-03-27 22:56:44 +00:00
  d65deec617
• fix(tui): propagate errors in insert_history_lines_to_writer (#4266)

  ## What?
  Fixed error handling in `insert_history_lines_to_writer` where all
  terminal operations were silently ignoring errors via `.ok()`.
  
    ## Why?
  Silent I/O failures could leave the terminal in an inconsistent state
  (e.g., scroll region not reset) with no way to debug. This violates Rust
  error handling best practices.
  
    ## How?
    - Changed function signature to return `io::Result<()>`
    - Replaced all `.ok()` calls with `?` operator to propagate errors
  - Added `tracing::warn!` in wrapper function for backward compatibility
    - Updated 15 test call sites to handle Result  with `.expect()`
  
    ## Testing
    - ✅ Pass all tests
  
    ## Type of Change
    - [x] Bug fix (non-breaking change)
  
  ---------
  
  Signed-off-by: Huaiwu Li <lhwzds@gmail.com>
  Co-authored-by: Eric Traut <etraut@openai.com>

  Huaiwu Li · 2025-10-30 18:07:51 -07:00
  9a638dbf4e
• update composer + user message styling (#4240)

  Changes:
  
  - the composer and user messages now have a colored background that
  stretches the entire width of the terminal.
  - the prompt character was changed from a cyan `▌` to a bold `›`.
  - the "working" shimmer now follows the "dark gray" color of the
  terminal, better matching the terminal's color scheme
  
  | Terminal + Background        | Screenshot |
  |------------------------------|------------|
  | iTerm with dark bg | <img width="810" height="641" alt="Screenshot
  2025-09-25 at 11 44 52 AM"
  src="https://github.com/user-attachments/assets/1317e579-64a9-4785-93e6-98b0258f5d92"
  /> |
  | iTerm with light bg | <img width="845" height="540" alt="Screenshot
  2025-09-25 at 11 46 29 AM"
  src="https://github.com/user-attachments/assets/e671d490-c747-4460-af0b-3f8d7f7a6b8e"
  /> |
  | iTerm with color bg | <img width="825" height="564" alt="Screenshot
  2025-09-25 at 11 47 12 AM"
  src="https://github.com/user-attachments/assets/141cda1b-1164-41d5-87da-3be11e6a3063"
  /> |
  | Terminal.app with dark bg | <img width="577" height="367"
  alt="Screenshot 2025-09-25 at 11 45 22 AM"
  src="https://github.com/user-attachments/assets/93fc4781-99f7-4ee7-9c8e-3db3cd854fe5"
  /> |
  | Terminal.app with light bg | <img width="577" height="367"
  alt="Screenshot 2025-09-25 at 11 46 04 AM"
  src="https://github.com/user-attachments/assets/19bf6a3c-91e0-447b-9667-b8033f512219"
  /> |
  | Terminal.app with color bg | <img width="577" height="367"
  alt="Screenshot 2025-09-25 at 11 45 50 AM"
  src="https://github.com/user-attachments/assets/dd7c4b5b-342e-4028-8140-f4e65752bd0b"
  /> |

  Jeremy Rose · 2025-09-26 16:35:56 -07:00
  43b63ccae8
• prefer ratatui Stylized for constructing lines/spans (#3068)

  no functional change, just simplifying ratatui styling and adding
  guidance in AGENTS.md for future.

  Jeremy Rose · 2025-09-02 23:19:54 +00:00
  578ff09e17
• test: faster test execution in codex-core (#2633)

  this dramatically improves time to run `cargo test -p codex-core` (~25x
  speedup).
  
  before:
  ```
  cargo test -p codex-core  35.96s user 68.63s system 19% cpu 8:49.80 total
  ```
  
  after:
  ```
  cargo test -p codex-core  5.51s user 8.16s system 63% cpu 21.407 total
  ```
  
  both tests measured "hot", i.e. on a 2nd run with no filesystem changes,
  to exclude compile times.
  
  approach inspired by [Delete Cargo Integration
  Tests](https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html),
  we move all test cases in tests/ into a single suite in order to have a
  single binary, as there is significant overhead for each test binary
  executed, and because test execution is only parallelized with a single
  binary.

  Jeremy Rose · 2025-08-24 11:10:53 -07:00
  32bbbbad61