From f6a7da4ac3760b8442e9c104612bb1478ccfd9b9 Mon Sep 17 00:00:00 2001
From: Michael Bolin <mbolin@openai.com>
Date: Tue, 2 Dec 2025 12:46:26 -0800
Subject: [PATCH] fix: drop lock once it is no longer needed (#7500)

I noticed this while doing a post-commit review of https://github.com/openai/codex/pull/7467.
---
 codex-rs/core/src/mcp_connection_manager.rs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/codex-rs/core/src/mcp_connection_manager.rs b/codex-rs/core/src/mcp_connection_manager.rs
index e8c289b57..11a90f77a 100644
--- a/codex-rs/core/src/mcp_connection_manager.rs
+++ b/codex-rs/core/src/mcp_connection_manager.rs
@@ -151,8 +151,10 @@ impl ElicitationRequestManager {
             let server_name = server_name.clone();
             async move {
                 let (tx, rx) = oneshot::channel();
-                let mut lock = elicitation_requests.lock().await;
-                lock.insert((server_name.clone(), id.clone()), tx);
+                {
+                    let mut lock = elicitation_requests.lock().await;
+                    lock.insert((server_name.clone(), id.clone()), tx);
+                }
                 let _ = tx_event
                     .send(Event {
                         id: "mcp_elicitation_request".to_string(),