diff --git a/.github/workflows/README.md b/.github/workflows/README.md index e7bad8267..d14817f00 100644 --- a/.github/workflows/README.md +++ b/.github/workflows/README.md @@ -5,15 +5,15 @@ The workflows in this directory are split so that pull requests get fast, review ## Pull Requests - `bazel.yml` is the main pre-merge verification path for Rust code. - It runs Bazel `test` and Bazel `clippy` on the supported Bazel targets. + It runs Bazel `test` and Bazel `clippy` on the supported Bazel targets, + including the generated Rust test binaries needed to lint inline `#[cfg(test)]` + code. - `rust-ci.yml` keeps the Cargo-native PR checks intentionally small: - `cargo fmt --check` - `cargo shear` - `argument-comment-lint` on Linux, macOS, and Windows - `tools/argument-comment-lint` package tests when the lint or its workflow wiring changes -The PR workflow still keeps the Linux lint lane on the default-targets-only invocation for now, but the released linter runs on Linux, macOS, and Windows before merge. - ## Post-Merge On `main` - `bazel.yml` also runs on pushes to `main`. diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index f7f16dd99..30f066163 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -154,13 +154,17 @@ jobs: mkdir -p "${RUNNER_TEMP}/bazel-execution-logs" echo "CODEX_BAZEL_EXECUTION_LOG_COMPACT_DIR=${RUNNER_TEMP}/bazel-execution-logs" >> "${GITHUB_ENV}" - - name: bazel build --config=clippy //codex-rs/... + - name: bazel build --config=clippy lint targets env: BUILDBUDDY_API_KEY: ${{ secrets.BUILDBUDDY_API_KEY }} shell: bash run: | - # Keep the initial Bazel clippy scope on codex-rs and out of the - # V8 proof-of-concept target for now. + bazel_target_lines="$(./scripts/list-bazel-clippy-targets.sh)" + bazel_targets=() + while IFS= read -r target; do + bazel_targets+=("${target}") + done <<< "${bazel_target_lines}" + ./.github/scripts/run-bazel-ci.sh \ -- \ build \ @@ -168,8 +172,7 @@ jobs: --build_metadata=COMMIT_SHA=${GITHUB_SHA} \ --build_metadata=TAG_job=clippy \ -- \ - //codex-rs/... \ - -//codex-rs/v8-poc:all + "${bazel_targets[@]}" - name: Upload Bazel execution logs if: always() && !cancelled() diff --git a/justfile b/justfile index 7dc6ae100..43afbf93d 100644 --- a/justfile +++ b/justfile @@ -69,8 +69,9 @@ bazel-lock-check: bazel-test: bazel test --test_tag_filters=-argument-comment-lint //... --keep_going +[no-cd] bazel-clippy: - bazel build --config=clippy -- //codex-rs/... -//codex-rs/v8-poc:all + bazel_targets="$(./scripts/list-bazel-clippy-targets.sh)" && bazel build --config=clippy -- ${bazel_targets} [no-cd] bazel-argument-comment-lint: diff --git a/scripts/list-bazel-clippy-targets.sh b/scripts/list-bazel-clippy-targets.sh new file mode 100755 index 000000000..d6351d1f8 --- /dev/null +++ b/scripts/list-bazel-clippy-targets.sh @@ -0,0 +1,20 @@ +#!/usr/bin/env bash + +set -euo pipefail + +repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" +cd "${repo_root}" + +# Resolve the dynamic targets before printing anything so callers do not +# continue with a partial list if `bazel query` fails. +manual_rust_test_targets="$(bazel query 'kind("rust_test rule", attr(tags, "manual", //codex-rs/... except //codex-rs/v8-poc/...))')" + +printf '%s\n' \ + "//codex-rs/..." \ + "-//codex-rs/v8-poc:all" + +# `--config=clippy` on the `workspace_root_test` wrappers does not lint the +# underlying `rust_test` binaries. Add the internal manual `*-unit-tests-bin` +# targets explicitly so inline `#[cfg(test)]` code is linted like +# `cargo clippy --tests`. +printf '%s\n' "${manual_rust_test_targets}"