From ea34c6ed8de87c72616ac08c9c5e399ebd1f9c58 Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Thu, 16 Apr 2026 12:48:31 -0700 Subject: [PATCH] fix: fix clippy issue in examples/ folder (#18184) I believe this use of `expect()` was introduced in https://github.com/openai/codex/pull/17826, but was not flagged by CI. Though I did see it in the diagnostics panel in VS Code, so it's worth cleaning up. I guess our current CI does include `examples/` when running Clippy? --- codex-rs/thread-store/examples/generate-proto.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/codex-rs/thread-store/examples/generate-proto.rs b/codex-rs/thread-store/examples/generate-proto.rs index aa159f5bc..0b4afb54f 100644 --- a/codex-rs/thread-store/examples/generate-proto.rs +++ b/codex-rs/thread-store/examples/generate-proto.rs @@ -1,7 +1,12 @@ use std::path::PathBuf; fn main() -> Result<(), Box> { - let proto_dir = PathBuf::from(std::env::args().nth(1).expect("proto dir")); + let Some(proto_dir_arg) = std::env::args().nth(1) else { + eprintln!("Usage: generate-proto "); + std::process::exit(1); + }; + + let proto_dir = PathBuf::from(proto_dir_arg); let proto_file = proto_dir.join("codex.thread_store.v1.proto"); tonic_prost_build::configure()