[codex] Use expect in integration tests (#28441)

The workspace denies `clippy::expect_used` in production. Although
`clippy.toml` allows `expect` in tests, Bazel Clippy compiles
integration-test helper code in a way that does not receive that
exemption, which encouraged verbose `unwrap_or_else(... panic!(...))`
and equivalent `match`/`let else` forms.

This allows `clippy::expect_used` once at each integration-test crate
root (including aggregated suites and test-support libraries), then
replaces manual panic-based Result and Option unwraps with
`expect`/`expect_err`. Standalone `tests/*.rs` files remain their own
crate roots. Intentional assertion and unexpected-variant panics remain
unchanged, and the production `expect_used = "deny"` lint remains in
place.

The cleanup is mechanical and net-negative in line count.

codex-rs/exec/tests/all.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::expect_used)]
+
 // Single integration test binary that aggregates all test modules.
 // The submodules live in `tests/suite/`.
 mod suite;

codex-rs/exec/tests/suite/add_dir.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;

codex-rs/exec/tests/suite/agents_md.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;

codex-rs/exec/tests/suite/apply_patch.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::expect_used, clippy::unwrap_used, unused_imports)]
+#![allow(clippy::unwrap_used, unused_imports)]
 
 use anyhow::Context;
 use assert_cmd::prelude::*;
@@ -87,8 +87,7 @@ async fn test_apply_patch_tool() -> anyhow::Result<()> {
         .success();
 
     let final_path = tmp_path.join("test.md");
-    let contents = std::fs::read_to_string(&final_path)
-        .unwrap_or_else(|e| panic!("failed reading {}: {e}", final_path.display()));
+    let contents = std::fs::read_to_string(&final_path).expect("final file should be readable");
     assert_eq!(contents, "Final text\n");
     Ok(())
 }
@@ -139,8 +138,7 @@ async fn test_apply_patch_freeform_tool() -> anyhow::Result<()> {
 
     // Verify final file contents
     let final_path = test.cwd_path().join("app.py");
-    let contents = std::fs::read_to_string(&final_path)
-        .unwrap_or_else(|e| panic!("failed reading {}: {e}", final_path.display()));
+    let contents = std::fs::read_to_string(&final_path).expect("final file should be readable");
     assert_eq!(
         contents,
         include_str!("../fixtures/apply_patch_freeform_final.txt")

codex-rs/exec/tests/suite/approval_policy.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;

codex-rs/exec/tests/suite/auth_env.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::unwrap_used, clippy::expect_used)]
+#![allow(clippy::unwrap_used)]
 use core_test_support::responses::ev_completed;
 use core_test_support::responses::mount_sse_once_match;
 use core_test_support::responses::sse;

codex-rs/exec/tests/suite/ephemeral.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::skip_if_no_network;

codex-rs/exec/tests/suite/hooks.rs

@@ -1,5 +1,4 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;

codex-rs/exec/tests/suite/mcp_required_exit.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;

codex-rs/exec/tests/suite/originator.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use codex_login::default_client::CODEX_INTERNAL_ORIGINATOR_OVERRIDE_ENV_VAR;
 use core_test_support::responses;

codex-rs/exec/tests/suite/output_schema.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;

codex-rs/exec/tests/suite/prompt_stdin.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;

codex-rs/exec/tests/suite/resume.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::unwrap_used, clippy::expect_used)]
+#![allow(clippy::unwrap_used)]
 use anyhow::Context;
 use core_test_support::responses;
 use core_test_support::skip_if_no_network;

codex-rs/exec/tests/suite/sandbox.rs

@@ -522,7 +522,6 @@ async fn allow_unix_socketpair_recvfrom() {
 
 const IN_SANDBOX_ENV_VAR: &str = "IN_SANDBOX";
 
-#[expect(clippy::expect_used)]
 pub async fn run_code_under_sandbox<F, Fut>(
     test_selector: &str,
     permission_profile: &PermissionProfile,

codex-rs/exec/tests/suite/server_error_exit.rs

@@ -1,5 +1,5 @@
 #![cfg(not(target_os = "windows"))]
-#![allow(clippy::expect_used, clippy::unwrap_used)]
+#![allow(clippy::unwrap_used)]
 
 use core_test_support::responses;
 use core_test_support::test_codex_exec::test_codex_exec;