Revert "Overhaul shell detection and centralize command generation for unified exec" (#6606)

Reverts openai/codex#6577
This commit is contained in:
pakrym-oai
2025-11-13 08:43:00 -08:00
committed by GitHub
Unverified
parent d28e912214
commit e6995174c1
11 changed files with 411 additions and 283 deletions
+8 -4
View File
@@ -64,8 +64,10 @@ impl UnifiedExecContext {
}
#[derive(Debug)]
pub(crate) struct ExecCommandRequest {
pub command: Vec<String>,
pub(crate) struct ExecCommandRequest<'a> {
pub command: &'a str,
pub shell: &'a str,
pub login: bool,
pub yield_time_ms: Option<u64>,
pub max_output_tokens: Option<usize>,
pub workdir: Option<PathBuf>,
@@ -103,7 +105,7 @@ struct SessionEntry {
session_ref: Arc<Session>,
turn_ref: Arc<TurnContext>,
call_id: String,
command: Vec<String>,
command: String,
cwd: PathBuf,
started_at: tokio::time::Instant,
}
@@ -195,7 +197,9 @@ mod tests {
.unified_exec_manager
.exec_command(
ExecCommandRequest {
command: vec!["bash".to_string(), "-lc".to_string(), cmd.to_string()],
command: cmd,
shell: "/bin/bash",
login: true,
yield_time_ms,
max_output_tokens: None,
workdir: None,