agent/codex
2
0
Fork 0
mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Send beta header with websocket connects (#10727)

Browse Source
This commit is contained in:
pakrym-oai
2026-02-05 15:05:02 -08:00
committed by GitHub
parent 378f1cabe8
commit dbe47ea01a
2 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/core/src/client.rs
+23 -8
View File
@@ -82,6 +82,8 @@ use crate::model_provider_info::ModelProviderInfo;
use crate::model_provider_info::WireApi; use crate::model_provider_info::WireApi;
use crate::tools::spec::create_tools_json_for_responses_api; use crate::tools::spec::create_tools_json_for_responses_api;
pub const OPENAI_BETA_HEADER: &str = "OpenAI-Beta";
pub const OPENAI_BETA_RESPONSES_WEBSOCKETS: &str = "responses_websockets=2026-02-04";
pub const X_CODEX_TURN_STATE_HEADER: &str = "x-codex-turn-state"; pub const X_CODEX_TURN_STATE_HEADER: &str = "x-codex-turn-state";
pub const X_CODEX_TURN_METADATA_HEADER: &str = "x-codex-turn-metadata"; pub const X_CODEX_TURN_METADATA_HEADER: &str = "x-codex-turn-metadata";
pub const X_RESPONSESAPI_INCLUDE_TIMING_METRICS_HEADER: &str = pub const X_RESPONSESAPI_INCLUDE_TIMING_METRICS_HEADER: &str =
@@ -477,14 +479,8 @@ impl ModelClientSession {
}; };
if needs_new { if needs_new {
let mut headers = options.extra_headers.clone(); let headers =
headers.extend(build_conversation_headers(options.conversation_id.clone())); build_websocket_connect_headers(options, self.client.state.include_timing_metrics);
if self.client.state.include_timing_metrics {
headers.insert(
X_RESPONSESAPI_INCLUDE_TIMING_METRICS_HEADER,
HeaderValue::from_static("true"),
);
}
let websocket_telemetry = Self::build_websocket_telemetry(otel_manager); let websocket_telemetry = Self::build_websocket_telemetry(otel_manager);
let new_conn: ApiWebSocketConnection = let new_conn: ApiWebSocketConnection =
ApiWebSocketResponsesClient::new(api_provider, api_auth) ApiWebSocketResponsesClient::new(api_provider, api_auth)
@@ -787,6 +783,25 @@ fn build_responses_headers(
headers headers
} }
fn build_websocket_connect_headers(
options: &ApiResponsesOptions,
include_timing_metrics: bool,
) -> ApiHeaderMap {
let mut headers = options.extra_headers.clone();
headers.extend(build_conversation_headers(options.conversation_id.clone()));
headers.insert(
OPENAI_BETA_HEADER,
HeaderValue::from_static(OPENAI_BETA_RESPONSES_WEBSOCKETS),
);
if include_timing_metrics {
headers.insert(
X_RESPONSESAPI_INCLUDE_TIMING_METRICS_HEADER,
HeaderValue::from_static("true"),
);
}
headers
}
fn map_response_stream<S>(api_stream: S, otel_manager: OtelManager) -> ResponseStream fn map_response_stream<S>(api_stream: S, otel_manager: OtelManager) -> ResponseStream
where where
S: futures::Stream<Item = std::result::Result<ResponseEvent, ApiError>> S: futures::Stream<Item = std::result::Result<ResponseEvent, ApiError>>
codex-rs/core/tests/suite/client_websockets.rs
+7
View File
@@ -40,6 +40,8 @@ use tempfile::TempDir;
use tracing_test::traced_test; use tracing_test::traced_test;
const MODEL: &str = "gpt-5.2-codex"; const MODEL: &str = "gpt-5.2-codex";
const OPENAI_BETA_HEADER: &str = "OpenAI-Beta";
const OPENAI_BETA_RESPONSES_WEBSOCKETS: &str = "responses_websockets=2026-02-04";
struct WebsocketTestHarness { struct WebsocketTestHarness {
_codex_home: TempDir, _codex_home: TempDir,
@@ -74,6 +76,11 @@ async fn responses_websocket_streams_request() {
assert_eq!(body["model"].as_str(), Some(MODEL)); assert_eq!(body["model"].as_str(), Some(MODEL));
assert_eq!(body["stream"], serde_json::Value::Bool(true)); assert_eq!(body["stream"], serde_json::Value::Bool(true));
assert_eq!(body["input"].as_array().map(Vec::len), Some(1)); assert_eq!(body["input"].as_array().map(Vec::len), Some(1));
let handshake = server.single_handshake();
assert_eq!(
handshake.header(OPENAI_BETA_HEADER),
Some(OPENAI_BETA_RESPONSES_WEBSOCKETS.to_string())
);
server.shutdown().await; server.shutdown().await;
} }