agent/codex
2
0
Fork 0
mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(auto-review) feature => stable (#19063)

Browse Source 
## Summary
Turn on Auto Review

## Testing
- [x] Update unit tests
This commit is contained in:
Dylan Hurd
2026-04-22 18:51:39 -07:00
committed by GitHub
parent 8f0a92c1e5
commit c6ab601824
5 changed files with 16 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/features/src/lib.rs
+2 -6
View File
@@ -917,12 +917,8 @@ pub const FEATURES: &[FeatureSpec] = &[
FeatureSpec {
id: Feature::GuardianApproval,
key: "guardian_approval",
stage: Stage::Experimental {
name: "Auto-review",
menu_description: "When Codex needs approval for higher-risk actions (e.g. sandbox escapes or blocked network access), route eligible approval requests to a carefully-prompted security reviewer subagent rather than blocking the agent on your input. This can consume significantly more tokens because it runs a subagent on every approval request.",
announcement: "",
},
default_enabled: false,
stage: Stage::Stable,
default_enabled: true,
},
FeatureSpec {
id: Feature::CollaborationModes,
codex-rs/features/src/tests.rs
+3 -12
View File
@@ -87,20 +87,11 @@ fn code_mode_only_requires_code_mode() {
}
#[test]
fn guardian_approval_is_experimental_and_user_toggleable() {
fn guardian_approval_is_stable_and_enabled_by_default() {
let spec = Feature::GuardianApproval.info();
let stage = spec.stage;
assert!(matches!(stage, Stage::Experimental { .. }));
assert_eq!(stage.experimental_menu_name(), Some("Auto-review"));
assert_eq!(
stage.experimental_menu_description().map(str::to_owned),
Some(
"When Codex needs approval for higher-risk actions (e.g. sandbox escapes or blocked network access), route eligible approval requests to a carefully-prompted security reviewer subagent rather than blocking the agent on your input. This can consume significantly more tokens because it runs a subagent on every approval request.".to_string()
)
);
assert_eq!(stage.experimental_announcement(), None);
assert_eq!(Feature::GuardianApproval.default_enabled(), false);
assert_eq!(spec.stage, Stage::Stable);
assert_eq!(Feature::GuardianApproval.default_enabled(), true);
}
#[test]