diff --git a/codex-rs/core/src/codex.rs b/codex-rs/core/src/codex.rs index a496d246e..ac879d3e6 100644 --- a/codex-rs/core/src/codex.rs +++ b/codex-rs/core/src/codex.rs @@ -643,7 +643,6 @@ impl Session { } maybe_push_chat_wire_api_deprecation(&config, &mut post_session_configured_events); - // todo(aibrahim): why are we passing model here while it can change? let otel_manager = OtelManager::new( conversation_id, session_configuration.model.as_str(), diff --git a/codex-rs/core/src/context_manager/history_tests.rs b/codex-rs/core/src/context_manager/history_tests.rs index 1fb47e1e6..a89020f7e 100644 --- a/codex-rs/core/src/context_manager/history_tests.rs +++ b/codex-rs/core/src/context_manager/history_tests.rs @@ -593,7 +593,6 @@ fn format_exec_output_prefers_line_marker_when_both_limits_exceeded() { assert_truncated_message_matches(&truncated, "line-0-", 17_423); } -//TODO(aibrahim): run CI in release mode. #[cfg(not(debug_assertions))] #[test] fn normalize_adds_missing_output_for_function_call() { diff --git a/codex-rs/tui/src/chatwidget.rs b/codex-rs/tui/src/chatwidget.rs index b4ae8b76a..868319893 100644 --- a/codex-rs/tui/src/chatwidget.rs +++ b/codex-rs/tui/src/chatwidget.rs @@ -2440,19 +2440,16 @@ impl ChatWidget { /// Open a popup to choose a quick auto model. Selecting "All models" /// opens the full picker with every available preset. pub(crate) fn open_model_popup(&mut self) { - let presets: Vec = - // todo(aibrahim): make this async function - match self.models_manager.try_list_models(&self.config) { - Ok(models) => models, - Err(_) => { - self.add_info_message( - "Models are being updated; please try /model again in a moment." - .to_string(), - None, - ); - return; - } - }; + let presets: Vec = match self.models_manager.try_list_models(&self.config) { + Ok(models) => models, + Err(_) => { + self.add_info_message( + "Models are being updated; please try /model again in a moment.".to_string(), + None, + ); + return; + } + }; self.open_model_popup_with_presets(presets); } diff --git a/codex-rs/tui2/src/chatwidget.rs b/codex-rs/tui2/src/chatwidget.rs index 05b66d3ae..bd6506630 100644 --- a/codex-rs/tui2/src/chatwidget.rs +++ b/codex-rs/tui2/src/chatwidget.rs @@ -2236,19 +2236,16 @@ impl ChatWidget { /// Open a popup to choose a quick auto model. Selecting "All models" /// opens the full picker with every available preset. pub(crate) fn open_model_popup(&mut self) { - let presets: Vec = - // todo(aibrahim): make this async function - match self.models_manager.try_list_models(&self.config) { - Ok(models) => models, - Err(_) => { - self.add_info_message( - "Models are being updated; please try /model again in a moment." - .to_string(), - None, - ); - return; - } - }; + let presets: Vec = match self.models_manager.try_list_models(&self.config) { + Ok(models) => models, + Err(_) => { + self.add_info_message( + "Models are being updated; please try /model again in a moment.".to_string(), + None, + ); + return; + } + }; self.open_model_popup_with_presets(presets); }