From b539e3e72bbc8f7282d2dd4ac7bc1ab891e85738 Mon Sep 17 00:00:00 2001 From: Winston Howes Date: Tue, 23 Jun 2026 11:06:07 -0700 Subject: [PATCH] Handle additional tools in rollout persistence metrics (#29669) ## Why The rollout persistence metrics added on current `main` exhaustively match `ResponseItem`, but omit `ResponseItem::AdditionalTools`. That prevents `codex-rollout` and downstream targets from compiling across Cargo and Bazel builds. ## What Map `ResponseItem::AdditionalTools` to the `response.additional_tools` metric label, consistent with the existing exact-variant labels. ## Validation - `just test -p codex-rollout` (76 passed) - `just fix -p codex-rollout` --- codex-rs/rollout/src/persistence_metrics.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/codex-rs/rollout/src/persistence_metrics.rs b/codex-rs/rollout/src/persistence_metrics.rs index c851ea624..911186f68 100644 --- a/codex-rs/rollout/src/persistence_metrics.rs +++ b/codex-rs/rollout/src/persistence_metrics.rs @@ -255,6 +255,7 @@ fn turn_item_type(item: &TurnItem) -> &'static str { fn response_item_type(item: &ResponseItem) -> &'static str { match item { + ResponseItem::AdditionalTools { .. } => "response.additional_tools", ResponseItem::Message { .. } => "response.message", ResponseItem::AdditionalTools { .. } => "response.additional_tools", ResponseItem::AgentMessage { .. } => "response.agent_message",