agent/codex
2
0
Fork 0
mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Guardian -> Auto-Review (#18021)

Browse Source 
This PR is a user-facing change for our rebranding of guardian to
auto-review.
This commit is contained in:
Won Park
2026-04-17 09:56:24 -07:00
committed by GitHub
parent d0eff70383
commit af7b8d551c
21 changed files with 85 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/chatwidget/tests/permissions.rs
+12 -12
View File
@@ -329,7 +329,7 @@ async fn permissions_selection_history_snapshot_full_access_to_default() {
chat.open_permissions_popup();
let popup = render_bottom_popup(&chat, /*width*/ 120);
chat.handle_key_event(KeyEvent::from(KeyCode::Up));
if popup.contains("Guardian Approvals") {
if popup.contains("Auto-review") {
chat.handle_key_event(KeyEvent::from(KeyCode::Up));
}
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
@@ -400,8 +400,8 @@ async fn permissions_selection_hides_guardian_approvals_when_feature_disabled()
let popup = render_bottom_popup(&chat, /*width*/ 120);
assert!(
!popup.contains("Guardian Approvals"),
"expected Guardian Approvals to stay hidden until the experimental feature is enabled: {popup}"
!popup.contains("Auto-review"),
"expected Auto-review to stay hidden until the experimental feature is enabled: {popup}"
);
}
@@ -432,8 +432,8 @@ async fn permissions_selection_hides_guardian_approvals_when_feature_disabled_ev
let popup = render_bottom_popup(&chat, /*width*/ 120);
assert!(
!popup.contains("Guardian Approvals"),
"expected Guardian Approvals to stay hidden when the experimental feature is disabled: {popup}"
!popup.contains("Auto-review"),
"expected Auto-review to stay hidden when the experimental feature is disabled: {popup}"
);
}
@@ -477,8 +477,8 @@ async fn permissions_selection_marks_guardian_approvals_current_after_session_co
let popup = render_bottom_popup(&chat, /*width*/ 120);
assert!(
popup.contains("Guardian Approvals (current)"),
"expected Guardian Approvals to be current after SessionConfigured sync: {popup}"
popup.contains("Auto-review (current)"),
"expected Auto-review to be current after SessionConfigured sync: {popup}"
);
}
@@ -531,8 +531,8 @@ async fn permissions_selection_marks_guardian_approvals_current_with_custom_work
let popup = render_bottom_popup(&chat, /*width*/ 120);
assert!(
popup.contains("Guardian Approvals (current)"),
"expected Guardian Approvals to be current even with custom workspace-write details: {popup}"
popup.contains("Auto-review (current)"),
"expected Auto-review to be current even with custom workspace-write details: {popup}"
);
}
@@ -567,7 +567,7 @@ async fn permissions_selection_can_disable_guardian_approvals() {
event,
AppEvent::UpdateApprovalsReviewer(ApprovalsReviewer::User)
)),
"expected selecting Default from Guardian Approvals to switch back to manual approval review: {events:?}"
"expected selecting Default from Auto-review to switch back to manual approval review: {events:?}"
);
assert!(
!events
@@ -613,8 +613,8 @@ async fn permissions_selection_sends_approvals_reviewer_in_override_turn_context
assert!(
popup
.lines()
.any(|line| line.contains("Guardian Approvals") && line.contains('›')),
"expected one Down from Default to select Guardian Approvals: {popup}"
.any(|line| line.contains("Auto-review") && line.contains('›')),
"expected one Down from Default to select Auto-review: {popup}"
);
chat.handle_key_event(KeyEvent::from(KeyCode::Enter));
codex-rs/tui/src/chatwidget/tests/popups_and_settings.rs
+2 -2
View File
@@ -1465,11 +1465,11 @@ async fn experimental_popup_includes_guardian_approval() {
let normalized_popup = popup.split_whitespace().collect::<Vec<_>>().join(" ");
assert!(
popup.contains(guardian_name),
"expected guardian approvals entry in experimental popup, got:\n{popup}"
"expected auto-review entry in experimental popup, got:\n{popup}"
);
assert!(
normalized_popup.contains(guardian_description),
"expected guardian approvals description in experimental popup, got:\n{popup}"
"expected auto-review description in experimental popup, got:\n{popup}"
);
}