From 8614f92fc433fff20b1bf745be8b23cfb01d3d98 Mon Sep 17 00:00:00 2001 From: pakrym-oai Date: Tue, 7 Apr 2026 12:01:06 -0700 Subject: [PATCH] [codex] Fix unified exec test build (#17032) ## Summary - Remove the stale `?` after `AbsolutePathBuf::join` in the unified exec integration test helper. ## Root Cause - `AbsolutePathBuf::join` was made infallible, but `core/tests/suite/unified_exec.rs` still treated it as a `Result`, which broke the Windows test build for the `all` integration test target. ## Validation - `just fmt` - `cargo test -p codex-core --test all unified_exec_resolves_relative_workdir` --- codex-rs/core/tests/suite/unified_exec.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codex-rs/core/tests/suite/unified_exec.rs b/codex-rs/core/tests/suite/unified_exec.rs index 226c5c6af..a165db045 100644 --- a/codex-rs/core/tests/suite/unified_exec.rs +++ b/codex-rs/core/tests/suite/unified_exec.rs @@ -171,7 +171,7 @@ async fn create_workspace_directory( test: &TestCodex, rel_path: impl AsRef, ) -> Result { - let abs_path = test.config.cwd.join(rel_path.as_ref())?; + let abs_path = test.config.cwd.join(rel_path.as_ref()); test.fs() .create_directory(&abs_path, CreateDirectoryOptions { recursive: true }) .await?;